git: 1f398acbc991 - stable/14 - fixup_pci: Remove unused attach DEVMETHOD
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 01 Dec 2024 04:57:05 UTC
The branch stable/14 has been updated by jhb:
URL: https://cgit.FreeBSD.org/src/commit/?id=1f398acbc9917c2671fdcd128cce7b49b86e6e01
commit 1f398acbc9917c2671fdcd128cce7b49b86e6e01
Author: John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2024-10-31 19:49:05 +0000
Commit: John Baldwin <jhb@FreeBSD.org>
CommitDate: 2024-12-01 02:46:05 +0000
fixup_pci: Remove unused attach DEVMETHOD
The probe routine always fails, so the attach routine is unused.
However, this weird driver is really a quirk system for PCI and should
be turned into PCI quirks instead. The Natoma quirk is also broken as
it should be doing a runtime check either on mp_ncpus (or more likely
to see if it is using APIC) instead of #ifdef.
Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D47219
(cherry picked from commit 1cddce89ce30570d554120af864d23c554cd5d18)
---
sys/dev/pci/fixup_pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sys/dev/pci/fixup_pci.c b/sys/dev/pci/fixup_pci.c
index 5f4e881d5c76..56ee1e93cbe2 100644
--- a/sys/dev/pci/fixup_pci.c
+++ b/sys/dev/pci/fixup_pci.c
@@ -56,7 +56,6 @@ static void fixc1_nforce2(device_t dev);
static device_method_t fixup_pci_methods[] = {
/* Device interface */
DEVMETHOD(device_probe, fixup_pci_probe),
- DEVMETHOD(device_attach, bus_generic_attach),
{ 0, 0 }
};