git: 7663542fd713 - stable/14 - sctp: add missing check
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 03 Aug 2024 22:23:11 UTC
The branch stable/14 has been updated by tuexen:
URL: https://cgit.FreeBSD.org/src/commit/?id=7663542fd71312e2648d212bf74c77fff310862e
commit 7663542fd71312e2648d212bf74c77fff310862e
Author: Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2024-05-08 21:01:06 +0000
Commit: Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2024-08-03 22:21:39 +0000
sctp: add missing check
If memory allocation fails, m is NULL. Since this is possible,
check for it.
Reported by: Coverity Scan
CID: 1086866
(cherry picked from commit 3d40cc7ab888a37a3ba085f377a057396a7d2476)
---
sys/netinet/sctp_output.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sys/netinet/sctp_output.c b/sys/netinet/sctp_output.c
index a8facff6b917..e0106831f06a 100644
--- a/sys/netinet/sctp_output.c
+++ b/sys/netinet/sctp_output.c
@@ -6705,7 +6705,9 @@ sctp_sendall_iterator(struct sctp_inpcb *inp, struct sctp_tcb *stcb, void *ptr,
} else {
m = sctp_get_mbuf_for_msg(sizeof(struct sctp_paramhdr),
0, M_NOWAIT, 1, MT_DATA);
- SCTP_BUF_LEN(m) = sizeof(struct sctp_paramhdr);
+ if (m != NULL) {
+ SCTP_BUF_LEN(m) = sizeof(struct sctp_paramhdr);
+ }
}
if (m != NULL) {
struct sctp_paramhdr *ph;