From nobody Fri Apr 19 07:23:52 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VLR2w35Y1z5J1Xr; Fri, 19 Apr 2024 07:23:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VLR2w1VK5z4WPj; Fri, 19 Apr 2024 07:23:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713511432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AUcphNGBlNwXZAVDciqEIfVz9zkYLBXK3M872fsqmm0=; b=OfijNxtL46fM7VYojtc1Ax9h9oxVB4eG4Jri/OnXNCsWiinxiDGbhyBAp6B/ZVSLyWoWR/ ASEhRNUvpfjaFbnwfcd7JQqp8UKp+DgVG8ibnJXqL6JndSiKlxUF6GSQ1RTaEtCQXqo/Sb BKpjZWLxxYC2X0JPM14upwdsQhJiuyMGdIvtIhtVWwfGU0ApHgDEtdV4iRn++bx2xUj1Mk S0OQ6wQQfnGqgE197Tg3BkABGzS8hsxs+TFjcLXQU34fTm5PM5/rNloI6kSTRlRZUfRyMx CRasO3r363glvstE4qQPjci784NZ5Ikjh+VMUWju6ctDroGZqcBZQDBIt/YPmQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713511432; a=rsa-sha256; cv=none; b=W7pZrNA8fgxlDrpLw8z62NiLzegQkVNb+0pMarw+ehvq62/8YzrOC6wXEpRg6658rEzTds N9ZhBE4Tvqy2ldUaaQDwI4+1IPhadzfOXWJcdl6SdocaGJ3IrNkzSEyZP+f+axbyZEmK4V z+KFzTXLUUm7TOvmrRvGLF50XVVRDczSgfuTwOJuy0cqWIsEbohfe8c41ktFuLZSrRCU8a zXwhQfmNQ1kEYNWBWnOmmjR6c6ItlukMd8u0Z8lwoliz7aepqipjk9erVIKFog8FCufkmO wWw+kZUQFAXOee9HLRaclR+cNrlMM4quMzcZknk33j4AyiIj+rTbpB64c4kU2w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713511432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AUcphNGBlNwXZAVDciqEIfVz9zkYLBXK3M872fsqmm0=; b=UoqRtNR7u/T/gipKOYaNfB23R5I9pUSidgryqj6NMwk22HiyiRX/Y5+lZVk+zu/4pshBuV 3NNp+omFjkpxUCfWknzPTvnh1ThKuSS7lmuo2knpmrEHKTQXluUCKdFfoOuO+HxnnfHZRr g6UjPg9fNq/tkvweqgeEbKijdq6+h2Afsbma7ew62SyWoQ9vXHx61SwuJxAZgJVgOgNDJs Ru6WA57TdfHcULvxl9YBPPItoZxX2mfAA1X3yATWTOtlTt9FWcjCJLVjYhsSQQQ7JoSnbB xMSsrd9Yw+JxbIiWoup2XSLHvCEckvm39taApjHxp3QQyDWE1xrae2vPWm1b2g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VLR2w0nfLzk9P; Fri, 19 Apr 2024 07:23:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43J7NqPG056144; Fri, 19 Apr 2024 07:23:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43J7NqIa056141; Fri, 19 Apr 2024 07:23:52 GMT (envelope-from git) Date: Fri, 19 Apr 2024 07:23:52 GMT Message-Id: <202404190723.43J7NqIa056141@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Zhilin Subject: git: e7a1904fe1ce - stable/13 - snd_hda: fix "duplicated free" on module unloading List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mizhka X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: e7a1904fe1ced461b2a31f03b6592ae6564a243a Auto-Submitted: auto-generated The branch stable/13 has been updated by mizhka: URL: https://cgit.FreeBSD.org/src/commit/?id=e7a1904fe1ced461b2a31f03b6592ae6564a243a commit e7a1904fe1ced461b2a31f03b6592ae6564a243a Author: Michael Zhilin AuthorDate: 2024-04-13 09:59:24 +0000 Commit: Michael Zhilin CommitDate: 2024-04-19 07:23:36 +0000 snd_hda: fix "duplicated free" on module unloading This is trivial fix of hdacc_detach to avoid duplicated free on snd_hda unloading. The first try of detaching (kldunload) may results into "device busy" error, but codec->fgs is freed by detach. Second try attempts to free codec->fgs again and system panicks. Here is example: pcm0: unregister: channel pcm0:virtual:dsp0.vp0 busy (pid 3428) pulseaudio[3428] [oss] module-oss.c: DSP shutdown. pcm0: detached hdaa0: detached panic: Duplicate free of 0xfffff80412ee7d20 from zone 0xfffffe006bc0ba00 (malloc-32) slab 0xfffff80412ee7fc8(105) cpuid = 6 time = 1712999565 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe0202f859e0 vpanic() at vpanic+0x135/frame 0xfffffe0202f85b10 panic() at panic+0x43/frame 0xfffffe0202f85b70 uma_dbg_free() at uma_dbg_free+0x105/frame 0xfffffe0202f85b90 uma_zfree_arg() at uma_zfree_arg+0x95/frame 0xfffffe0202f85be0 free() at free+0xa1/frame 0xfffffe0202f85c20 hdacc_detach() at hdacc_detach+0x2f/frame 0xfffffe0202f85c40 device_detach() at device_detach+0x197/frame 0xfffffe0202f85c80 devclass_driver_deleted() at devclass_driver_deleted+0x66/frame 0xfffffe0202f85c devclass_delete_driver() at devclass_delete_driver+0x81/frame 0xfffffe0202f85d00 driver_module_handler() at driver_module_handler+0xff/frame 0xfffffe0202f85d50 module_unload() at module_unload+0x32/frame 0xfffffe0202f85d70 linker_file_unload() at linker_file_unload+0x1eb/frame 0xfffffe0202f85db0 kern_kldunload() at kern_kldunload+0x18e/frame 0xfffffe0202f85e00 amd64_syscall() at amd64_syscall+0x153/frame 0xfffffe0202f85f30 fast_syscall_common() at fast_syscall_common+0xf8/frame 0xfffffe0202f85f30 MFC after: 3 days Reviewed by: markj, christos Differential Revision: https://reviews.freebsd.org/D44778 Sponsored by: Postgres Professional (cherry picked from commit bed0b2146faa2e9a445d9f9196c7b46f50034631) --- sys/dev/sound/pci/hda/hdacc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/dev/sound/pci/hda/hdacc.c b/sys/dev/sound/pci/hda/hdacc.c index afcc145626e1..86c50a88f3e0 100644 --- a/sys/dev/sound/pci/hda/hdacc.c +++ b/sys/dev/sound/pci/hda/hdacc.c @@ -541,9 +541,10 @@ hdacc_detach(device_t dev) struct hdacc_softc *codec = device_get_softc(dev); int error; - error = device_delete_children(dev); + if ((error = device_delete_children(dev)) != 0) + return (error); free(codec->fgs, M_HDACC); - return (error); + return (0); } static int