From nobody Sat Sep 30 04:38:51 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RyDxl59dmz4vXRr; Sat, 30 Sep 2023 04:38:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RyDxl4Nqyz4k46; Sat, 30 Sep 2023 04:38:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696048731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2mOetfhiGrGtaXZ3SLSdcPfpGQJ2BLHzL6YEtSUIylI=; b=Kxf0WbFbFItQJ/dsSEIKgAmyXMLUjBHnSNWS7Gn/WlWd7GG8jneMJLMYbPyz9FMlMrHy2X WrhRnmYiwvN/LyRs1XGRvWLus0CzfVxbe4dy2KLnki8wGGMAR0DQgpk4dxLn3ztfCAe5Im R550hw4GQ0VmVN3dAe06YAwsBIzbewP3HZJiI5eQcohGXipAhGK8WtCwLdHHpXwSMLWpLD +vu+m+E3VpX9g/HeM/vdN9mZh5E63LYG0r10ifwsXEJ3sXF/fYY0sqBm1N1H0nRBR2PP/u 9oFgyZ49L1JVyFw/DLlZyS0IV2It0WPwt+xMnOchkMxLlFsBZW0bYVpZNyIRmA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696048731; a=rsa-sha256; cv=none; b=j7AhaaMvSe+UpqOb1BCWN8O7oazaqy/A+zg+0LHYqyP6+hTAWbKmY394hE+fvN3R6Nhtxe JDBjy74C4WOmFoLd8n1KiIFDKoaZBJqA9AGECNh5GCt6SzgKeXAdG/txjuJj2VpIrgZ4FK ey7jAhpt8TRIqPt45BFyRvA+++hoLYcrnoqOhP4pruk+G4tedKxujsDhtbBFX/+fU6j6GP ZuZ2K5mKP7svhIuGBUWf5sl3rsqEmQ33tko8s9vpsgNaaViQUCIEWxyPBBrLIz0HPQWyUX 2yjM60x9g9XWs0JF8voVrTITUO1c1IYhlQJPck5MnIdrMd8gzaGG0jiDYhOu7w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696048731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2mOetfhiGrGtaXZ3SLSdcPfpGQJ2BLHzL6YEtSUIylI=; b=wK6tborhi2bat6UonyxG5Erx9sBd9YnCWKKfgVwHn5u8QnySUpvYJ0yCK+QDAcZ0V6a/u4 klUXPpFoI5b3OLvD4Oy78k8qCgUvK+HuRnKO1cOAFIHDMASFd7mCBcx5Pa4iCqV4yD69xP RYKvCz59zWQLIYGQPackOPC0IWd9ZT6UL6HbQh8L+x/QDWMn/U83xD8D4ThEFDtbmgYTGf vgyenv26RkXEfi8bI00UN4iVfVxJHG/P44yI70qHWhJNUwHTrN8xKlQJGf2pc7Qp4+vfyV yj+mi9Vyh5IOW7JELrRpVJrliKwOAprSfRCSsKZszHsD75IoVZrc4DDHNmg6Sw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RyDxl3SFWzZ26; Sat, 30 Sep 2023 04:38:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38U4cpgu015257; Sat, 30 Sep 2023 04:38:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38U4cph3015254; Sat, 30 Sep 2023 04:38:51 GMT (envelope-from git) Date: Sat, 30 Sep 2023 04:38:51 GMT Message-Id: <202309300438.38U4cph3015254@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Guzik Subject: git: fc424de7e192 - stable/14 - vfs cache: Drop known argument of internal cache_recalc_neg_min() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: fc424de7e192bb33793ba1f7ed0c75b961809bf4 Auto-Submitted: auto-generated The branch stable/14 has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=fc424de7e192bb33793ba1f7ed0c75b961809bf4 commit fc424de7e192bb33793ba1f7ed0c75b961809bf4 Author: Olivier Certner AuthorDate: 2023-09-22 21:25:41 +0000 Commit: Mateusz Guzik CommitDate: 2023-09-30 04:37:14 +0000 vfs cache: Drop known argument of internal cache_recalc_neg_min() 'ncnegminpct' is to be passed always, so just drop the unneeded parameter. Sponsored by: The FreeBSD Foundation Reviewed by: mjg Differential Revision: https://reviews.freebsd.org/D41763 (cherry picked from commit 02ef039c284b8a7b1ea40f5f9a851a3cb6af5b31) --- sys/kern/vfs_cache.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c index 0f4d7526ebb5..fdfa4fde2c07 100644 --- a/sys/kern/vfs_cache.c +++ b/sys/kern/vfs_cache.c @@ -990,10 +990,10 @@ SYSCTL_PROC(_vfs_cache, OID_AUTO, nchstats, CTLTYPE_OPAQUE | CTLFLAG_RD | "VFS cache effectiveness statistics"); static void -cache_recalc_neg_min(u_int val) +cache_recalc_neg_min(void) { - neg_min = (ncsize * val) / 100; + neg_min = (ncsize * ncnegminpct) / 100; } static int @@ -1012,7 +1012,7 @@ sysctl_negminpct(SYSCTL_HANDLER_ARGS) if (val < 0 || val > 99) return (EINVAL); ncnegminpct = val; - cache_recalc_neg_min(val); + cache_recalc_neg_min(); return (0); } @@ -2652,7 +2652,7 @@ nchinit(void *dummy __unused) VFS_SMR_ZONE_SET(cache_zone_large_ts); ncsize = desiredvnodes * ncsizefactor; - cache_recalc_neg_min(ncnegminpct); + cache_recalc_neg_min(); nchashtbl = nchinittbl(desiredvnodes * 2, &nchash); ncbuckethash = cache_roundup_2(mp_ncpus * mp_ncpus) - 1; if (ncbuckethash < 7) /* arbitrarily chosen to avoid having one lock */ @@ -2796,7 +2796,7 @@ cache_changesize(u_long newmaxvnodes) } } ncsize = newncsize; - cache_recalc_neg_min(ncnegminpct); + cache_recalc_neg_min(); cache_changesize_set_new(new_nchashtbl, new_nchash); cache_unlock_all_buckets(); cache_unlock_all_vnodes();