git: b086848fc086 - stable/13 - libpfctl: Don't pass stack garbage to free.

From: John Baldwin <jhb_at_FreeBSD.org>
Date: Wed, 06 Sep 2023 21:56:42 UTC
The branch stable/13 has been updated by jhb:

URL: https://cgit.FreeBSD.org/src/commit/?id=b086848fc0862468cba5d736f60f2882b2119c30

commit b086848fc0862468cba5d736f60f2882b2119c30
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2023-03-22 19:33:59 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2023-09-06 21:56:09 +0000

    libpfctl: Don't pass stack garbage to free.
    
    GCC 9 on stable/12 reports a -Wmaybe-uninitialized error for the call
    to free in _pfctl_clear_states.
    
    Reviewed by:    mjg
    Differential Revision:  https://reviews.freebsd.org/D39198
    
    (cherry picked from commit 48c519be0e8005aedc817b1bc1101ad32b67a67a)
---
 lib/libpfctl/libpfctl.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/libpfctl/libpfctl.c b/lib/libpfctl/libpfctl.c
index ae0e63818335..6ade20fcd990 100644
--- a/lib/libpfctl/libpfctl.c
+++ b/lib/libpfctl/libpfctl.c
@@ -922,7 +922,6 @@ static int
 _pfctl_clear_states(int dev, const struct pfctl_kill *kill,
     unsigned int *killed, uint64_t ioctlval)
 {
-	struct pfioc_nv	 nv;
 	nvlist_t	*nvl;
 	int		 ret;
 
@@ -945,7 +944,6 @@ _pfctl_clear_states(int dev, const struct pfctl_kill *kill,
 		*killed = nvlist_get_number(nvl, "killed");
 
 	nvlist_destroy(nvl);
-	free(nv.data);
 
 	return (ret);
 }