Re: git: 02183951bfb1 - stable/13 - Fix build for FreeBSD 13.
- In reply to: Jessica Clarke : "Re: git: 02183951bfb1 - stable/13 - Fix build for FreeBSD 13."
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 03 Sep 2023 21:38:11 UTC
On 2023-09-03 1:30 PM, Jessica Clarke wrote: > On 3 Sep 2023, at 21:18, Xin Li <delphij@FreeBSD.org> wrote: >> >> On 2023-09-03 12:39 PM, Jessica Clarke wrote: >>> On 3 Sep 2023, at 19:49, Xin LI <delphij@FreeBSD.org> wrote: >>>> >>>> The branch stable/13 has been updated by delphij: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=02183951bfb19fda7a199acaeb9223cd28f29de3 >>>> >>>> commit 02183951bfb19fda7a199acaeb9223cd28f29de3 >>>> Author: Xin LI <delphij@FreeBSD.org> >>>> AuthorDate: 2023-09-03 18:49:02 +0000 >>>> Commit: Xin LI <delphij@FreeBSD.org> >>>> CommitDate: 2023-09-03 18:49:02 +0000 >>>> >>>> Fix build for FreeBSD 13. >>>> >>>> The minigzip utility has been removed in FreeBSD 14 but still >>>> exists in FreeBSD 13. The upstream revision e9d5486e removed >>>> prototype definitions, rendering the code no longer compliant >>>> with WARNS=5. >>> Uh, what on earth is upstream doing? Has this been reported / >>> complained about? >> >> I've created a PR for this https://github.com/madler/zlib/pull/855 (by converting the functions to static ones). > > Oh, -Wmissing-prototypes, not calling a function without a prototype. > That’s not a big deal. Why not let WARNS stay as 5 but build with > -Wno-missing-prototypes? I didn't think it was worth the effort as the tool is not being used and is removed in FreeBSD 14, but to your point: https://reviews.freebsd.org/D41707