Re: git: 02183951bfb1 - stable/13 - Fix build for FreeBSD 13.

On 3 Sep 2023, at 19:49, Xin LI <delphij@FreeBSD.org> wrote:
> 
> The branch stable/13 has been updated by delphij:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=02183951bfb19fda7a199acaeb9223cd28f29de3
> 
> commit 02183951bfb19fda7a199acaeb9223cd28f29de3
> Author:     Xin LI <delphij@FreeBSD.org>
> AuthorDate: 2023-09-03 18:49:02 +0000
> Commit:     Xin LI <delphij@FreeBSD.org>
> CommitDate: 2023-09-03 18:49:02 +0000
> 
>    Fix build for FreeBSD 13.
> 
>    The minigzip utility has been removed in FreeBSD 14 but still
>    exists in FreeBSD 13. The upstream revision e9d5486e removed
>    prototype definitions, rendering the code no longer compliant
>    with WARNS=5.

Uh, what on earth is upstream doing? Has this been reported /
complained about?

Jess

> ---
> usr.bin/minigzip/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/usr.bin/minigzip/Makefile b/usr.bin/minigzip/Makefile
> index 6b04d8a65599..e7174694865a 100644
> --- a/usr.bin/minigzip/Makefile
> +++ b/usr.bin/minigzip/Makefile
> @@ -4,7 +4,7 @@ SRCDIR= ${SRCTOP}/sys/contrib/zlib/test
> 
> PROG= minigzip
> 
> -WARNS?= 5
> +WARNS?= 2
> CFLAGS+=-DUSE_MMAP
> LIBADD= z
>