git: 180695b8e643 - stable/12 - amd64 pmap: Prefer consistent naming for loader tunable
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 24 Oct 2023 04:47:15 UTC
The branch stable/12 has been updated by zlei:
URL: https://cgit.FreeBSD.org/src/commit/?id=180695b8e6434891c418cfdde9a32eee8c8fb6f0
commit 180695b8e6434891c418cfdde9a32eee8c8fb6f0
Author: Zhenlei Huang <zlei@FreeBSD.org>
AuthorDate: 2023-10-20 07:31:44 +0000
Commit: Zhenlei Huang <zlei@FreeBSD.org>
CommitDate: 2023-10-24 04:46:30 +0000
amd64 pmap: Prefer consistent naming for loader tunable
The sysctl knob 'vm.pmap.allow_2m_x_ept' is loader tunable and have
public document entry in security(7) but is fetched from kernel
environment 'hw.allow_2m_x_ept'. That is inconsistent and obscure.
As there is public security advisory FreeBSD-SA-19:25.mcepsc [1],
people may refer to it and use 'hw.allow_2m_x_ept', let's keep old
name for compatibility.
[1] https://www.freebsd.org/security/advisories/FreeBSD-SA-19:25.mcepsc.asc
Reviewed by: kib
Fixes: c08973d09c95 Workaround for Intel SKL002/SKL012S errata
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D42311
(cherry picked from commit 9e7f349ff10691c2e3fb03898dbc942794a47566)
(cherry picked from commit 8784b153a31fc0b3a12449a2f0377eb038e6fb7b)
(cherry picked from commit 350e79edf9a8f65c9a9d17aa86ec90b436d638f8)
---
sys/amd64/amd64/pmap.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sys/amd64/amd64/pmap.c b/sys/amd64/amd64/pmap.c
index b2fe589ed029..cf4a96ceabe6 100644
--- a/sys/amd64/amd64/pmap.c
+++ b/sys/amd64/amd64/pmap.c
@@ -1847,7 +1847,10 @@ pmap_allow_2m_x_ept_recalculate(void)
CPUID_TO_MODEL(cpu_id) == 0x57 || /* Knights */
CPUID_TO_MODEL(cpu_id) == 0x85))))
pmap_allow_2m_x_ept = 1;
+#ifndef BURN_BRIDGES
TUNABLE_INT_FETCH("hw.allow_2m_x_ept", &pmap_allow_2m_x_ept);
+#endif
+ TUNABLE_INT_FETCH("vm.pmap.allow_2m_x_ept", &pmap_allow_2m_x_ept);
}
static bool