git: 1d2f963afd83 - stable/14 - LinuxKPI: 802.11: error on state transition failure

From: Bjoern A. Zeeb <bz_at_FreeBSD.org>
Date: Thu, 30 Nov 2023 00:38:16 UTC
The branch stable/14 has been updated by bz:

URL: https://cgit.FreeBSD.org/src/commit/?id=1d2f963afd83b5b06b2a0c143e480e613dbc8608

commit 1d2f963afd83b5b06b2a0c143e480e613dbc8608
Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
AuthorDate: 2023-10-25 22:29:35 +0000
Commit:     Bjoern A. Zeeb <bz@FreeBSD.org>
CommitDate: 2023-11-30 00:36:57 +0000

    LinuxKPI: 802.11: error on state transition failure
    
    The state transition failures we were seeing in the early days are
    solved.  If we now experience one stop processing before passing
    over to net80211 (sta_newstate()) and before updating iv_state on
    the vap.
    
    Sponsored by:   The FreeBSD Foundation
    Reviewed by:    cc
    Differential Revision: https://reviews.freebsd.org/D42423
    
    (cherry picked from commit 45c27ad5241f5491234afd0b47d13b8005fdb4de)
---
 sys/compat/linuxkpi/common/src/linux_80211.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c
index e8fb5b4914a6..3da91fa3e0b7 100644
--- a/sys/compat/linuxkpi/common/src/linux_80211.c
+++ b/sys/compat/linuxkpi/common/src/linux_80211.c
@@ -2137,12 +2137,11 @@ lkpi_iv_newstate(struct ieee80211vap *vap, enum ieee80211_state nstate, int arg)
 	}
 
 	if (error != 0) {
-		/* XXX-BZ currently expected so ignore. */
 		ic_printf(vap->iv_ic, "%s: error %d during state transition "
 		    "%d (%s) -> %d (%s)\n", __func__, error,
 		    ostate, ieee80211_state_name[ostate],
 		    nstate, ieee80211_state_name[nstate]);
-		/* return (error); */
+		return (error);
 	}
 
 #ifdef LINUXKPI_DEBUG_80211