From nobody Fri May 19 08:20:08 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QN0Bw5RHdz4BfBx; Fri, 19 May 2023 08:20:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QN0Bw52JMz4Gp0; Fri, 19 May 2023 08:20:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684484408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rUZjdabN/vSIgUWRFFJ3b9P8vbZBsZyzrzzq/oWcQfQ=; b=EUtcAXqY5h6isdeYVnSfoVhoatpHXuE1zpx7AtC/8z6kwTC1VbnuXKFAz+w/qYzRRqPf3N N85mve9rvAbaV4y8C1C1sgL1U5BsgqCRs9TE9bx+VBgCfm1m12hA3Mtx+Qj0iAhlaiIRiF 3rf4QjnKaID4yGQD0mR3QP/Noo/dvk5bja15TqTnCWRbOF9boFm/XFC+FV6UkEgBLNLK2j HN3oGmDhuqhRTkzh1SBQRaMUaTUx8OH/2q2euUVXtsnwIWwRVvjdMsyOcoEM7cGqPY9Gnm vfdXq1txc7LW9IkCE9Mh7S8QvHlCm5jaO07OIPGirq7oa76igBNnIONTa1LnRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684484408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rUZjdabN/vSIgUWRFFJ3b9P8vbZBsZyzrzzq/oWcQfQ=; b=jdexAHvCnGCTkMmxRVoQKCEhe98+12SSuln+JZo0WojahQSg/BEIx1aJK29NTGgRoUbtvN vZ4LIZ8X68PJziCBrZoRscl10sskkXuYPQcAmk5psfG1E3bqe4B5T0tsYMhVFJY82lRNwk SFtWHsHv8yKGQI670iztSujkFZO0FTZvOp7bJzzFX44Y2h5Ey35u7yBpZaX0HQeM1JQ3qu 9pw/5u8yVVkAua+KPrDffG4YBIrYu6Pz2sm/oNyf/4JeaR+qXRoHoavz7mG+CJCkQwikLO jBiIggzS85ZBuHtsGj6xR9MG463qmLZbmbci0BP/NFctrniB3ZH3fw7lPGMonA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1684484408; a=rsa-sha256; cv=none; b=Fg12nY2lQNEy9KxXFL2I+jSux0SyL2JAifjVXHlQI+vUWyLsFpqG4/1pooazrBmHdtNf2w ghv7cblXGyte4zWSV4fByq8qDn8z7uumkTc8MJheJqLCjppDcyPY+hU6VQsDy6JJUcaLlY 9eMSJJJrhwSSb3YVQRGES9hMRIZnrGfwlm5zJ0kVR8ul230PXDE4vuMG9nvOJD1OOxUdmE lAEm2zO2Mm/2dmjrW4TkjD1yMWeaTVJ+HWZQH4F1gE/oJ9BBHhQcLNN1C8gUouOdOlwwWK kB6MsjMw6squxEdgWsThEBgo7rSlxjs4mwg9IhrYebrP4Kby+9ieYgLl9rr19Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QN0Bw3xZZzLNb; Fri, 19 May 2023 08:20:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 34J8K8I8022033; Fri, 19 May 2023 08:20:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 34J8K8VY022030; Fri, 19 May 2023 08:20:08 GMT (envelope-from git) Date: Fri, 19 May 2023 08:20:08 GMT Message-Id: <202305190820.34J8K8VY022030@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Baptiste Daroussin Subject: git: 554f8644b038 - stable/12 - pw: The pw_checkname function has added ';' checking. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bapt X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: 554f8644b038bc430afaa9a941eb57edb1b4f226 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by bapt: URL: https://cgit.FreeBSD.org/src/commit/?id=554f8644b038bc430afaa9a941eb57edb1b4f226 commit 554f8644b038bc430afaa9a941eb57edb1b4f226 Author: pbuff AuthorDate: 2023-05-16 03:05:30 +0000 Commit: Baptiste Daroussin CommitDate: 2023-05-19 08:19:55 +0000 pw: The pw_checkname function has added ';' checking. The pw_checkname function forgot to include a ';' when checking usernames, causing shell commands to be executed when a username with a ';' is deleted. PR: 271427 MFC After: 3 days (cherry picked from commit e0155c6989049da43c5499f7129002aa17d1ca79) --- usr.sbin/pw/pw_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/pw/pw_user.c b/usr.sbin/pw/pw_user.c index 778855e3d1cd..db2b3e6f6d9b 100644 --- a/usr.sbin/pw/pw_user.c +++ b/usr.sbin/pw/pw_user.c @@ -637,7 +637,7 @@ pw_checkname(char *name, int gecos) showtype = "gecos field"; } else { /* See if the name is valid as a userid or group. */ - badchars = " ,\t:+&#%$^()!@~*?<>=|\\/\""; + badchars = " ,\t:+&#%$^()!@~*?<>=|\\/\";"; showtype = "userid/group name"; /* Userids and groups can not have a leading '-'. */ if (*ch == '-')