From nobody Wed May 03 00:29:37 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q9yWP5KXkz48N33; Wed, 3 May 2023 00:29:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q9yWP4qPjz3mD2; Wed, 3 May 2023 00:29:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683073777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0oBrBDBRfuc0Siu6Z3uCeM7q9WHANXc/jnUc/C+Ixh0=; b=fbg6fm9iljQ6ychDVNYYTExvfmo0n4iHOwkDiU5+kO0wBHmBnTF+mvUHqC6FpYKwgABeXb Vo4FVIJHax96RtIcbs3tQvgNAgUMnA3C7v9tMFK75wfGDczOoqe6g1OWxGR4qx+z5QSW9e Kh7abnvoifsGoqomWMbaS6ZJWV2cnWvFgp9cTOG1yI1qCTbF/f0zqUaxbKomgje8OeUP59 Nb1jfurHw8uxKfBwvU4l1I2dJujSyOja4+0i2okT7tTas2c1lqWhoNmk7BZTuQ9JCrB5yu sh/79AQbhp+Sfe8dDfQcf31YQqMHoumU7Cm1h+E9ocIgUd44IFKLYZx6WZ2J1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683073777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0oBrBDBRfuc0Siu6Z3uCeM7q9WHANXc/jnUc/C+Ixh0=; b=vioKFhi6dRwxfHUPDneTdxV8R/KYlmZzlZ6rM6B64XrBSvVi0XgXdHNnH4u1J9FA+G66Yz AGlFmd43KzqoHnDfVEhFyqjviD8kadidnltNMzpM7fAWLbfLXZUHrwIraQsS85G495pcDb 4stcpF9hc+D6k7Vt1oOFeOQ4Suz+IeQkJhWQGdgjuN1sixJ6EXU7TudcEmsaQRmoRFs+Pt JHtPVnysRbDbsJb0Ff4cxdtCZ0rauH8Nvlu0h3HFkYQe4ZonTtPWtVQkKoXksR9gfcdABM sGEALLlqmjL+SwxI3rONlEH/6RYyO1UEXtzXE4KadaPyt6yvb4/p5tN7cdU1vw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683073777; a=rsa-sha256; cv=none; b=hLeOe9k8b2w2R5hzEJu5Sjz41LSbLEN97hyAxkHnSu275uhPRnLfw3zdPf4MTcs/y+rHb6 kfUY+FNMtjKv7cmP+14vLZa1GN6Lg51KTXUya5LIG1VGYMUKhsLmOZrcSNvHn0oGwahVAl ziMvTFZgzTFEPojCTEWJ/rd1i4zHHiskXBCM+u8yi7IY6kpcxikAb+mRSFtknawIaoUj7M 5pZDTzaDEtLHdi0Dqj5v7ekbzwGlICm0SVkgiJRnuZeU0VpLaVjWe5RdZd8ew4xY1pLOHi qcuaRVaJ//SRvV9xYS0nyR3CYtN0SAZOhqTe4EvKi/YeHIy4DbrdnaQuHc8yMA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q9yWP3wzyz182d; Wed, 3 May 2023 00:29:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 3430TbKC071958; Wed, 3 May 2023 00:29:37 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 3430TbNe071957; Wed, 3 May 2023 00:29:37 GMT (envelope-from git) Date: Wed, 3 May 2023 00:29:37 GMT Message-Id: <202305030029.3430TbNe071957@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 50367e285d40 - stable/13 - pw: Don't return a pointer to an on-stack buffer from grp_set_passwd. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 50367e285d40a8d94192f1e799de21f32c8136a6 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=50367e285d40a8d94192f1e799de21f32c8136a6 commit 50367e285d40a8d94192f1e799de21f32c8136a6 Author: John Baldwin AuthorDate: 2022-12-05 00:28:22 +0000 Commit: John Baldwin CommitDate: 2023-05-03 00:05:05 +0000 pw: Don't return a pointer to an on-stack buffer from grp_set_passwd. Make 'line' static to move it to .bss instead as that pattern is used elsewhere in pw(8) (e.g. the static buffer in pw_pwcrypt). Reported by: GCC -Wdangling-pointer Reviewed by: imp, emaste Differential Revision: https://reviews.freebsd.org/D37534 (cherry picked from commit 1055bedbed42dc176468b45b4f167a752ed8868f) --- usr.sbin/pw/pw_group.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/usr.sbin/pw/pw_group.c b/usr.sbin/pw/pw_group.c index 1f5979a5dd03..838bafa3e8ba 100644 --- a/usr.sbin/pw/pw_group.c +++ b/usr.sbin/pw/pw_group.c @@ -55,7 +55,8 @@ grp_set_passwd(struct group *grp, bool update, int fd, bool precrypted) int b; int istty; struct termios t, n; - char *p, line[256]; + static char line[256]; + char *p; if (fd == -1) return;