From nobody Wed Mar 22 22:28:41 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Phjmp1LW9z41NqV; Wed, 22 Mar 2023 22:28:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Phjmp0tkvz3jP7; Wed, 22 Mar 2023 22:28:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679524122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iHNU1XLbZh6FGEqP/YLyuUpw4THqvPFtNwg5X9cqH2Q=; b=pOND4FzK6Oym5bG4YQ/cZ6z/pY4be78z4xBNhFVF4OApq9JeKWKp5MW0/ZBePAg3KZuOdE Mh/GRapOCAYM2/7CnwsZxOuK1E5SyYmTsNbD7+Nm4nOsOVIDF8AXEUT/NR2eYAcu/dQWXm MowRDXAlULuaTI7JkYsw1Usn+Kp5/mBsi6DLYLbL0f5SSZyTXgDX0vCDl36C+RC0LxIl8Z LcTKQq3KdFVuyaA6p+O8gX3UOctpn5ym16VxdgE3PoDOgTLoXu1B6aT3ij7PMk2MNFFEWT TJB2NifbpKMRXaw1KfgozNWUXjQcC0YOAlPOCCobWU87A702J2q2upO8CCUbnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679524122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iHNU1XLbZh6FGEqP/YLyuUpw4THqvPFtNwg5X9cqH2Q=; b=IXeIqfWjg3bwX7dmG6ljYy21MVQWt91+B2EhQwUKj5sXRc/tWQY3xyvjyfpTfsaKq7v1Od 629cHzs0I4YtGRsDpj3PAlg1lJ9F+titSCYGjCoM5vhyEYM5Yao3sRj61ep0e/7PHyT+d3 yKj/hSulAL8sHX+Yh80mnb0zg483RIWYovsKZp7AJosTuk78RwlLxk9Xwq5c0XdSQZjdgz UkYhxfHLDZdZO06X7SOzSrMJ+ige5dsnB0MXAackJNa5riJkiyxoMJTDp0V+zmZrwvszZq l8z7JzDUaYfHelXxW6q6DAl+hmhHf34FW+FGw9aFj+N5/TikufeRiSFiTR1qcA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679524122; a=rsa-sha256; cv=none; b=J4zYXkbMfYK+Vwzh51KljYtRya433xujFuZqVPkD2fidoFEkjmVPs+rZxfSPWMvmhxzB4+ S8GmLgpzMuCm50VGPTyj9ZZVOijH81AjThKFn2fa0govyD+h+cWlNXTXMURKXDFkaQM/Wm LvAqWeMc12Us7679iSvTL6/yuud01GHFjf1muAbnkn04EF4pR8JnwtOjyGAYHrwnakRkbt dl7cc5R2pEDyxzjUIygNuzoSZ/bPL6nyM5EHmGtOtDUU7PNTsdkfjLkir/ZJgw6jvjLn26 IsONyOYvgQ9zH2LowMsUYhATdtFF3RlFQAVpa9yv6b/youEjw3kPIT7ZaebPHw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Phjmp00Gtz1B95; Wed, 22 Mar 2023 22:28:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 32MMSfXV001896; Wed, 22 Mar 2023 22:28:41 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 32MMSfNT001895; Wed, 22 Mar 2023 22:28:41 GMT (envelope-from git) Date: Wed, 22 Mar 2023 22:28:41 GMT Message-Id: <202303222228.32MMSfNT001895@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 429d95658672 - stable/12 - Stop adding -Wredundant-decls to CWARNFLAGS. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: 429d9565867246e6483d025c2c2f136157b57e66 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=429d9565867246e6483d025c2c2f136157b57e66 commit 429d9565867246e6483d025c2c2f136157b57e66 Author: John Baldwin AuthorDate: 2022-02-07 20:47:51 +0000 Commit: John Baldwin CommitDate: 2023-03-22 19:28:59 +0000 Stop adding -Wredundant-decls to CWARNFLAGS. clang doesn't implement it, and Linux doesn't enforce it. As a result, new instances keep cropping up both in FreeBSD's code and in upstream sources from vendors. Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D34144 (cherry picked from commit c227269e2f9dc2695d00be9e5a72b5fdeec5712a) --- share/mk/bsd.sys.mk | 2 +- sys/conf/kern.mk | 2 +- sys/conf/kern.pre.mk | 2 +- sys/powerpc/conf/QORIQ64 | 2 +- sys/powerpc/conf/dpaa/DPAA | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/share/mk/bsd.sys.mk b/share/mk/bsd.sys.mk index 45f0dcc2c6cf..029af7ae4fd1 100644 --- a/share/mk/bsd.sys.mk +++ b/share/mk/bsd.sys.mk @@ -62,7 +62,7 @@ CWARNFLAGS+= -Wcast-align .endif # !NO_WCAST_ALIGN !NO_WCAST_ALIGN.${COMPILER_TYPE} .endif # WARNS >= 4 .if ${WARNS} >= 6 -CWARNFLAGS+= -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls\ +CWARNFLAGS+= -Wchar-subscripts -Winline -Wnested-externs \ -Wold-style-definition .if !defined(NO_WMISSING_VARIABLE_DECLARATIONS) CWARNFLAGS.clang+= -Wmissing-variable-declarations diff --git a/sys/conf/kern.mk b/sys/conf/kern.mk index 0f311fba2b23..243419103b22 100644 --- a/sys/conf/kern.mk +++ b/sys/conf/kern.mk @@ -3,7 +3,7 @@ # # Warning flags for compiling the kernel and components of the kernel: # -CWARNFLAGS?= -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes \ +CWARNFLAGS?= -Wall -Wnested-externs -Wstrict-prototypes \ -Wmissing-prototypes -Wpointer-arith -Wcast-qual \ -Wundef -Wno-pointer-sign ${FORMAT_EXTENSIONS} \ -Wmissing-include-dirs -fdiagnostics-show-option \ diff --git a/sys/conf/kern.pre.mk b/sys/conf/kern.pre.mk index 7f0099344d18..f0b314e29307 100644 --- a/sys/conf/kern.pre.mk +++ b/sys/conf/kern.pre.mk @@ -171,7 +171,7 @@ NORMAL_FWO= ${LD} -b binary --no-warn-mismatch -d -warn-common -r \ ZSTD_C= ${CC} -c -DZSTD_HEAPMODE=1 -I$S/contrib/zstd/lib/freebsd ${CFLAGS} -I$S/contrib/zstd/lib -I$S/contrib/zstd/lib/common ${WERROR} -Wno-inline -Wno-missing-prototypes ${PROF} -U__BMI__ ${.IMPSRC} # Common for dtrace / zfs -CDDL_CFLAGS= -DFREEBSD_NAMECACHE -nostdinc -I$S/cddl/compat/opensolaris -I$S/cddl/contrib/opensolaris/uts/common -I$S -I$S/cddl/contrib/opensolaris/common ${CFLAGS} -Wno-unknown-pragmas -Wno-missing-prototypes -Wno-undef -Wno-strict-prototypes -Wno-cast-qual -Wno-parentheses -Wno-redundant-decls -Wno-missing-braces -Wno-uninitialized -Wno-unused -Wno-inline -Wno-switch -Wno-pointer-arith -Wno-unknown-pragmas +CDDL_CFLAGS= -DFREEBSD_NAMECACHE -nostdinc -I$S/cddl/compat/opensolaris -I$S/cddl/contrib/opensolaris/uts/common -I$S -I$S/cddl/contrib/opensolaris/common ${CFLAGS} -Wno-unknown-pragmas -Wno-missing-prototypes -Wno-undef -Wno-strict-prototypes -Wno-cast-qual -Wno-parentheses -Wno-missing-braces -Wno-uninitialized -Wno-unused -Wno-inline -Wno-switch -Wno-pointer-arith -Wno-unknown-pragmas CDDL_CFLAGS+= -include $S/cddl/compat/opensolaris/sys/debug_compat.h CDDL_C= ${CC} -c ${CDDL_CFLAGS} ${WERROR} ${PROF} ${.IMPSRC} diff --git a/sys/powerpc/conf/QORIQ64 b/sys/powerpc/conf/QORIQ64 index 348150e83d05..02bbb2585647 100644 --- a/sys/powerpc/conf/QORIQ64 +++ b/sys/powerpc/conf/QORIQ64 @@ -14,7 +14,7 @@ machine powerpc powerpc64 include "dpaa/config.dpaa" makeoptions DEBUG=-g #Build kernel with gdb(1) debug symbols makeoptions WITH_CTF=1 -#makeoptions WERROR="-Werror -Wno-format -Wno-redundant-decls" +#makeoptions WERROR="-Werror -Wno-format" options FPU_EMU diff --git a/sys/powerpc/conf/dpaa/DPAA b/sys/powerpc/conf/dpaa/DPAA index 315461fb95ac..761dfbd85ba8 100644 --- a/sys/powerpc/conf/dpaa/DPAA +++ b/sys/powerpc/conf/dpaa/DPAA @@ -12,7 +12,7 @@ cpu BOOKE_E500 machine powerpc powerpc #makeoptions DEBUG=-g #Build kernel with gdb(1) debug symbols -#makeoptions WERROR="-Werror -Wno-format -Wno-redundant-decls" +#makeoptions WERROR="-Werror -Wno-format" makeoptions NO_MODULES=yes # Platform support