From nobody Thu Jun 29 08:20:44 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QsBGj0r6Jz4knvd; Thu, 29 Jun 2023 08:20:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QsBGh5ymMz3w16; Thu, 29 Jun 2023 08:20:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688026844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ewWEfFn2eid9Dq9seBvcIX8cOHBpSA3i8XWQD7GyqE0=; b=YvUQGHp+i7FlJoavRtS4pVijENuiw6xtaLoQsLSvzZyqjlxl7g3olmfPMz0tyPcRJNgDot WZ7QAoze5FeHTFBadrk5+Fu8aDTxWIExx/74U+ZCwpniuySxNW4oI8m/hBLeNzstC7eChT RM/vJCyBBoz+F3U49U08eS0Ee11ZjYVoViPp3c3k3U2JjcSSrgdnCDPqZdCVU5M3kga3ZJ 0Im4uEs0uYzvGLGpdzry4XqlVncqU5I0jIU7UJQxz5FW0QnshTMBr72gMrld/jXglBzhgL /FJTXwbP2qo7Y7EY/WiVt/WTgBvj1LjftdaPqT67Wzi0EJu/e0QIUKX966UWoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688026844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ewWEfFn2eid9Dq9seBvcIX8cOHBpSA3i8XWQD7GyqE0=; b=YbWFzbkKSNwdV97VnTHi8A1qfewqfvq32KtLdo3mQXwImqTtllzxvR1v6SBg+YFuZcEugo sSblCrjB3hjB5hHRCTMEvbArX4Sq6tox07Cz3GSDhrRxQiy85+5p3/UHlB+N8i/Nzl6AHF DNLqOfkvncvOAxTDUNEpJ4LBGrxFNQ+YzqXfqAbphzelZiz+Cqi8tzw/Y6T2N3z5uuHVCK S0ZsCpTJIot516H7Iz7UiWek+W6668ODySyydap+tmTw9aN8IVKYJh1gghKhMlZVkCrpWA D8oqRG6VZj2lBjhP3EljnNNNFg5HdoMa/SxvGnpWx3q8hxX7m9mAdKMe4odLow== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1688026844; a=rsa-sha256; cv=none; b=NeNCJQStzAZH/JCZP4u1Z9+MnD8nT4UDOryphkYB6jjxlFHoV1SvQuafv9GPtsc4rpu4E8 8/yB6khe+Jdwej4p7QM37ncYR89v4HSYDbXR4cu8hyi7vlZWY99aPoSqia6YHjkJqnZxPF Ew9A6bRixyQ7koZVNsBN+oxWEYphBumvjKeQfRpMc8TEWsipyG/RWBFBzfA3h2ZGdO8oKO ow1jiH+nztLEYz5aGvxYbsnvUTa1fSDvoSYGWssyW8DkDM5EPirPGokmIZzFKDL0mxXX9j uoBapWdLvdeZFEjI/LrsIuHSPnvWT/J7wjyqkGAnlYmz6jjVhXvyV8Ea1ggTcQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QsBGh54lQz17q8; Thu, 29 Jun 2023 08:20:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 35T8KiGU084668; Thu, 29 Jun 2023 08:20:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 35T8KiTM084667; Thu, 29 Jun 2023 08:20:44 GMT (envelope-from git) Date: Thu, 29 Jun 2023 08:20:44 GMT Message-Id: <202306290820.35T8KiTM084667@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dmitry Chagin Subject: git: d0117d06e9e3 - stable/13 - linux(4): Add a comment explaining registers at syscall entry point on amd64 List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dchagin X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: d0117d06e9e3588a902119b7a011c3613ef4545c Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by dchagin: URL: https://cgit.FreeBSD.org/src/commit/?id=d0117d06e9e3588a902119b7a011c3613ef4545c commit d0117d06e9e3588a902119b7a011c3613ef4545c Author: Dmitry Chagin AuthorDate: 2023-05-28 14:06:05 +0000 Commit: Dmitry Chagin CommitDate: 2023-06-29 08:16:01 +0000 linux(4): Add a comment explaining registers at syscall entry point on amd64 Differential Revision: https://reviews.freebsd.org/D40153 MFC after: 1 month (cherry picked from commit a463dd810851fdae5efcb8f8205d742ebf221bc8) --- sys/amd64/linux/linux_sysvec.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/sys/amd64/linux/linux_sysvec.c b/sys/amd64/linux/linux_sysvec.c index f43e7d3a02bc..3681dc881485 100644 --- a/sys/amd64/linux/linux_sysvec.c +++ b/sys/amd64/linux/linux_sysvec.c @@ -124,6 +124,23 @@ LINUX_VDSO_SYM_INTPTR(kern_timekeep_base); LINUX_VDSO_SYM_INTPTR(kern_tsc_selector); LINUX_VDSO_SYM_INTPTR(kern_cpu_selector); +/* + * According to the Intel x86 ISA 64-bit syscall + * saves %rip to %rcx and rflags to %r11. Registers on syscall entry: + * %rax system call number + * %rcx return address + * %r11 saved rflags + * %rdi arg1 + * %rsi arg2 + * %rdx arg3 + * %r10 arg4 + * %r8 arg5 + * %r9 arg6 + * + * Then FreeBSD fast_syscall() move registers: + * %rcx -> trapframe.tf_rip + * %r10 -> trapframe.tf_rcx + */ static int linux_fetch_syscall_args(struct thread *td) {