From nobody Fri Jun 02 19:36:56 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QXtYN6SPxz4YdXK; Fri, 2 Jun 2023 19:36:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QXtYN5jWkz44T1; Fri, 2 Jun 2023 19:36:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685734616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=D6XwzJKa05Kd/g/4m9tVmqpbzC6x3Duhzbj+u7SL1AY=; b=HL9XXUdmeUq91Uhd3ozR4Fm2pWBJqzgs/pVariG97K7ox2tvkcNntwyIDHTcyuwxF53Dy2 01QY55sFshxn+gIMWoDSDukWUjatFn0VHUIQa3+Qim/2+m9uEkMV6drej9bGqG+H+YF4GR 54TVADlBsA83gn5EYBP+re82PUOMxvy91u3MByto7JSlif3pN/PCYOme8FpPFjatHXyEVm XmNmaoY9DbSAHPMpSCyqvlkCluzSpzIEbLkGReMavqMSFhBKGl+HqAVQWrc6DqxeaGBvqy E4gKPiw8LD2JCF1bX4ImaeqBHAwwGn22NGTiWygnLAL5ekQTJUdkWTB4IfK57A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685734616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=D6XwzJKa05Kd/g/4m9tVmqpbzC6x3Duhzbj+u7SL1AY=; b=wfT402ork8wtjYGm0J53Kk/0SoFx50/x8H7jpZTEAKJitOmYzBD1SNAZib8yemiblicscd 8qu7+AvjXmlJX4brSvTXoo6ETtwtzvE0wo8kBXEPhvDtftOT0BkK/2hetdex2MHYdZa7uC WAjFXv79rqcsw80o0ywW15ErXIpgUnewtB9K9nisTxRU3buOrRQaM58Chp6091TwLypYXb KwDHEs1WbpqEA5R/404Wa3UpjwLXme2hYMgONGwOmaKAgj5GLn4KyL+r0vVAh0RHPIkW3L uRUnS6K1wOUQQhF08yhblZnGfxZR62bllXoMLvSeGrJWebZBSL6o/42E1qGBRw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685734616; a=rsa-sha256; cv=none; b=Rr84dB3B8slGVcMe2R7uKjuc8f8YeEI/IKjZvw3+BWGzBiW5bKKildRSmufb/AQi3U+6lu noHa+YoyAEUAaOvXFaa+XnIJK4cIlB7DHDchsSu2WAjLOAxfxLPJStAniMByrlWPUcQY3u hvD1atikbQQHj5Ps7lZzc88hb25YZbKv7goUict4tYY0spH/fegKN5b7a4RuDvskiMaZcg 6Ss+v9W6nsVgxZffhz612BxihfMS1cOZ42KxnatzyfIrF5VYuuN+dyWF25js72qc/ZXKJR ezk8zZBfg6vWpeRH+fsA/+L/1UedSiIaK4e+Ew6aQH6G6aIYolYaN8UndoA4/Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QXtYN4nh0z1BJQ; Fri, 2 Jun 2023 19:36:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 352JauQN090547; Fri, 2 Jun 2023 19:36:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 352JauvH090546; Fri, 2 Jun 2023 19:36:56 GMT (envelope-from git) Date: Fri, 2 Jun 2023 19:36:56 GMT Message-Id: <202306021936.352JauvH090546@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Eric Joyner Subject: git: 197106cf41df - stable/12 - ixgbe: Change if condition for RSS and rxcsum List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: erj X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: 197106cf41dff164a16d09cf84fe10321ca1ebdb Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by erj: URL: https://cgit.FreeBSD.org/src/commit/?id=197106cf41dff164a16d09cf84fe10321ca1ebdb commit 197106cf41dff164a16d09cf84fe10321ca1ebdb Author: Przemyslaw Lewandowski AuthorDate: 2023-05-24 23:24:54 +0000 Commit: Eric Joyner CommitDate: 2023-06-02 19:35:05 +0000 ixgbe: Change if condition for RSS and rxcsum This patch fixes TCP connection hangs for 1 rxq and 1 txq without rxcsum enabled. Documentation for 10G cards and other drivers suggest enabling rxcsum for RSS and disabling otherwise. When PCSD bit is not set then fragment checksum and IP identification are reported in the rx descriptor. When PCSD bit is set then RSS hash value is reported in the rx descriptor. RSS and RX IPP checksum are mutually exclusive. Signed-off-by: Eric Joyner PR: 268910 Reviewed by: erj@ Tested by: jeffrey.e.pieper@intel.com Sponsored by: Intel Corporation Differential Revision: https://reviews.freebsd.org/D38621 (cherry picked from commit 156424fce98a0240c702da0a918b027d1979bfdb) --- sys/dev/ixgbe/if_ix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 47f3918fd8ee..e9c79681cd03 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -744,7 +744,7 @@ ixgbe_initialize_receive_units(if_ctx_t ctx) ixgbe_initialize_rss_mapping(sc); - if (sc->num_rx_queues > 1) { + if (sc->feat_en & IXGBE_FEATURE_RSS) { /* RSS and RX IPP Checksum are mutually exclusive */ rxcsum |= IXGBE_RXCSUM_PCSD; }