From nobody Fri Jun 02 19:30:13 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QXtPd5MqMz4Yc57; Fri, 2 Jun 2023 19:30:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QXtPd3p0Zz42W2; Fri, 2 Jun 2023 19:30:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685734213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3Ioa9GqHJcY3kdZIcHQdxfKNb5TOf7jz2vE6A+GlnAM=; b=yCC4ptJXInMHQKGNU7PA2MDMnXBmllh4NtrWGwgUOqomjUOvLpOxmTzivBremWWqWPKwdN +r49CtrbPnvObTKOhx4k9lTFs7rn75uGKDyJ61i10sWWUDyovAVSg6lWGxSX4LNdQQc8GU ClahpZeAn87jyE80ldXnvyn117rAX2sTgR95vy3AOp/y3F4ENgMea52kDv3Gn3vP7Gs+/S h+ro2PsYcCpWlYVXUAfELLf76x9fEEOUljVTE/xuGuFVNfFZKXJayvhlqoTtyIDVWXtdhc yU6xRYh1UPkq2r+4aQWEhqMEAb8J+BF2US//mSf54enDYQ3OUs8Gsn2ImJcBiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685734213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3Ioa9GqHJcY3kdZIcHQdxfKNb5TOf7jz2vE6A+GlnAM=; b=TB3plBnHvmObB8+G8TXYrfihpnN+oMeaZcMiJWwVrBjf8AVXEEvGcpjeKShEtiRcDl3Jpk 7QScTTu/Guvd9JpuVXIeLnZd9hZqO+ElYvIk4+l6OwhNGGUBk6BS/tcJV3JHxD8r/+yWaQ 7FyfIveF1aAs0fCyq09lyIkY3NtlGVWooG91SNsECBqu0WNcq4E0xwQYuPW+b2JG5CGU2f zpkXuru3rSmuZ39LnmD7Y15ohcKJgATzdu3e+DOEU91UYfZJjuTl6NKJ2PXOeabCqmyg00 sSr9XOB7Nps3U5I5k4CdIXz8nLC2PcybiIRK2CHhxMRpf1aKDV2Ja9VedbWBew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685734213; a=rsa-sha256; cv=none; b=oT8JnEL3eH8aCfcUgQJZNz9bf1AYtoq4hM7AvOFEZ3r5pvvn+SuJ4g0JJVxCNa+oQfAMUg PxSxiUsaX+bDmQwtvwRzGIXLNcJtRF9T5gPIqRitWcNV4hErPIXZyoIOQFXm8iA/baII/J ybEZiFwjS/lFW56TZilon0rYUa2dQ/zQ+tZOdHbpZ00gFN7v7LioYI1A1GQD7wX/uFiOuK NYhm+gSwgKRaAswpgVtPX5sKHhlFDoVW/kAQl9wkd741J82nYNQH/dtEhF8fQ3rSKLswGR EvQkn//ulS8iNdP7et2lci3WtvoauhT1+0PPGUB14uniMCfZwgvrZ4goa14BYg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QXtPd2vtCz19pn; Fri, 2 Jun 2023 19:30:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 352JUDak080651; Fri, 2 Jun 2023 19:30:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 352JUDFH080644; Fri, 2 Jun 2023 19:30:13 GMT (envelope-from git) Date: Fri, 2 Jun 2023 19:30:13 GMT Message-Id: <202306021930.352JUDFH080644@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Eric Joyner Subject: git: 95aced446a8c - stable/13 - ixgbe: Change if condition for RSS and rxcsum List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: erj X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 95aced446a8c6ada94a5a9dead6e2c68ce48ecb3 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by erj: URL: https://cgit.FreeBSD.org/src/commit/?id=95aced446a8c6ada94a5a9dead6e2c68ce48ecb3 commit 95aced446a8c6ada94a5a9dead6e2c68ce48ecb3 Author: Przemyslaw Lewandowski AuthorDate: 2023-05-24 23:24:54 +0000 Commit: Eric Joyner CommitDate: 2023-06-02 19:27:45 +0000 ixgbe: Change if condition for RSS and rxcsum This patch fixes TCP connection hangs for 1 rxq and 1 txq without rxcsum enabled. Documentation for 10G cards and other drivers suggest enabling rxcsum for RSS and disabling otherwise. When PCSD bit is not set then fragment checksum and IP identification are reported in the rx descriptor. When PCSD bit is set then RSS hash value is reported in the rx descriptor. RSS and RX IPP checksum are mutually exclusive. Signed-off-by: Eric Joyner PR: 268910 Reviewed by: erj@ Tested by: jeffrey.e.pieper@intel.com Sponsored by: Intel Corporation Differential Revision: https://reviews.freebsd.org/D38621 (cherry picked from commit 156424fce98a0240c702da0a918b027d1979bfdb) --- sys/dev/ixgbe/if_ix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index c985e89b4cca..54bc16e73763 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -755,7 +755,7 @@ ixgbe_initialize_receive_units(if_ctx_t ctx) ixgbe_initialize_rss_mapping(sc); - if (sc->num_rx_queues > 1) { + if (sc->feat_en & IXGBE_FEATURE_RSS) { /* RSS and RX IPP Checksum are mutually exclusive */ rxcsum |= IXGBE_RXCSUM_PCSD; }