From nobody Tue Jan 31 13:18:07 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P5lwb5vGzz3cV5X; Tue, 31 Jan 2023 13:18:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P5lwb5VK0z3h88; Tue, 31 Jan 2023 13:18:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675171087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UndPfoWcoa6RSlO3MBfee+tCpFU6xnhI9kzPMKUCyzA=; b=rj7/YsTZijj3TBALWbXBPGF5nQAHIyuTVftzc7OWHDD/79tHBImnpfUjpGZ1Ie0RAbJu9x FfhQUsRltP2vSP78wLwyDnK00M1s82q5gFh5TzaFHMZYsMVWGgqn64wvLq6PWRo9NYsHIi e3zMCiehuQagxhAB2aS1obVPNpWh+r9nRpXaKzf+hAf45IRlD1rtLdhLinSBxitgYxGHpm IlJOJk2qWJ4a+/dv/2kQlWca5Lh9YbbSPG/lzxdF8UP0zZFdlc0fu0bbftmlZRKRKmCApX 0UjElnCsJNHxV1I+Yqddd/pokfpO49LYqizqdZMCh8Thy/1NZD+EO9n7dI4HqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675171087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UndPfoWcoa6RSlO3MBfee+tCpFU6xnhI9kzPMKUCyzA=; b=GcambEKo1h0Ii31Vp+djyPc8rePRmEPXRDH+UyZveekcHQu8c64mqg4fJTEcjDbI407t3N JARvre8z3YhCiQQHdZpOWNyOOTIx8mmRJsLXLIBYg9wMxeTNqXmtrQqKiHAHWbhsY/FLaz OxTiHUsazqg4l/hLQLQAhqkFKnOcjmB6gPuNs2MkJcD8SPJ2mn4s+YLduk+9tVpOcCkPgF YxI2VOadd3Jc3I6pR1t6OJQU9HGsgrHxwtl5M7K9HKRAve5gMEDcOMYhFU1H0Fkmw4/WU6 kwPa1Tsif9r3UYJVD8lDeB5sf9iQ8ZXdMxwVEgKXSoi2HSH/AtQ7cRh4e7HrsA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675171087; a=rsa-sha256; cv=none; b=x1OT/MOW9FgzFVn+E/L2oEVFlzGx5ayrIZGZaFMUamv4hATsnU+VgbdNrkleo6BSmtXUch j07l4hzyeHLFwxGgR5mGbtGcu41+SDNNk7EkRyq7hlVtRme/pPKKJtoVh7Uay585ZPo8em BW+npYPdH9LIbl5bmPvdtaTKqR2tTBSF36QY3GgPJsuH3gOX7wjyiGAzvPI2qZ9yXV7vX9 HQuIP+8TQdnRGhpwGUNX4o5hqBBksLhD8rEpVCamtmu9Vp7mn5CCmX3YSmI6BGEriJo8im +cXs84oV9kl0UVLof5EqPGB2DHgAUVLvdZu4exy9UdqFvZoktLxzeVFnHqm9cw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P5lwb4cRRzpt3; Tue, 31 Jan 2023 13:18:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30VDI75Z041020; Tue, 31 Jan 2023 13:18:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30VDI7OT041019; Tue, 31 Jan 2023 13:18:07 GMT (envelope-from git) Date: Tue, 31 Jan 2023 13:18:07 GMT Message-Id: <202301311318.30VDI7OT041019@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Marcin Wojtas Subject: git: 113c730edcca - stable/12 - ena: Re-Enable per-packet missing tx completion print List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mw X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: 113c730edcca8244bd14e6c23916dcdfda5da944 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by mw: URL: https://cgit.FreeBSD.org/src/commit/?id=113c730edcca8244bd14e6c23916dcdfda5da944 commit 113c730edcca8244bd14e6c23916dcdfda5da944 Author: Arthur Kiyanovski AuthorDate: 2022-12-19 13:56:44 +0000 Commit: Marcin Wojtas CommitDate: 2023-01-31 12:46:50 +0000 ena: Re-Enable per-packet missing tx completion print Commit [1] first added the ena_tx_buffer.print_once member, so that a message about a missing tx completion is printed only once per packet (and not every second when the watchdog runs). In this commit print_once is initialized to true, and is set back to false after detecting a missing tx completion and printing a warning about it to dmesg. Commit [2] incorrectly reverses the values assigned to print_once. The variable is initialized to be true but is checked to be false when a missing tx completion is detected. This is never true, and therefore the warning print for each missing tx completion is never printed since this commit. Commit [3] added time passed since last TX cleanup to the missing tx completions per-packet print. However, due to the issue in commit [2], this time is never printed. This commit reverses back the values assigned to ena_tx_buffer.print_once erroneously by commit [2], bringing back to life the missing tx completion per-packet print. Also add a space after "." in the missing tx completion print. [1] - 9b8d05b8ac78 ("Add support for Amazon Elastic Network Adapter (ENA) NIC") [2] - 74dba3ad7851 ("Split function checking for missing TX completion in ENA driver") [3] - d8aba82b5ca7 ("ena: Store ticks of last Tx cleanup") Fixes: 74dba3ad7851 ("Split function checking for missing TX completion in ENA driver") Fixes: d8aba82b5ca7 ("ena: Store ticks of last Tx cleanup") MFC after: 2 weeks Sponsored by: Amazon, Inc. (cherry picked from commit f01b2cd98e93ef5ac3698b97bbaa45ac9c50fe5d) --- sys/dev/ena/ena.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/ena/ena.c b/sys/dev/ena/ena.c index a93e55e36bde..fe9c411f125a 100644 --- a/sys/dev/ena/ena.c +++ b/sys/dev/ena/ena.c @@ -3023,19 +3023,19 @@ check_missing_comp_in_tx_queue(struct ena_adapter *adapter, /* Check again if packet is still waiting */ if (unlikely(time_offset > adapter->missing_tx_timeout)) { - if (!tx_buf->print_once) { + if (tx_buf->print_once) { time_since_last_cleanup = TICKS_2_USEC(ticks - tx_ring->tx_last_cleanup_ticks); missing_tx_comp_to = sbttoms( adapter->missing_tx_timeout); ena_log(pdev, WARN, - "Found a Tx that wasn't completed on time, qid %d, index %d." + "Found a Tx that wasn't completed on time, qid %d, index %d. " "%d usecs have passed since last cleanup. Missing Tx timeout value %d msecs.\n", tx_ring->qid, i, time_since_last_cleanup, missing_tx_comp_to); } - tx_buf->print_once = true; + tx_buf->print_once = false; missed_tx++; } }