From nobody Sat Jan 28 01:39:21 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P3cYj6wVBz3bpvm; Sat, 28 Jan 2023 01:39:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P3cYj6QHgz3nGM; Sat, 28 Jan 2023 01:39:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674869961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DRlBAvRRrKf9vbjVXgFqRmJL3lzpmdXJFLTbU2nK03c=; b=kbkn1fr+U1SdARYbVoOHHbRFW+oPbnz5qPsDJjF7D1DSg2qpdrOycBp/Nd2KCH7pDpUCDG YZGnM1SDRIKQ+LtMcXrqHLUwUgkXbxZYd90NYFwmY0emz3ddKXjrP/tBEPnI/QmI/2XouB 5XZrQ3JoU0xz53OkEivbnJBQ+LvqevnvL8U/ZF9zC1rN15HL9FlwD6YxH0jCZuqnMSxPsx ROKpfRjNd4AOOJe9Ez9U6Tt3LOYDC894CNXLm7DYyLWCMAue8TosUmsLdZrK0K8H8I8Yru yPxMWjiMOeSH0VpVxOVCU0COjjCjR1ScRtPUqoVB2o5MZ7EEBZc6CORi0ocb5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674869961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DRlBAvRRrKf9vbjVXgFqRmJL3lzpmdXJFLTbU2nK03c=; b=uAnPPAc2s1ga9QEiauE26EAddpr4kx9VSXPrnGSYJfXlowwdV3I3Xn0U3/+W/OrgayikjC Zh6wUbUJKvrLmUlNYzi8IxvNHxWrSAg3MzkJsGyoaO35WQRXvC4p+Del0jBaGeHnxr6f1A O3xk0x7hmbh8ZswKo/2gEvvVkd8yGk6GALiY+/gmSmk2ZRzyetktakC7PH8gY/VImb51Jr a7YZwLfvxbPgoPNumSTWsLJWvEf98/lnowEW2T4XD6pfj0TVSaKQmd3PhffGShbefEBM0b 6SrIet2DDjSkgYPqHtN0wK6ppURUILN7e2g5WDZD/Te1bw/omd+s9sjfGaeN2Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674869961; a=rsa-sha256; cv=none; b=Ezl58u9p3EU/RmheaWsTgXv3/LgQAn4AkKMlfs8Vu9IwkZ/hVmGAqihj6FeKIUm8pm87HS GHDUms6a5M8fnRZQKig0eOC+Pph58taiUHFn7xVHzMasSZsLXpB+2bNEn/ML8qi6Rhf7ho DLsTmB3QFWZiT/t8v/Zn8UHFrRztIdUrvM1Rp645akcCrx2wgRajhd9HVvjJsr6c558/9+ tKUTUrgFUZ2GYbGnqiIahJVpUYGe93Ar7u1UfEjxojk/rOCd7YArB2TePSPT7wksCYyU6V H9WOr6gtG1OvXyd+VXHWB0W8vAD9zOcf0TnnaxGD2FvExTgPBnDRKD2NR6ZWGQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P3cYj5BcYzWYg; Sat, 28 Jan 2023 01:39:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30S1dLe0056050; Sat, 28 Jan 2023 01:39:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30S1dLuW056045; Sat, 28 Jan 2023 01:39:21 GMT (envelope-from git) Date: Sat, 28 Jan 2023 01:39:21 GMT Message-Id: <202301280139.30S1dLuW056045@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kristof Provost Subject: git: 2cfb60783900 - stable/13 - pf tests: test fast port re-use with syncookies List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 2cfb60783900b625798c5ceb52b9aa93c5c412ae Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=2cfb60783900b625798c5ceb52b9aa93c5c412ae commit 2cfb60783900b625798c5ceb52b9aa93c5c412ae Author: Kristof Provost AuthorDate: 2022-12-31 18:23:15 +0000 Commit: Kristof Provost CommitDate: 2023-01-28 01:34:38 +0000 pf tests: test fast port re-use with syncookies When a src/dst ip/port tuple is re-used before the pf state fully expires we clean up the state and create a new one, unless syncookies are enabled. Test this, by running two back-to-back nc sessions, with a fixed source port. Move the interface and IP to a different (vnet) jail, to trick the network stack into letting us do this. MFC after: 2 weeks Event: Aberdeen hackathon 2022 Differential Revision: https://reviews.freebsd.org/D36886 (cherry picked from commit dc698b2cd59ebc08b05a261dbba8ee5707450d28) --- tests/sys/netpfil/pf/syncookie.sh | 57 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) diff --git a/tests/sys/netpfil/pf/syncookie.sh b/tests/sys/netpfil/pf/syncookie.sh index d85beac1a4d1..dbb6407e9c38 100644 --- a/tests/sys/netpfil/pf/syncookie.sh +++ b/tests/sys/netpfil/pf/syncookie.sh @@ -217,10 +217,67 @@ adaptive_cleanup() pft_cleanup } +atf_test_case "port_reuse" "cleanup" +port_reuse_head() +{ + atf_set descr 'Test rapid port re-use' + atf_set require.user root +} + +port_reuse_body() +{ + pft_init + + epair=$(vnet_mkepair) + + vnet_mkjail alcatraz ${epair}b + vnet_mkjail singsing + jexec alcatraz ifconfig ${epair}b 192.0.2.1/24 up + jexec alcatraz /usr/sbin/inetd -p ${HOME}/inetd-alcatraz.pid \ + $(atf_get_srcdir)/echo_inetd.conf + + ifconfig ${epair}a 192.0.2.2/24 up + + jexec alcatraz pfctl -e + jexec alcatraz pfctl -x loud + pft_set_rules alcatraz \ + "set syncookies always" \ + "pass in" \ + "pass out" + + # Sanity check + atf_check -s exit:0 -o ignore ping -c 1 192.0.2.1 + + reply=$(echo foo | nc -p 1234 -N -w 5 192.0.2.1 7) + if [ "${reply}" != "foo" ]; + then + atf_fail "Failed to connect to syncookie protected echo daemon" + fi + + # We can't re-use the source IP/port combo quickly enough, so we're + # going to play a really dirty trick, and move our interface to a new + # jail, and do it from there. + ifconfig ${epair}a vnet singsing + jexec singsing ifconfig ${epair}a 192.0.2.2/24 up + atf_check -s exit:0 -o ignore jexec singsing ping -c 1 192.0.2.1 + + reply=$(echo bar | jexec singsing nc -p 1234 -N -w 5 192.0.2.1 7) + if [ "${reply}" != "bar" ]; + then + atf_fail "Failed to connect to syncookie protected echo daemon (2)" + fi +} + +port_reuse_cleanup() +{ + pft_cleanup +} + atf_init_test_cases() { atf_add_test_case "basic" atf_add_test_case "forward" atf_add_test_case "nostate" atf_add_test_case "adaptive" + atf_add_test_case "port_reuse" }