From nobody Fri Jan 27 17:11:59 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P3PJJ0XvHz3bGKt; Fri, 27 Jan 2023 17:12:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P3PJJ00Tzz3rYr; Fri, 27 Jan 2023 17:12:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674839520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bojPRVf0MMALBaGUDQEPhStbys7sNJNbCmjP2k2IxPg=; b=kIGCBauoL/e7hiV7Gh/JzyLSmgh/5JKc02Q+Njf1dNx/CEicpva7ugVdjNg4Yqt5uEq4F1 7mfk0CHXadO/C5GNu5jQi/G5+WQ9ftchWdzNnLJuNzgJ51WYHB5BYHP3BUhx9U35p9qlI2 5znrYfzFdiTgPi3ZbyX9GFytdwCSW0P3fxo+wHz2UjtoKvUDrbdOsyt80UoTY02A/dJeAb A3WBO1nd7KpK5BWjs7HEsj6c3sjR684eO+q5XlXaN2q8X/3dCU72Tb1qqwdfcIbi9ttUGT ES9bb1Yf7myFUtuKaJXWjTO0RN51ihm3i0fXVsgiBEW7Ln8OI59KjnFU5fLGFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674839520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bojPRVf0MMALBaGUDQEPhStbys7sNJNbCmjP2k2IxPg=; b=EqzBFFqs2bHswyem5A5AkvxmmkIRIs3fZxOznzGNZpptQjIeNvSM7LFog8NUYQPy2CZIMX 4s7GnYc6zCQTFL/XBbMAIjE4kxXMO4QwMO7vBdX8TVkwJpyyema0KFari75BqZKk+7SAqF ENPYsc7jRYkwLvW07aYpWu7eQvPmUncTd6doXYF010KiiN2zMKsIobGAezkSxEZRlkeUPe 13jeW4ewsW7nGI63zzgab9qP9UCg3u2ohz04VsbjPjoozDQ2AolShtVdbbVnm5bi7oq347 oQAJPWM4poaEbyAUHfjMEdRHIVVSbEVWo94uhPMHjICoRzej25C3FRHMAZw35Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674839520; a=rsa-sha256; cv=none; b=EDiTHunekWhE6XTGf2fL1iiHAs/Ru2KXHup1m3ZtZT9+1ZA7OWJUmnX6FqtcZmBnTLDbBm h7fzyu94HPSpgdiPa2lDipQ2vGnLJWhZ5/IMYx6Kyy/rkvs+LFZ0kJ8H3GjqDReTGFr7nJ SZ9PHr7gGG2X7+/41sL6vmJsm2JVHIo7lV7ErWMhKkLJingbK3lZdRgiSYUWQXJrNgHOOo hV9yoikiZ+gx2u/NQbUHN/TuHHcWCURaLOG4/JlYyvTxkFzGRInjuS2L8LaqUWimqiIlKf MNHH8hII1HqvYxZ5JhIdppBeIUaAnhqwuMu62iRfn+jdKmRw0plo6XXy7PsSWw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P3PJH6930zHdC; Fri, 27 Jan 2023 17:11:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30RHBxAW043546; Fri, 27 Jan 2023 17:11:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30RHBx0b043545; Fri, 27 Jan 2023 17:11:59 GMT (envelope-from git) Date: Fri, 27 Jan 2023 17:11:59 GMT Message-Id: <202301271711.30RHBx0b043545@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Alan Somers Subject: git: 1961075a6972 - stable/13 - Allow any user to read the NFS stats, for example with nfsstat(1). List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 1961075a69726327c14b62e59b45a1de388e688e Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=1961075a69726327c14b62e59b45a1de388e688e commit 1961075a69726327c14b62e59b45a1de388e688e Author: Alan Somers AuthorDate: 2022-12-01 21:08:01 +0000 Commit: Alan Somers CommitDate: 2023-01-27 17:11:45 +0000 Allow any user to read the NFS stats, for example with nfsstat(1). This was originally allowed by 3cea29603d3 (2011). But it got broken by 693957f8861 (2016) and apparently nobody noticed. Sponsored by: Axcient Reviewed by: rmacklem, ken Differential Revision: https://reviews.freebsd.org/D37589 (cherry picked from commit d2ce00e9a6176014bbeb792dd9959ef1e60d787e) --- sys/nfs/nfs_nfssvc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/nfs/nfs_nfssvc.c b/sys/nfs/nfs_nfssvc.c index a16ff8b36448..bf22817d2b25 100644 --- a/sys/nfs/nfs_nfssvc.c +++ b/sys/nfs/nfs_nfssvc.c @@ -85,7 +85,7 @@ sys_nfssvc(struct thread *td, struct nfssvc_args *uap) AUDIT_ARG_CMD(uap->flag); /* Allow anyone to get the stats. */ - if ((uap->flag & ~NFSSVC_GETSTATS) != 0) { + if ((uap->flag & ~(NFSSVC_GETSTATS | NFSSVC_NEWSTRUCT)) != 0) { error = priv_check(td, PRIV_NFS_DAEMON); if (error != 0) return (error);