From nobody Thu Jan 26 19:25:48 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P2rK85ntrz3bTgs; Thu, 26 Jan 2023 19:25:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P2rK851TZz4HnV; Thu, 26 Jan 2023 19:25:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674761148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=d3FxUWnT82VU95vrXh+a/OE54+76HH89Cf8uP4wwsX8=; b=yy6KRlkCZa6TC/3ViiF1SYbOrfCE5m1u0ZW0/S+KRvW9PRikez7Euht+1Aq1Pj/mV7KrFu 87NSo8CV2UmKxUnJT3Oev8uur2z3UcKZAKYE5oeJj7vUzLLVTqz9kQ0j7O1/mZrbRIR8o0 UhTxBs8NQ4Piued/3rzsTQ1MBQdFjO7tEZJqVH7O2xBOOSpyoVTpt22HKefxJeHfYd6xL1 /4gbEij+E9vUdWYqAow8IZvrFP1x54CV5DvPGjS9EsxoEIJrpz2s2k7vDLl3yp/Iz0Pgeq 4EEcWn3kwh0qzPaotHKNKy87o7lOVcLeZitXoAebqyl8vPwi6L0p66LnY9qb8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674761148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=d3FxUWnT82VU95vrXh+a/OE54+76HH89Cf8uP4wwsX8=; b=Ai58ZdHdhP2KdOSnfr8jkj6t/Uc2jrfm592r4/4Zy3lRA52CV8y0uhhzXq6dpqxu4CwW3T ITBVxazaiPi1D6ZdeUWQG9RTS4FvLvSElWodlK6MaYV/O66QaypwgWum0p6fyrxvPgCPXx QyOW0sKL6+zKHNKqXJz5vbRi0PwSAamqPMv1yxQoYf+hw/uYPjl+lV0DJBFdxO2ai1XjaC 4lMTSp1dRHiiOMItFxZ8MBlgdpotxjrERRUBnAecyeonUWkc+E161LluTGqkBVwV2GEU+s AxbauPlTAllIJhKGzvrplPsWDJVBtZYWcMrbULeocti9paXGqONt7CpuKj/7jQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674761148; a=rsa-sha256; cv=none; b=OD2yrQFeJfOVHRStymQZYbIAsGWP8D1O7NfYcI2bEbw/3JMsMabtuWSZX8BnXYc1jwFEpu qMfXhIEHBIaH2xdeprE37jW0503B/vg6ZtferAluTM1snj2r16ZpMlyjagK4/7xLr2g5WG 5G9GDIgzYw3qJYO46dmRHJ950TnymHDOoNyNFCXDSasy3Rjhl8hFIdy2t8Mc5T2qD95thP R4+ugW6RNmwKZ3lSqc58phZp5pCQDSCsc11180pRkZxzZBe+XGtD0MO+zk7AHiVae/0NT+ 5Sthqfb91CjZ3/7z1N/TNh4XU7wOy0VEBjIGMmwhhKvBBfpy/fdWv6/mLwqqWA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P2rK83yqJzh8K; Thu, 26 Jan 2023 19:25:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30QJPmJ5077925; Thu, 26 Jan 2023 19:25:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30QJPmiO077924; Thu, 26 Jan 2023 19:25:48 GMT (envelope-from git) Date: Thu, 26 Jan 2023 19:25:48 GMT Message-Id: <202301261925.30QJPmiO077924@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 3737a0cdcb42 - stable/13 - bhyve: Fix getaddrinfo() error handling List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 3737a0cdcb42f4495438997d4ff1655273c3016b Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=3737a0cdcb42f4495438997d4ff1655273c3016b commit 3737a0cdcb42f4495438997d4ff1655273c3016b Author: Mark Johnston AuthorDate: 2022-02-08 17:34:03 +0000 Commit: John Baldwin CommitDate: 2023-01-26 19:21:32 +0000 bhyve: Fix getaddrinfo() error handling - Use errx() since errno will not be set. - Print the message returned by gai_strerror(). MFC after: 1 week Sponsored by: The FreeBSD Foundation (cherry picked from commit 927aa5fefd4c69e72d44189a04fadf80e42d0ad8) --- usr.sbin/bhyve/gdb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/usr.sbin/bhyve/gdb.c b/usr.sbin/bhyve/gdb.c index 94167053629e..81f132e17350 100644 --- a/usr.sbin/bhyve/gdb.c +++ b/usr.sbin/bhyve/gdb.c @@ -1858,8 +1858,9 @@ init_gdb(struct vmctx *_ctx) hints.ai_socktype = SOCK_STREAM; hints.ai_flags = AI_NUMERICSERV | AI_PASSIVE; - if (getaddrinfo(saddr, sport, &hints, &gdbaddr) != 0) - err(1, "gdb address resolve"); + error = getaddrinfo(saddr, sport, &hints, &gdbaddr); + if (error != 0) + errx(1, "gdb address resolution: %s", gai_strerror(error)); ctx = _ctx; s = socket(gdbaddr->ai_family, gdbaddr->ai_socktype, 0);