From nobody Thu Jan 26 03:01:49 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P2QTp0vr9z3b8Gt; Thu, 26 Jan 2023 03:01:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P2QTp0Fk6z3Gqn; Thu, 26 Jan 2023 03:01:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674702110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BoYEmT4KMInZH4oQbbPbA4NszoLehJUv/eDice4C9yM=; b=ILtSkigcbtPOdoDGNkzVrD/16abjmbduBYZ6LDkBHoXfRPDHpL1gW0xOMO+2KoUEA5bqPy 5VgsvKefAwsUI2lIhauAD43sHKRy8tYAXh+iKPaoMSi6KmLOk1LXxBioyOOlxvDs9GELX8 9Gu3F+NbQKuo9YZH7Gx7YX3Fp26x1FScn1bgmSNKPUqDnLhLCdMYgdEdPqvT0uBBGvGQgm 2sBqkbK+ii5sxf7OxbzKHc37CJKTDQrDJzWg7B/ZXb65kuv8dob6efsVxg+bwvbPti2WXf vHFdQXaVwExSTEaELaJyRsGiXJRlIf2osndDikt/FtibQf+KvF4w0bj4e6vHtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674702110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BoYEmT4KMInZH4oQbbPbA4NszoLehJUv/eDice4C9yM=; b=Wp62t8sO3bdOXiZJ5NeRUsxYwn3kchHQrLNIWW3a+tYAjYJZTtrqqj085eRvylJuI4Zccs x+FtHSzulZ9TnQAt3kCxEs+WPmgmCeHuYL8E6/sDWogpGsiIoGVVjuRVam2VzvWNWC83kE YGVp2mXoc1AVOXgjfvv4AzIA+bt5L/R8yyDqDWwzD5WwcuggqcR3iJwayKElm9+yHiQuyN E8zLwbpYj/i+eihsHPcqzeBEAHbpt57W6z832gR3XhCdRbxz7/eNL/ha7FGQ6Zv1ifAeyF sjz25NpW9ZeKQPGZJUWngcDTi63Wlll8vTB0P1inko+oKuT5htkQTSkB0Yb6Ug== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674702110; a=rsa-sha256; cv=none; b=NV8MUGj5r6VsT6n+rqv6nXXviP+j4/QCaCVykpOt1WHBtlIOpphcXTKV7CVclHVQxVowMk suU/B/3mjWgz61xui38QQJrVN+2Cd/S0r6Bv/StSQdMHMRnBZRXfiWPO4kDe+rMNz1T3Jr WqrxRAKatEBEeDulOsDPYfE0QnmPmhDlD00yjPrK349ER7+g+aG9wdxmw6vVpmfbH32Hba 6gZv7AeWZl/Hgqlhe8fDeDU1f34EsE2J/I+1zOZZwVsWddq8UmOeZbDtSWIW6TCpdE6+HG aby5dgMrz8d+cwdhrH6GaNcEIL6VpO3Nh/+EmB6AtrMg60yg1ci7WmYiFo3FjQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P2QTn6SP5zF4v; Thu, 26 Jan 2023 03:01:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30Q31n7L078857; Thu, 26 Jan 2023 03:01:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30Q31nDi078856; Thu, 26 Jan 2023 03:01:49 GMT (envelope-from git) Date: Thu, 26 Jan 2023 03:01:49 GMT Message-Id: <202301260301.30Q31nDi078856@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Rick Macklem Subject: git: 1134f0d9a47a - stable/13 - nfscl: Improve NFSv4 error message for NFSERR_WRONGSEC List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 1134f0d9a47acd65bc343a58a2eda274dc6a32b5 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=1134f0d9a47acd65bc343a58a2eda274dc6a32b5 commit 1134f0d9a47acd65bc343a58a2eda274dc6a32b5 Author: Rick Macklem AuthorDate: 2023-01-11 21:28:44 +0000 Commit: Rick Macklem CommitDate: 2023-01-26 03:00:52 +0000 nfscl: Improve NFSv4 error message for NFSERR_WRONGSEC The usual reason for an NFSv4 server replying NFSERR_WRONGSEC to an operation is that a Kerberos credential is required. This patch replaces a cryptic "err=10016" with a message suggesting that a Kerberos TGT is probably needed. (cherry picked from commit 39633fc1731c3feeed36aa452bbdfb7968a86383) --- sys/fs/nfsclient/nfs_clport.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/fs/nfsclient/nfs_clport.c b/sys/fs/nfsclient/nfs_clport.c index d530b848431e..4d8599c18363 100644 --- a/sys/fs/nfsclient/nfs_clport.c +++ b/sys/fs/nfsclient/nfs_clport.c @@ -1194,6 +1194,10 @@ nfscl_maperr(struct thread *td, int error, uid_t uid, gid_t gid) printf("nfsv4 no file handle: usually means the file " "system is not exported on the NFSv4 server\n"); return (EIO); + case NFSERR_WRONGSEC: + tprintf(p, LOG_INFO, "NFSv4 error WrongSec: You probably need a" + " Kerberos TGT\n"); + return (EIO); default: tprintf(p, LOG_INFO, "nfsv4 err=%d\n", error); return (EIO);