From nobody Tue Jan 24 22:14:07 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P1h8J2FvCz3bgqH; Tue, 24 Jan 2023 22:14:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P1h8J1LvCz3KXW; Tue, 24 Jan 2023 22:14:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674598448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FObcGDLamUnsbeF6eS5W3DgEZkcL1LyVeReIdKyAsWw=; b=vA5PVOE0i68jFHM5cW4Tlivm31zvr3bAILIDObnPu1ZTckf7XmmGWGR1LQzzgeBqaPWKVv ylCbCI3B5cZq8mKVRuYJpYt/CSBjqR0FHLfPzp7L6anrfufDdQg+2hgdpEbqQI4CvbY8F4 XX1DzMoUCfTfnUShHnNeuzcK1QerPDzU30acar0og25x1tRk41cJ9Dcr19CyjXxNK7DNiY NQYydObyu+3LTekx/KUox3fZwWxmEQnsoLwaU9F3uAX8SasQlDA2VUouo5U83Q5eZHOj42 euMoeCMjqcdSk0gZ+sI1uwubYAW8LDKAOBE+ZQrZFszBy6xnDIhFKFFYOIqKqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674598448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FObcGDLamUnsbeF6eS5W3DgEZkcL1LyVeReIdKyAsWw=; b=y4MFQYnlcDCjb7OXCqwgheI5yBwCqut0qxqKixtJEoS5V4iZLgZScq+BEFPfpTrdiGY3/m ToIcGwig1m2ZrkXjblcSPVQ5NMNnVBRjLgWY36SX+OVWn2ebLuneLzRCUi0IwM63Zj/qHu 95607qgzzLcaVkP/zPIJEtItNlLkSCy1BWu/CqEzLYqupdWQgDql3TlP8IP27an9aWaK+B PHuISn3sXz2DFmi50bfSyFbdwc0UbZqqiSDj8Rx1gKFBk/CaSxK8l1ix0Q20RWCwB6s/L+ 4w7r3bhE+YzayACBesH1iLUkZMquSEaOPGDVFjcWWdmXCboqXAQGUreMK5vaJA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674598448; a=rsa-sha256; cv=none; b=U4ULKmCW2/6jsl8I6VRqkJ/i21jjgshJY/IDJ6uJQgMtanHb4knKRovqkJftt5OtzWN2qK 21Go7XkLkZoA0smV4wz9vVrkw44Syn45h/mVW5k3lqYSlp+hwBhuDP9yTyYsRt/G5DYE/p KENAhB4QG64H8Zq8+VNAJ8YropZQ+3pzda2BoxPqmKHCVk2NBTJ70PhvYXmRU11XwN3wpQ IRycLAt1R3CPInOeET623laqkukJxfagY/zb3beT8fXk+61jheuXaSnOAzLmo2lK01Hp2j vKhn0iDeCgIzWLv1BRpf4JheNVeHRkmcOjjHQbLWOz+vWDXtoIFS9foj7SI/zg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P1h8J0Rm8zQq8; Tue, 24 Jan 2023 22:14:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30OME7Ef089392; Tue, 24 Jan 2023 22:14:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30OME7us089391; Tue, 24 Jan 2023 22:14:07 GMT (envelope-from git) Date: Tue, 24 Jan 2023 22:14:07 GMT Message-Id: <202301242214.30OME7us089391@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Warner Losh Subject: git: e68bfa6252a5 - stable/13 - kboot: Use (void) instead of () for functiosn with no args List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: e68bfa6252a501cf962760b313cbc3baefb6d407 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=e68bfa6252a501cf962760b313cbc3baefb6d407 commit e68bfa6252a501cf962760b313cbc3baefb6d407 Author: Warner Losh AuthorDate: 2022-12-09 14:55:42 +0000 Commit: Warner Losh CommitDate: 2023-01-24 21:49:44 +0000 kboot: Use (void) instead of () for functiosn with no args `int foo();` means 'a function that takes any number of arguments.` not `a function that takes no arguemnts`, that's spelled `int foo(void);` Adopt the latter. Sponsored by: Netflix (cherry picked from commit e830a6cbbe8e7ab359e871b0ba95b9b025c0ffcc) --- stand/kboot/hostcons.c | 8 ++++---- stand/kboot/main.c | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/stand/kboot/hostcons.c b/stand/kboot/hostcons.c index 80d4a1c4319b..9ff536279a73 100644 --- a/stand/kboot/hostcons.c +++ b/stand/kboot/hostcons.c @@ -34,8 +34,8 @@ __FBSDID("$FreeBSD$"); static void hostcons_probe(struct console *cp); static int hostcons_init(int arg); static void hostcons_putchar(int c); -static int hostcons_getchar(); -static int hostcons_poll(); +static int hostcons_getchar(void); +static int hostcons_poll(void); struct console hostconsole = { "host", @@ -79,7 +79,7 @@ hostcons_putchar(int c) } static int -hostcons_getchar() +hostcons_getchar(void) { uint8_t ch; int rv; @@ -91,7 +91,7 @@ hostcons_getchar() } static int -hostcons_poll() +hostcons_poll(void) { struct host_timeval tv = {0,0}; long fds = 1 << 0; diff --git a/stand/kboot/main.c b/stand/kboot/main.c index 88657d908b34..85453db50fa5 100644 --- a/stand/kboot/main.c +++ b/stand/kboot/main.c @@ -125,7 +125,7 @@ kboot_rsdp_from_efi(void) } static void -find_acpi() +find_acpi(void) { rsdp = kboot_rsdp_from_efi(); #if 0 /* maybe for amd64 */ @@ -135,13 +135,13 @@ find_acpi() } vm_offset_t -acpi_rsdp() +acpi_rsdp(void) { return (rsdp); } bool -has_acpi() +has_acpi(void) { return rsdp != 0; }