From nobody Tue Jan 24 22:13:03 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P1h73326nz3bgKZ; Tue, 24 Jan 2023 22:13:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P1h732P7sz3FZw; Tue, 24 Jan 2023 22:13:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674598383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AsNMwHmncFJNAibaUcqMZfH3Sce+B2zGqUrNkOfmwcc=; b=GHJzGIlwlvrllGxUoaEPTqN1pZ830RlT8AyJ+UsYiTFTD/TBS9lHYWNjw+2euNSBbAHwVK gmPVI1zX/yQNtYBiJKHEYnuDYQHaDy3TPmaeHxxa6h3Om00hlbeVtZgvwi6PHLHUAolt7E bZ3b2Xz1PDYgVuewUJOYCcuwQeQ3iGAYFHy+mJ4fw7CSwV2rO5ANw0Ym/U0Mw6ZfkRHzBW JpIOB1K0k/eljdd49a3C+QDFatFR8/myCVbGoz9brkoyVE8Imj98Zp5yuqrgh6IeAMx5PB yfp05Kmrw4xJC1aEHAaXl7S8UtqTD7X+96r1XVZ7wFgpJsP8J8h4gz0GXmuTrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674598383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AsNMwHmncFJNAibaUcqMZfH3Sce+B2zGqUrNkOfmwcc=; b=fh+r+oxZB3JZZSvmGbsFcdkBsbqbx0VYOwSxqAsBsuyKmKXLoDkxWyaWbbohLrvG0jop6n 8TNHqUUVxfnMfzFnzeKlmNpMaeyasiUcSlXzFTsmFazc7sWol4HylRieNFAMKegMHXTjNi 9SCBx3s53Cuyq6rRz/5xbh1EnqSUVk5Syyby1wjJyeU0DIURmO1VGZEQbz2h/Rkxr4EVXt J8KvXVY89YJSHb7V3GT9SJ3q+oQg2S0Zb5hMAWACILkVMUzu6OWPDl6oZbSbuZVXW5hTBH FZsBam+a/+sjsOIq9cj8JnePoNBkZQU41z5oROtnb/He7GfzKhTH284j91PTTA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674598383; a=rsa-sha256; cv=none; b=OXaN6mAHSBBJfmuMHDKyubN27dqZfqoqa6njI0dOB/dhX92bHsKpoAg2zDRISKphISJJFc pI4gs1DBncffQC4FF7V80dMTd9gp7betw4srP0Zs6ogv+ivlMspFqKA1RDSAhINvCI843l zvCLMGoLht2Ad17z04c+H1YYEbyjt7HqQjhbqCi8DJku7GvhZLGmZqpFEr1GWaw/6jTgIM jeWGr1cRtsJgtgh3T7lqkOf/SZm6hcdonyxp7XsU/7H0bie3PdYrc9meGvPJFme/RB35X3 3h7LyRF4xjVS4RwnbfjHy2iFdhCsjaicRptdHvKGeQkkOKgIWeS4Y7ph578kiA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P1h73140jzQk1; Tue, 24 Jan 2023 22:13:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30OMD3GI087876; Tue, 24 Jan 2023 22:13:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30OMD3dH087875; Tue, 24 Jan 2023 22:13:03 GMT (envelope-from git) Date: Tue, 24 Jan 2023 22:13:03 GMT Message-Id: <202301242213.30OMD3dH087875@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Warner Losh Subject: git: becebbab43c7 - stable/13 - ofw: Cast function pointer to proper type List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: becebbab43c7a52b9075b471dde514a76a1687a6 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=becebbab43c7a52b9075b471dde514a76a1687a6 commit becebbab43c7a52b9075b471dde514a76a1687a6 Author: Warner Losh AuthorDate: 2022-11-27 20:23:28 +0000 Commit: Warner Losh CommitDate: 2023-01-24 21:49:37 +0000 ofw: Cast function pointer to proper type clang 15 insists that we call entry() via a function prototype. Rather than copping out and using (...), cast it to the same prototype that's used elsewhere (with tweaks to pointers to make them fit into that prototype). No functional change. Sponsored by: Netflix (cherry picked from commit fea231d21b299535302b41ac2e841f8abf1787fc) --- stand/libofw/openfirm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/stand/libofw/openfirm.c b/stand/libofw/openfirm.c index b2b89581ae70..b780a9e36125 100644 --- a/stand/libofw/openfirm.c +++ b/stand/libofw/openfirm.c @@ -772,6 +772,7 @@ OF_chain(void *virt, u_int size, void (*entry)(), void *arg, u_int len) if (size > 0) OF_release(virt, size); #endif - entry(0, 0, openfirmware, arg, len); + ((int (*)(u_long, u_long, u_long, void *, u_long))entry) + (0, 0, (u_long)openfirmware, arg, len); } #endif