From nobody Tue Jan 24 22:12:15 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P1h676Gt1z3bfZ1; Tue, 24 Jan 2023 22:12:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P1h675d8hz3C5Z; Tue, 24 Jan 2023 22:12:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674598335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HJsyEaRFw4yknJ6Uunmwiq4cuxZR4mszToj6S07e+n4=; b=tWGBit08L+s0t++0qeISsYK6Y9Uonyz81qdeoQZ7CgXKSeNv1bEzBa4XA7S0OZNTgjCQz5 zX8MeBU2CokqrephA2iI2AwjNSNO/gLiy/20yuJwaX66p7wxQf+nVqNE0KVuGOZ76xlgs5 pzIDtgCGhEABZ7MvLOc0bhg5X6pgc9r65Au3BNBpron30h3VwWNkUeKtPshmbw4mcNlI9i EtJi+0pNmVGhSavmzcAHxbYQeuIUgok/PSyba4PNasmmgi/oAVDQAbYvLk0fHBx0mu1OOL sn1fUZZrsyUYmTFprEeo5YR8cFa1nDoMwJbsijw4GezhOmhNHWqSDh/mZ2A1gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674598335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HJsyEaRFw4yknJ6Uunmwiq4cuxZR4mszToj6S07e+n4=; b=bYwPwaeTjKVd0B/YRjWDbPUia3tLcbbYdAMLf33RIEu/jxz+/ZtXfmhnJvO90uMGfA7Mes tnVclWgh808Ec6Bjp0S+XOofZCu6jaDJjxEN/iSvp2gBdC5fNcRYEQSo8DnZTWpzTH7WP1 iOnBckxMqEp+9E1L0tCjlJFnAwVp6JYKumNMpV2Mec9/mNjTTrhLtNFB0Xd98+dHTTsNzZ br9RwavfwMUzMnCwBxhtRxNVBg3IfF8dEEPPpDNemmZksrn8yf5RiK22DhyTy7zyeazWRf /kmxCaZp5mBIzGnenMcrqMc8UcsN3m8qkEXfImLTv3D9QD4zvOK9TLhGRlikQg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674598335; a=rsa-sha256; cv=none; b=F/AZj3MY1JkFfiDZVn/sq9ktWpTLTOK9KjxaD4H5R/Ho5jCxQaXR2f/7QJ1ivofJv1aTxO OFbkn6i7jrUGBI3zRcdUwLRFHfKpyiC/9wgzNNp4z9QmT2VJL9rDLJFriyrD1S5JhBVHnz AdUCK5xOdFV7vt3C103Q0pfsTX7lHcIUD0QloetBbDHBhciy/xuj/M7CfohgSkYlihM0rS YzIp7aSbBuF84+wRL22Ng7qf5MnIobyG8Jnkc1h05tHDCijwSeUpXlg7re6IdlO7CQ1BzL BOfeklvAnc/opwEvrST/XZ5ycuoV+YlSYdV5GR+g0PDYc2nUK//os9avbTHd4Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P1h674jzczQcP; Tue, 24 Jan 2023 22:12:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30OMCFeA086778; Tue, 24 Jan 2023 22:12:15 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30OMCFR4086777; Tue, 24 Jan 2023 22:12:15 GMT (envelope-from git) Date: Tue, 24 Jan 2023 22:12:15 GMT Message-Id: <202301242212.30OMCFR4086777@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Warner Losh Subject: git: 1bd78b3302c8 - stable/13 - stand: Stop setting hints for bios loader too List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 1bd78b3302c8a615b793c9c644ff167344ae8d23 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=1bd78b3302c8a615b793c9c644ff167344ae8d23 commit 1bd78b3302c8a615b793c9c644ff167344ae8d23 Author: Warner Losh AuthorDate: 2022-09-01 16:33:09 +0000 Commit: Warner Losh CommitDate: 2023-01-24 21:49:32 +0000 stand: Stop setting hints for bios loader too Catch up to 2753bbe71b5a and remove the old hints. Sponsored by: Netflix (cherry picked from commit b1819983e70f5b8890404b7e07d17888d0cccfb6) --- stand/i386/libi386/biosacpi.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/stand/i386/libi386/biosacpi.c b/stand/i386/libi386/biosacpi.c index 236c3fc45e7b..3bda472f3fc6 100644 --- a/stand/i386/libi386/biosacpi.c +++ b/stand/i386/libi386/biosacpi.c @@ -63,36 +63,24 @@ biosacpi_detect(void) /* * Report the RSDP to the kernel. While this can be found with * a BIOS boot, the RSDP may be elsewhere when booted from UEFI. - * The old code used the 'hints' method to communite this to - * the kernel. However, while convenient, the 'hints' method - * is fragile and does not work when static hints are compiled - * into the kernel. Instead, move to setting different tunables - * that start with acpi. The old 'hints' can be removed before - * we branch for FreeBSD 12. */ sprintf(buf, "0x%08x", VTOP(rsdp)); - setenv("hint.acpi.0.rsdp", buf, 1); setenv("acpi.rsdp", buf, 1); revision = rsdp->Revision; if (revision == 0) revision = 1; sprintf(buf, "%d", revision); - setenv("hint.acpi.0.revision", buf, 1); setenv("acpi.revision", buf, 1); strncpy(buf, rsdp->OemId, sizeof(rsdp->OemId)); buf[sizeof(rsdp->OemId)] = '\0'; - setenv("hint.acpi.0.oem", buf, 1); setenv("acpi.oem", buf, 1); sprintf(buf, "0x%08x", rsdp->RsdtPhysicalAddress); - setenv("hint.acpi.0.rsdt", buf, 1); setenv("acpi.rsdt", buf, 1); if (revision >= 2) { /* XXX extended checksum? */ sprintf(buf, "0x%016llx", rsdp->XsdtPhysicalAddress); - setenv("hint.acpi.0.xsdt", buf, 1); setenv("acpi.xsdt", buf, 1); sprintf(buf, "%d", rsdp->Length); - setenv("hint.acpi.0.xsdt_length", buf, 1); setenv("acpi.xsdt_length", buf, 1); } }