From nobody Mon Jan 23 22:11:51 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P14874XkKz2t0W1; Mon, 23 Jan 2023 22:11:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P148742JSz3KTj; Mon, 23 Jan 2023 22:11:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674511911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XBbscov6Pr8uXmb96j6U/B3UoeW0sxVPAhzMZ41JDG0=; b=Uhmfw+jnRmQA8BPmzEsgjXzEJU0enlE+RaSM/i6lSMRxu2b73UuhsJWf8L3HGVqxyt9Ex/ iqar5jP1BF8R137YpDe4rykl1h3c9jUg4bvY2fWkmEcJo4zSzENgwZ9148rwlTIJ3hDjR3 dDIxDq3eOnUuac0GezUNDWQDM+1t4p6qKu4iVMD17S9zfbiHgEx7DTj1hGr5clsQKGVnMM DYmjYwe2YFl438V4S+1uGHIqZS4lvPBCQwOhkE2JNFM1hPJbgnqkfzbcbiVbAi0+i1GuiP UZp9LmJ0MrBNNwSHr9IRfj4dsuwr+BRu/vLMWUAs1TtnxYpb9I9dg/uTDx9vIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674511911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XBbscov6Pr8uXmb96j6U/B3UoeW0sxVPAhzMZ41JDG0=; b=vS70za6PNdE+wlDMSLuGEaGYH6qypH75Vm3IY+NEC+W4qgu+/GR9ZWoJTFOhhnuRUgCU+S NV0lTeGz3D+gIzMzTOBwGlEWn+NOaMDfdixiOMqAj1uw8Zu7ZWRTrPi9rzRGimKA+f3ilX NCez/q1CCEbDc/Vid5RGBi0OmRJLpVmEZGVIkLdU3toG/j0FDZnkVA0r6EqT0595VAkngk F4ysRryfZeyZ+SIV83jYqvKLMH/5PGv+v5jgGys7UkXpViwUEC2uWQl2aDnCamn6JGpj2G OjqmnyJdrRaiDFrKIvzUzKsDV/g1ffMaKCnGU8bdW1Na6IISL8oZ8xHDKMJU9g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674511911; a=rsa-sha256; cv=none; b=UaycPsLgMF0POeLiWgS1Wq+HJzA/NTkpp3q0QL5zGWjU5KDCPkncHJ7EcJ7iSHHyHPHeff gPOjnwWSyNroXvt608slw/dLN9MwWEOyGCv40alE6LErt5/F0c8da/aE/tELh91pfkpqyP TucyktwQPwa3DEyAzT3VResI6jjHuzYbTwDBL4EgUoOIcEcmoBOCtaa83gai8PTIXj5I3e BKsgN2zTI7ITHX5iX41dHeT7ZpFVi+dDksFFz+k/h5wV7+t7/rr7SaDkoGdhyDksls93sv /gsB70wW+zlAetoVhAiRYCVEnzgCF5wO0ihHJKagdaS4NAs+VqtafYk4LR1zJQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P14872rwXzlnR; Mon, 23 Jan 2023 22:11:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30NMBpSd012634; Mon, 23 Jan 2023 22:11:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30NMBpxP012633; Mon, 23 Jan 2023 22:11:51 GMT (envelope-from git) Date: Mon, 23 Jan 2023 22:11:51 GMT Message-Id: <202301232211.30NMBpxP012633@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: "Alexander V. Chernikov" Subject: git: 6e5d41dc8f16 - stable/13 - netlink: use (void) for function definitions with no arguments List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: melifaro X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 6e5d41dc8f165e16dc924dd50f7081783adb450e Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by melifaro: URL: https://cgit.FreeBSD.org/src/commit/?id=6e5d41dc8f165e16dc924dd50f7081783adb450e commit 6e5d41dc8f165e16dc924dd50f7081783adb450e Author: Ed Maste AuthorDate: 2022-10-27 14:49:51 +0000 Commit: Alexander V. Chernikov CommitDate: 2023-01-23 22:04:02 +0000 netlink: use (void) for function definitions with no arguments For some of these Clang produced a warning that "a function declaration without a prototype is deprecated in all versions of C". In other cases the function defintion used () which did not match the header declaration, which used (void). Sponsored by: The FreeBSD Foundation (cherry picked from commit 43d0c2ddd2556841717a50925f713c9c70d3936e) --- sys/netlink/netlink_domain.c | 3 ++- sys/netlink/netlink_generic.c | 4 ++-- sys/netlink/route/neigh.c | 4 ++-- sys/netlink/route/nexthop.c | 4 ++-- sys/netlink/route/route.c | 2 +- 5 files changed, 9 insertions(+), 8 deletions(-) diff --git a/sys/netlink/netlink_domain.c b/sys/netlink/netlink_domain.c index bca30bedce11..44b5fb732896 100644 --- a/sys/netlink/netlink_domain.c +++ b/sys/netlink/netlink_domain.c @@ -174,7 +174,8 @@ nlp_has_priv(struct nlpcb *nlp, int priv) } static uint32_t -nl_find_port() { +nl_find_port(void) +{ /* * app can open multiple netlink sockets. * Start with current pid, if already taken, diff --git a/sys/netlink/netlink_generic.c b/sys/netlink/netlink_generic.c index 64985f656a63..7d226f77e44b 100644 --- a/sys/netlink/netlink_generic.c +++ b/sys/netlink/netlink_generic.c @@ -440,7 +440,7 @@ static const struct genl_cmd nlctrl_cmds[] = { }; static void -genl_nlctrl_init() +genl_nlctrl_init(void) { ctrl_family_id = genl_register_family(CTRL_FAMILY_NAME, 0, 2, CTRL_ATTR_MAX); genl_register_cmds(CTRL_FAMILY_NAME, nlctrl_cmds, NL_ARRAY_LEN(nlctrl_cmds)); @@ -448,7 +448,7 @@ genl_nlctrl_init() } static void -genl_nlctrl_destroy() +genl_nlctrl_destroy(void) { genl_unregister_family(CTRL_FAMILY_NAME); } diff --git a/sys/netlink/route/neigh.c b/sys/netlink/route/neigh.c index 076f4bfafdf4..9bcbb68dd375 100644 --- a/sys/netlink/route/neigh.c +++ b/sys/netlink/route/neigh.c @@ -559,7 +559,7 @@ rtnl_lle_event(void *arg __unused, struct llentry *lle, int evt) static const struct nlhdr_parser *all_parsers[] = { &ndmsg_parser }; void -rtnl_neighs_init() +rtnl_neighs_init(void) { NL_VERIFY_PARSERS(all_parsers); rtnl_register_messages(cmd_handlers, NL_ARRAY_LEN(cmd_handlers)); @@ -568,7 +568,7 @@ rtnl_neighs_init() } void -rtnl_neighs_destroy() +rtnl_neighs_destroy(void) { EVENTHANDLER_DEREGISTER(lle_event, lle_event_p); } diff --git a/sys/netlink/route/nexthop.c b/sys/netlink/route/nexthop.c index 31816d84f189..64f46ad035fc 100644 --- a/sys/netlink/route/nexthop.c +++ b/sys/netlink/route/nexthop.c @@ -590,7 +590,7 @@ consider_resize(struct unhop_ctl *ctl, uint32_t new_size) } static bool __noinline -vnet_init_unhops() +vnet_init_unhops(void) { uint32_t num_buckets = 16; size_t alloc_size = CHT_SLIST_GET_RESIZE_SIZE(num_buckets); @@ -998,7 +998,7 @@ static const struct rtnl_cmd_handler cmd_handlers[] = { static const struct nlhdr_parser *all_parsers[] = { &nhmsg_parser }; void -rtnl_nexthops_init() +rtnl_nexthops_init(void) { NL_VERIFY_PARSERS(all_parsers); rtnl_register_messages(cmd_handlers, NL_ARRAY_LEN(cmd_handlers)); diff --git a/sys/netlink/route/route.c b/sys/netlink/route/route.c index 7b4fc64ec4bd..852843af1b7d 100644 --- a/sys/netlink/route/route.c +++ b/sys/netlink/route/route.c @@ -981,7 +981,7 @@ static const struct rtnl_cmd_handler cmd_handlers[] = { static const struct nlhdr_parser *all_parsers[] = {&mpath_parser, &metrics_parser, &rtm_parser}; void -rtnl_routes_init() +rtnl_routes_init(void) { NL_VERIFY_PARSERS(all_parsers); rtnl_register_messages(cmd_handlers, NL_ARRAY_LEN(cmd_handlers));