From nobody Mon Jan 23 11:39:11 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P0p6N0w0jz3bLqB; Mon, 23 Jan 2023 11:39:24 +0000 (UTC) (envelope-from melifaro@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P0p6N0LPjz4Lbg; Mon, 23 Jan 2023 11:39:24 +0000 (UTC) (envelope-from melifaro@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674473964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ByDkgT/6q4MJHdXNgecmj1WJffuTEbdGQSizyCyM41I=; b=G2c+pImgRjJoV56kL7jM5Byi4mwp/SKJ/4gSkz30KMvihscSKBJAZHsosgvQAp8EKAiK0Z QE9WF+ySJbcdO/wM4osKLOiyswQ7accoSgs/kfqNAgdWOWTjFVkaVCkuXxVgAE0ImHoTMI G+BHVKODelHQV9vryxqK0c62mBlBc1OPzvMmuAcQxiwR+kumdoD3PDUZFq8VJhMUHSoy0m Kl0q4QyCzcEKI9IX2wdDPsYxe0WEKQEhCWghE0U303MgHfoPL4ZyXXl6PnRAvZVCMwu/7/ DNwvIDTdVOL8BGv2kqvwAAsIfM+qDGIzAraUVsJ7w541mn2f97658s1SWxZESA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674473964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ByDkgT/6q4MJHdXNgecmj1WJffuTEbdGQSizyCyM41I=; b=YNEWaihRJi4mhUNGkYF8yOtM75xKXWr3NiZP4/epfeZUXIAeJJTCOiglQK5AJAIUiZ77Hy m4qo8xKXb67QyS6neiWlLqaeIIGghfxBYIupoGVmyFENDt5QJUXceOq44y2sp8eC7v3ItO F5YwV0g8JIG3LYDWQ5ilOHfBmkkzU8LRX021v7Wt6EVm7HYfGidvNCr1yUareJ10Lxw46U O2UKOugNnfDhmd8Gn/N/n8/UmJzN4ldawVRAViL1yaitPzX3wrlFXX9ZSCSz5n5pbivijL UvT9wq4u8t69tZC/kXFeY3U5Jtb7lQMGa4yewPN7hrnLpX/94p4VLGsgOXhijQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674473964; a=rsa-sha256; cv=none; b=NzvcIyNyj5w9w6mSIk7KsVyxBdeDex1SPCiUwfINYUTxZdr4Nu7aKrbVRWmjH3f/yZ5PbG /Oq0EjNGBuUOarYnj0aYQNdKpVoWtLCcVMgBTsSKaNyKh7UNl2yxi7oy1+5UXSGHdm/YMZ ybp8dKRTg3hUEuQDhzDfPCC/UT8xidcE4u4nVNHJlm7Fqj87h9r9OOu7vq0JVcLAmyEJdw qhDTTbkvdtitDHcVuz+hTTT4jVIKy0FjX1m1ayeZNzA0bLsuB/s03bVqAIxdvr+9tm1jf5 qVq5ba1x6G6dBx9D6F3luafqX6Cu1BsLBa15kTY8/UZkwEmvlwX4kIY1B0650w== Received: from smtpclient.apple (unknown [IPv6:2a02:8084:d6bb:510:cd14:7903:54e6:8067]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: melifaro/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4P0p6M2qNbzFW9; Mon, 23 Jan 2023 11:39:23 +0000 (UTC) (envelope-from melifaro@freebsd.org) Content-Type: text/plain; charset=us-ascii List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.200.110.1.12\)) Subject: Re: git: 81a72d997e22 - stable/13 - tcp: virtualise net.inet.tcp.msl sysctl. From: Alexander Chernikov In-Reply-To: <20230122110719.56ab1f60@ralga-linux> Date: Mon, 23 Jan 2023 11:39:11 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-branches@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202301132124.30DLOrE7040954@gitrepo.freebsd.org> <20230122110719.56ab1f60@ralga-linux> To: Justin Hibbits X-Mailer: Apple Mail (2.3731.200.110.1.12) X-ThisMailContainsUnwantedMimeParts: N > On 22 Jan 2023, at 16:07, Justin Hibbits wrote: >=20 > On Fri, 13 Jan 2023 21:24:53 GMT > "Alexander V. Chernikov" wrote: >=20 >> The branch stable/13 has been updated by melifaro: >>=20 >> URL: >> = https://cgit.FreeBSD.org/src/commit/?id=3D81a72d997e22f37ac15a009090a5a15a= 6c279900 >>=20 >> commit 81a72d997e22f37ac15a009090a5a15a6c279900 >> Author: Alexander V. Chernikov >> AuthorDate: 2021-12-04 22:02:44 +0000 >> Commit: Alexander V. Chernikov >> CommitDate: 2023-01-13 21:18:26 +0000 >>=20 >> tcp: virtualise net.inet.tcp.msl sysctl. >>=20 >> VNET teardown waits 2*MSL (60 seconds by default) before expiring >> tcp PCBs. These PCBs holds references to nexthops, which, in >> turn, reference ifnets. This chain results in VNET interfaces being >> destroyed and moved to default VNET only after 60 seconds. >> Allow tcp_msl to be set in jail by virtualising net.inet.tcp.msl >> sysctl, permitting more predictable VNET tests outcomes. >>=20 >> MFC after: 1 week >> Reviewed by: glebius >> Differential Revision: https://reviews.freebsd.org/D33270 >>=20 >> (cherry picked from commit >> c2c8e360d8c0b8712158d334686d88f052aef819) --- >> sys/netinet/tcp_subr.c | 2 ++ >> 1 file changed, 2 insertions(+) >>=20 >> diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c >> index 62042df50d18..dfbdf99f21eb 100644 >> --- a/sys/netinet/tcp_subr.c >> +++ b/sys/netinet/tcp_subr.c >> @@ -1453,6 +1453,8 @@ tcp_init(void) >>=20 >> V_tcp_msl =3D TCPTV_MSL; >>=20 >> + V_tcp_msl =3D TCPTV_MSL; >> + >> /* Skip initialization of globals for non-default instances. >> */ if (!IS_DEFAULT_VNET(curvnet)) >> return; >=20 > This looks like it was already MFC'd to stable/13 back in March last > year as 057793e6377. Indeed. Reverted. Thanks for catching it! >=20 > - Justin