From nobody Thu Jan 19 03:52:07 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ny7x35ZM3z2svbw; Thu, 19 Jan 2023 03:52:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ny7x33zZvz3RG3; Thu, 19 Jan 2023 03:52:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674100327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=w3QLP9k+V8hHcpfR3iNB8OKlcBJBq0Vgv/WPrr4U1YA=; b=oGGwG4UuBdxua0xPpAZCUEgGlse+NFHKLqGOSTKzVMaxQZQD8G8HUm2nRvsJdWvMvhWp8i PY4leEGx3tb7J92L0+J91ISfSW8OTc8KsW9WalFiqg5/RRC8AM5FgKSkHpnyG8YqpjAf4K VKHfJvbWIsH/bk7xDnYOvpLbZNb580iVj9APz/l+gXWac+bZClQT7Cq+xB594OtWj/Hihk FcQ+/vpsHO512nCHh2Cmp+kO/ABM9qkkYjPcNdr74hcGf2UVVlpgeNfxO/E6RxL6YOIyBv xmXbQutEfxDPN2zW2NBx/BRhaQNXxUpcWaT5IDqiRvKDLIshUPsjr8k2FSgfTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674100327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=w3QLP9k+V8hHcpfR3iNB8OKlcBJBq0Vgv/WPrr4U1YA=; b=xg9Urvl0vHDhqEGXD6A08G0ooD2+SXtucpStP2aQjPGusMMWwoeq6I1iH3mm1J2zNjw2c7 ttUBeda6h2C5blxvwkmlj5XLg7r2mrKp/xn3rQCThPHyMkBe5JciL9yRenxBq4SqjLmUaj uWDSQuDdIomcOMZJqONFGqoVT42/z2i5VWbCnvRGUAOFk6KFpF2JPu4YVhpxm7AUjKrkJB 3gYEIIYWG9rJML3fiaqL2LBtVcRKe/y5r6VolqZVBcEx/zjySkh+Ib9imkS7niH/hBePZ1 21kEWtBxxxc+uaW34q/Pn+fsPMWeqef3UqD3we5+Fygexige67cEU/z1NULgsA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674100327; a=rsa-sha256; cv=none; b=uMcCyNJ0YMO6iRcn4tFPK3RxEZJd+T6zBE3yxxHC+eCvJ4I5XRAKFmgbDbYOi+hIIrElbr 1NkF4jXBfZ8ojPhMvYSt0rNbJnkoWCw1eAlv0lnSPIqDWGCXHr0LVY0KEorZbPQqiKKeN7 BUZVWJavlkd3a2TeVxrUjET3H+Mk0nwre5+8qTA1KvnJJ8db7sIoatv3+jdnDU7GacvvlJ tVkx2x81nTNx5C5VFNMaShkOcepZkC3sAGmry6UdrEQcPiqqOBqrZMGEa8jQMM/Wq0PGZM wMUaj8jhKV3cL65vWBTWcB7xADrInqUQB+49GaKw6v3tHV0V32tdBIqYDGODGw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ny7x334gMzcQW; Thu, 19 Jan 2023 03:52:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 30J3q7Ga021821; Thu, 19 Jan 2023 03:52:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 30J3q7fT021820; Thu, 19 Jan 2023 03:52:07 GMT (envelope-from git) Date: Thu, 19 Jan 2023 03:52:07 GMT Message-Id: <202301190352.30J3q7fT021820@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Warner Losh Subject: git: eee5ebb851be - stable/13 - bnxt: Remove dead write to cp_ring_id List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: eee5ebb851beb1874b5e9d6f8b329b4ab67990c0 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=eee5ebb851beb1874b5e9d6f8b329b4ab67990c0 commit eee5ebb851beb1874b5e9d6f8b329b4ab67990c0 Author: Warner Losh AuthorDate: 2022-02-28 17:13:27 +0000 Commit: Warner Losh CommitDate: 2023-01-19 00:59:42 +0000 bnxt: Remove dead write to cp_ring_id Since this is read from memory, reading it and then ignoring it is dead code... Sponsored by: Netflix (cherry picked from commit 44b4f0370fe90d11306e9d3fdcacdc5b4ccc946e) --- sys/dev/bnxt/bnxt_hwrm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/bnxt/bnxt_hwrm.c b/sys/dev/bnxt/bnxt_hwrm.c index 60485cd06799..0009ffa25053 100644 --- a/sys/dev/bnxt/bnxt_hwrm.c +++ b/sys/dev/bnxt/bnxt_hwrm.c @@ -119,7 +119,6 @@ _hwrm_send_message(struct bnxt_softc *softc, void *msg, uint32_t msg_len) struct hwrm_err_output *resp = (void *)softc->hwrm_cmd_resp.idi_vaddr; uint32_t *data = msg; int i; - uint16_t cp_ring_id; uint8_t *valid; uint16_t err; uint16_t max_req_len = HWRM_MAX_REQ_LEN; @@ -128,7 +127,6 @@ _hwrm_send_message(struct bnxt_softc *softc, void *msg, uint32_t msg_len) /* TODO: DMASYNC in here. */ req->seq_id = htole16(softc->hwrm_cmd_seq++); memset(resp, 0, PAGE_SIZE); - cp_ring_id = le16toh(req->cmpl_ring); if (softc->flags & BNXT_FLAG_SHORT_CMD) { void *short_cmd_req = softc->hwrm_short_cmd_req_addr.idi_vaddr;