git: 04b24c1069a5 - stable/12 - cleanvar: Be more careful when cleaning up /var.
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 20 Feb 2023 07:18:18 UTC
The branch stable/12 has been updated by delphij:
URL: https://cgit.FreeBSD.org/src/commit/?id=04b24c1069a546056dc33fab1ce7b11d9bf89f14
commit 04b24c1069a546056dc33fab1ce7b11d9bf89f14
Author: Xin LI <delphij@FreeBSD.org>
AuthorDate: 2023-02-13 04:56:17 +0000
Commit: Xin LI <delphij@FreeBSD.org>
CommitDate: 2023-02-20 07:18:06 +0000
cleanvar: Be more careful when cleaning up /var.
The cleanvar script uses find -delete to remove stale files under /var,
which could lead to unwanted removal of files in some unusual scenarios.
For example, when a mounted fdescfs(5) is present under /var/run/samba/fd,
find(1) could descend into a directory that is out of /var/run and remove
files that should not be removed.
To mitigate this, modify the script to use find -x, which restricts the
find scope to one file system only instead of descending into mounted
file systems.
PR: 269213
(cherry picked from commit 39e8c2a29a860bdb69ffcfbc06de4d4ad103b458)
---
libexec/rc/rc.d/cleanvar | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libexec/rc/rc.d/cleanvar b/libexec/rc/rc.d/cleanvar
index fcfd365268c3..a682021ce5f6 100755
--- a/libexec/rc/rc.d/cleanvar
+++ b/libexec/rc/rc.d/cleanvar
@@ -31,15 +31,15 @@ cleanvar_start()
{
if [ -d /var/run -a ! -f /var/run/clean_var ]; then
# Skip over logging sockets
- find /var/run \( -type f -or -type s ! -name log -and ! -name logpriv \) -delete
+ find -x /var/run \( -type f -or -type s ! -name log -and ! -name logpriv \) -delete
>/var/run/clean_var
fi
if [ -d /var/spool/lock -a ! -f /var/spool/lock/clean_var ]; then
- find /var/spool/lock -type f -delete
+ find -x /var/spool/lock -type f -delete
>/var/spool/lock/clean_var
fi
if [ -d /var/spool/uucp/.Temp ]; then
- find /var/spool/uucp/.Temp -delete
+ find -x /var/spool/uucp/.Temp -delete
fi
}