From nobody Sun Apr 30 06:57:45 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q8HGd5QP9z48rhh; Sun, 30 Apr 2023 06:57:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q8HGd4wHSz3MX5; Sun, 30 Apr 2023 06:57:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682837865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TpTKiggGktfavv8QJE/rWZed+kw6kOlJIxWzLi68wMo=; b=yxYebNbfpw6Ze+ibAM9/ETbdD21OnCSnGWATZbsTjiQeZ+qCE1SjB1PRgVE581Sz0aq+T4 j2NcijS7Tn+mPnO9A5+b3ucVaUCFFJC0/ydr5P01Bgh+P87i13n/XRKD/s5IIe4UyTRtm7 MzAA8tklnlkNzrnTq1+1FTaxfvkTLv0d/Z5Lfyto8QuWF37lz+bHm3h8cezlQgOToId7xw sUy8Ck7GvnwKw0YbPQj4YUxaRTZGXr6iK0vwPhco/12hbTnWaJvbl/uPVKhEB703qCtcTV JdLj9WS9zGL0LXliiUIEMASbsHCNoMlQyiiI1/IGioohzTLxUvu0EMAeQc2RNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682837865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TpTKiggGktfavv8QJE/rWZed+kw6kOlJIxWzLi68wMo=; b=GjYkflzr90woHf5buGudgV/+/1zr6nbZBeP4Ocv6vb+rgr0RXQfmrMd82vc0mXsWQH35KH yTtgbLfQLpq/PQ5cIvga0WuVQGGreqI1SrSch09SVKoJ5vBpQoAGFX9AD1D4XdSoHKHl+R XArZvmKEhQWPiceSgq86Gt0OKWzpoHhxrSO3JHXftLUlvNjiilXThPce7xwzwb6tBHVIq0 OPycENNrx2soK9/6qZgBCVIh5W8sfRqgXGcpUN1RDqjm4j4OFyeAqeApzNprcYQ8/RU6c0 ZNez5jFcYewI2Ud9QTpz+gKI3ToQXX/obfTt/N91WPjgSFNP3lbDpd/banUP4Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682837865; a=rsa-sha256; cv=none; b=QzcsfYlxo5/Gi+Ct9Xr7oXDBjWYCrpswVlAzBN5U11mQ+Ho6PMkDJm1TRMpVjx1U80u0Uh iJk+lOTltuqdsiVZMDFTP2mDE8yShYJk3lL7gCK7WnVLTenEHeFdvKGLATe3RABjU34rQA hyQQjHOP7JgC+zbNwjU2Yat95YfZyCdSVO6D4josJtq6BxUhY9LW1oxT40RXkbkBF/7Hiq EnYi2dwLonOxxr1G77zr69tAZ5tPDyRkknAaehAWie6J6/sqe+aURYqG+LhtuqeXRWDlYD JdaTSjW9HrFR1X+csWZboXr3tWDAxRF+zx4UKq/h3/k59QHbJMYh8KDmIUpmgw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q8HGd3kM3z1Crd; Sun, 30 Apr 2023 06:57:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 33U6vjE5071381; Sun, 30 Apr 2023 06:57:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 33U6vjqk071380; Sun, 30 Apr 2023 06:57:45 GMT (envelope-from git) Date: Sun, 30 Apr 2023 06:57:45 GMT Message-Id: <202304300657.33U6vjqk071380@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Hans Petter Selasky Subject: git: d9a8025f4849 - stable/13 - uhid_snes: Remove USB_ST_TRANSFERRED handling for the status request. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: hselasky X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: d9a8025f484984a2165767762648f668b869f49f Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=d9a8025f484984a2165767762648f668b869f49f commit d9a8025f484984a2165767762648f668b869f49f Author: John Baldwin AuthorDate: 2022-04-18 19:27:48 +0000 Commit: Hans Petter Selasky CommitDate: 2023-04-30 06:56:15 +0000 uhid_snes: Remove USB_ST_TRANSFERRED handling for the status request. The result of the request computed in new_status was never returned to the caller leaving new_status as a set-but-unused variable. Removing new_status leaves sc->previous_status as a write-only variable. Removing sc->previous_status leaves current_status as a write-only variable, so it collapses down to removing the entire USB_ST_TRANSFERRED case. Arguably, all of the support for UHID_SNES_STATUS_DT_RD should be removed as it doesn't return anything to the caller. If the request should be fixed instead then this commit should be reverted and new_status should be returned to whoever submitted the request. Differential Revision: https://reviews.freebsd.org/D34840 (cherry picked from commit 540ac338d5575131d134d2c033f31b5d6d576c68) --- sys/dev/usb/input/uhid_snes.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/sys/dev/usb/input/uhid_snes.c b/sys/dev/usb/input/uhid_snes.c index 9bce3d10941f..d786b0e1f257 100644 --- a/sys/dev/usb/input/uhid_snes.c +++ b/sys/dev/usb/input/uhid_snes.c @@ -94,7 +94,6 @@ struct uhid_snes_softc { int sc_fflags; struct usb_fifo *sc_fifo_open[2]; uint8_t sc_zero_length_packets; - uint8_t sc_previous_status; uint8_t sc_iid; uint8_t sc_oid; uint8_t sc_fid; @@ -498,7 +497,6 @@ uhid_snes_status_callback(struct usb_xfer *transfer, usb_error_t error) struct uhid_snes_softc *sc = usbd_xfer_softc(transfer); struct usb_device_request req; struct usb_page_cache *pc; - uint8_t current_status, new_status; switch (USB_GET_STATE(transfer)) { case USB_ST_SETUP: @@ -517,13 +515,6 @@ uhid_snes_status_callback(struct usb_xfer *transfer, usb_error_t error) usbd_transfer_submit(transfer); break; - case USB_ST_TRANSFERRED: - pc = usbd_xfer_get_frame(transfer, 1); - usbd_copy_out(pc, 0, ¤t_status, 1); - new_status = current_status & ~sc->sc_previous_status; - sc->sc_previous_status = current_status; - break; - default: break; }