From nobody Tue Apr 25 00:38:19 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q53581Z06z466XC; Tue, 25 Apr 2023 00:38:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q535812cSz4D4D; Tue, 25 Apr 2023 00:38:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682383100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=O5tn+26hZitY/ehp/822o7v2GA6k6wUgJSyT6S6gCwg=; b=UF6z+ieFICeHCy7398qPCBdzyiVTY7Gl6s1tLiAFz099GXYPs3Es01DdBUWanOskzjbCWl 8aeOF2la30D+tlH/6PMt+wPXQW9GuOgcjfR0n8WS0k7WqTPvM3qs2cwFMJAj+mqlJYz2tz tb/fKO+TR/9swPiZ10YD/zbFZGgs+Q6aBWOUkw7UCZP+WZ/P6DObKaME6LKbIoxuKAinON 9ZtvEpFW10XP0fT/q6g5Ot9avRmuGu/djbdHlGeHwBUlK8lBYVihWoF8ub/PZqXtbAqS9Z Sgfcg8IboZK3TAFTVMy8jphTjY4zg9i6aDwYyupEJsZS/b47YSCngZX/dRGHag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682383100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=O5tn+26hZitY/ehp/822o7v2GA6k6wUgJSyT6S6gCwg=; b=Dj0iXVeDWslWzex1AN9DmTQW5USQBUSr6qn3FHCX8rY2ndWPGQrvoiR2w/1jImkrI0MfiZ dTz/RR2axokCnZ5amRHnevq6826/loA3czHvVZFOqKs9W1Ds+FfJEDCCcbWIW7fxvpqoJn DDuZoCbcvKaSTYni99sg3zlO3/ly8HkYWOTNuD/2vepEimo5vbAUzM1YOfnxLrgp+ymZoN P/nc39AoppnJdSqK3ooB6cpQUaf8xrLnIawvSgAskS5sh2AsB9NsSRO4YOiuTRzrR7/1ud z3hDul33AzEQSl7qMr9QV0PjLtNLVNQCcFWqGP+FtKhSg0vczgvvwVfGBBBZOQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682383100; a=rsa-sha256; cv=none; b=kppOsqdWYOMqggjphNsOwIf/a7mVJfCPF4x6f6yT++bY5jWj8K4uKCx5DclQIHlKPT94p6 Eac5dXXuzSlUlE0uFY3Ec9YBVQCkYolYW6IhRpEw82Sei0311nujYoJnUB0nvX/CVlfw5Q FkrFXy5A3gCPu/tbPnTllS8hBrTUqBe57kqbTZi++a52XX/ExxG82dwEAyFqW8ocf6GXGT ivyBMFfitXZK7qAgoDf4FGtKlodKYoGPefkN8DAgtexfz2pwF5AyBiQJ0iKHPfEDzlp6O0 OFFHS9oTtvBLgTid5A/FRfzHgshfxNcMQ5rNYhnZLF3LliM0jwaY9Qv973gL+A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q5358072YzmJV; Tue, 25 Apr 2023 00:38:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 33P0cJ1o057316; Tue, 25 Apr 2023 00:38:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 33P0cJ6I057315; Tue, 25 Apr 2023 00:38:19 GMT (envelope-from git) Date: Tue, 25 Apr 2023 00:38:19 GMT Message-Id: <202304250038.33P0cJ6I057315@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Konstantin Belousov Subject: git: aad9b8f78c31 - stable/13 - sync_vnode(): add assert to check vn_start_write() correctness List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: aad9b8f78c311c0ed6182234fe0c441e70f76613 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=aad9b8f78c311c0ed6182234fe0c441e70f76613 commit aad9b8f78c311c0ed6182234fe0c441e70f76613 Author: Konstantin Belousov AuthorDate: 2023-04-15 19:41:44 +0000 Commit: Konstantin Belousov CommitDate: 2023-04-25 00:27:27 +0000 sync_vnode(): add assert to check vn_start_write() correctness (cherry picked from commit d8a096621bcf4539d0920eb0711d19fcb30c0576) --- sys/kern/vfs_subr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index 7ebd63447caa..672000ded079 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -2651,6 +2651,9 @@ sync_vnode(struct synclist *slp, struct bufobj **bo, struct thread *td) mtx_lock(&sync_mtx); return (*bo == LIST_FIRST(slp)); } + MPASSERT(mp == NULL || (curthread->td_pflags & TDP_IGNSUSP) != 0 || + (mp->mnt_kern_flag & MNTK_SUSPENDED) == 0, mp, + ("suspended mp syncing vp %p", vp)); vn_lock(vp, LK_EXCLUSIVE | LK_RETRY); (void) VOP_FSYNC(vp, MNT_LAZY, td); VOP_UNLOCK(vp);