From nobody Sat Apr 22 09:01:16 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q3QNr60qQz46RQT; Sat, 22 Apr 2023 09:01:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q3QNr562Cz4cZ4; Sat, 22 Apr 2023 09:01:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682154076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tI9nHMXDjR9xvgpRPIYNE0S7QNifvjnTuR8LIgkp4cY=; b=GBVNnA/lguPBooAjlVg2Uq3qNR4oBxPsZOBUHqkv4v08DxyLtfSWzhjoymRaMK5KEOEXCK GCKSZ19YQla6iyZpjQsGQNUN5n6G3BItZAXLseAiKQ8xRdPu9j1STheIgoL0MQILspdVYa 5xVpo/nDtkeJtjqycws7vihvEMYyBAj6+w0HqO8+M9lsfXOsNvXzx3HzScO4ODDEqPEU02 x52bKO5YLtbllCKPWwuMOrXyw0nw/w+CWfaUMcC575AYuQpkVQibJGYOqqG3oosv4Hn48c ebVk2C+JKmDhLRgvEazgRV/YvxCCoNkF8ujKfJryDCNB0mk1M1Xo7VXOPHrlug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682154076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tI9nHMXDjR9xvgpRPIYNE0S7QNifvjnTuR8LIgkp4cY=; b=PtMGerAQSdaojCvPcPcv3AcTtFKewJdGFmzIrOH4ACX1bkdyyQ3OQkNU+0k3udTRnFtOH3 EulFvrRFc81hPyV2vpbpD6qBuVS886aVBSM/d9oaQpsWo7ajIj9b6SfJ3HDs1eNeVTmFvZ btkHnkVOVpV3MfgLn0e0TiAP178FxgtGbvfi4IQ2C+7gYtyyE14SZWOcqmAIUvaRWysbhp +RgbG3mv5teTbrmtWvP/eNAhmPMGAa62HCdUTswx+FssLwS+LD0/NLn5c8jXqPCsDYowCh +u4pUigOPY+bLqSGV6vveyzmkU+WkF/S90Zen/hftdiK/DuS+4kUJhlL3pz17A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682154076; a=rsa-sha256; cv=none; b=pqAOXVs7jNC/UaWoR7fW/iy1x+R4G9g/zjwSybSl1pikMJoboNXsliAd1IKaO2rxSpKcmc HVPGn8SLhQFhOggo1Q/JylFEj8sVTS5BqX7kINGwe4mW5p59waUzBdFrZJDGDsnWIEh1W7 cmX9Xerbm6MBlIUROMxNTASScohi+F4D13i1WnNd5UgqAfUG9FTwRKcB/PqfIlbtSdrhz5 Cg/dBXpzaosU13OlHHorsGGDxukvWLri9kzr/EsDF3/kA1U5V6BdbbA4v+QDszbcgdWlxs kGDlTFtk+5BRvhxWEJC4o4q+LwZmR4tI3avjD2o+OTinIGiaWiIe62vmkgjo/w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q3QNr4CqqzwBg; Sat, 22 Apr 2023 09:01:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 33M91GZr074838; Sat, 22 Apr 2023 09:01:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 33M91Gl5074837; Sat, 22 Apr 2023 09:01:16 GMT (envelope-from git) Date: Sat, 22 Apr 2023 09:01:16 GMT Message-Id: <202304220901.33M91Gl5074837@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: 17eaa359dcb5 - stable/12 - ichiic: use bool for one-bit wide bit-fields List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: 17eaa359dcb5cb51f5b1a23d34a5c744e350ad8e Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=17eaa359dcb5cb51f5b1a23d34a5c744e350ad8e commit 17eaa359dcb5cb51f5b1a23d34a5c744e350ad8e Author: Dimitry Andric AuthorDate: 2023-04-18 18:08:28 +0000 Commit: Dimitry Andric CommitDate: 2023-04-22 09:00:22 +0000 ichiic: use bool for one-bit wide bit-fields A one-bit wide bit-field can take only the values 0 and -1. Clang 16 introduced a warning that "implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1". Fix by using c99 bool. Reported by: Clang Reviewed by: emaste, wulf MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D39665 (cherry picked from commit 87f55ab0b46ad72efee11d1b64ec8f839bb013da) --- sys/dev/ichiic/ig4_acpi.c | 4 ++-- sys/dev/ichiic/ig4_iic.c | 8 ++++---- sys/dev/ichiic/ig4_pci.c | 4 ++-- sys/dev/ichiic/ig4_var.h | 8 ++++---- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/sys/dev/ichiic/ig4_acpi.c b/sys/dev/ichiic/ig4_acpi.c index 673f160c6312..44d07eff9ac8 100644 --- a/sys/dev/ichiic/ig4_acpi.c +++ b/sys/dev/ichiic/ig4_acpi.c @@ -107,7 +107,7 @@ ig4iic_acpi_attach(device_t dev) ig4iic_acpi_detach(dev); return (ENXIO); } - sc->platform_attached = 1; + sc->platform_attached = true; error = ig4iic_attach(sc); if (error) @@ -126,7 +126,7 @@ ig4iic_acpi_detach(device_t dev) error = ig4iic_detach(sc); if (error) return (error); - sc->platform_attached = 0; + sc->platform_attached = false; } if (sc->intr_res) { diff --git a/sys/dev/ichiic/ig4_iic.c b/sys/dev/ichiic/ig4_iic.c index f24b26f53366..b4ef235bcf38 100644 --- a/sys/dev/ichiic/ig4_iic.c +++ b/sys/dev/ichiic/ig4_iic.c @@ -337,9 +337,9 @@ set_slave_addr(ig4iic_softc_t *sc, uint8_t slave) { uint32_t tar; uint32_t ctl; - int use_10bit; + bool use_10bit; - use_10bit = 0; + use_10bit = false; if (sc->slave_valid && sc->last_slave == slave && sc->use_10bit == use_10bit) { return; @@ -364,7 +364,7 @@ set_slave_addr(ig4iic_softc_t *sc, uint8_t slave) reg_write(sc, IG4_REG_CTL, ctl); reg_write(sc, IG4_REG_TAR_ADD, tar); set_controller(sc, IG4_I2C_ENABLE); - sc->slave_valid = 1; + sc->slave_valid = true; sc->last_slave = slave; } @@ -1009,7 +1009,7 @@ ig4iic_set_config(ig4iic_softc_t *sc, bool reset) (sc->cfg.bus_speed & IG4_CTL_SPEED_MASK)); /* Force setting of the target address on the next transfer */ - sc->slave_valid = 0; + sc->slave_valid = false; return (0); } diff --git a/sys/dev/ichiic/ig4_pci.c b/sys/dev/ichiic/ig4_pci.c index 71b95c3d95fb..d6906aa80e1a 100644 --- a/sys/dev/ichiic/ig4_pci.c +++ b/sys/dev/ichiic/ig4_pci.c @@ -316,7 +316,7 @@ ig4iic_pci_attach(device_t dev) ig4iic_pci_detach(dev); return (ENXIO); } - sc->platform_attached = 1; + sc->platform_attached = true; error = ig4iic_attach(sc); if (error) @@ -335,7 +335,7 @@ ig4iic_pci_detach(device_t dev) error = ig4iic_detach(sc); if (error) return (error); - sc->platform_attached = 0; + sc->platform_attached = false; } if (sc->intr_res) { diff --git a/sys/dev/ichiic/ig4_var.h b/sys/dev/ichiic/ig4_var.h index da81980039f1..3cad69cf57e3 100644 --- a/sys/dev/ichiic/ig4_var.h +++ b/sys/dev/ichiic/ig4_var.h @@ -91,10 +91,10 @@ struct ig4iic_softc { struct ig4_cfg cfg; uint32_t intr_mask; uint8_t last_slave; - int platform_attached : 1; - int use_10bit : 1; - int slave_valid : 1; - int poll: 1; + bool platform_attached : 1; + bool use_10bit : 1; + bool slave_valid : 1; + bool poll: 1; /* * Locking semantics: