From nobody Sat Apr 22 09:01:14 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q3QNp4FbDz46RFn; Sat, 22 Apr 2023 09:01:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q3QNp3VNxz4cDJ; Sat, 22 Apr 2023 09:01:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682154074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FOtXdasmqwV/sJXOzfUvD2i2poyZnhGlh0pdMa4DdIU=; b=tTif2O5Z6rlcl6im+D2oKYzcHxlHpQXs9N5O4iHZPdOd8HZwaldCnSJW8SHU1+oNWDXW3p tP/MYdX46tsir/YmMp2z3xSNabw8Xavz7noQpOsCKxzXIihy+D4SCzVNh21iHXViOJS0hm /JdNlsa8OrMa6l+uNxWXTB7xZv9aWWN0I+JWy/WSvy1WCnc6ti/1Ld6T2T5vipwW3VjDX3 40cGLu4K5/KKL9Aw73BkjXMRQzAKu3qv+hYCkR3PxxtgKFr6OTsG4PR+NqMIvrbLzgCV1s lKXvtpPV3a/YdnNfDUDkeDy5msd7Z/cNp5WDktj8u0IuYUF7qgCNorg7QwrvuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682154074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FOtXdasmqwV/sJXOzfUvD2i2poyZnhGlh0pdMa4DdIU=; b=dR6UXeWGr8U7vSgdZKQzHfzYOaHHQaW+/cnv7qBvCSWS4ttwE9aqHeQZcjHj7jrJ9uHUGb cJNvH1qmjJyPenbcQq5YCF1rJaCmSRgm8P+CnJyGijcGl7WsrRg1pjCq3y9lX+X8/3mepd sUfkzxUrqBNKUFv4f+bawhZ+JreesIeI0hy2cBDeFAZqTfGl6iYM2o1azwnFZinjiJC/Uf G6CImwpcBHObWwu+l9v9ZCItYBRstHt3OrZzerPX4guhJo71DYXSiK6iUuEcW6SaQk4O9Z tsY5YhFE+lYv0Iwko7yczQklA+868Vltn5w6ihRJK/7LEyMpwobQy+v79RHnyA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682154074; a=rsa-sha256; cv=none; b=AIjijFMIT0ItaRrqRjzfdhwGPQLcVK2w/RRcLRqI1A1BDomv5J4Y+AJLg6Oy7vE3xk8+OC rzghsHu+82KEq1L92D39SbF9Pia2AX8OF+Ac3MGK9fXhTaxgdH5J5Sg+eWsidB5W2YiZTy I5lCXQckx031xZnBEEkcDoZrsa/W0lyzVuKrQmyYAzYONCrqVt/3M/oe2O3sp3FQCTyOVs iZeBqFaOXoCcuhd/nBxtll5H4EkvXYe8+NeQj0mKGfRNogq4ovnH33z/knszMJqeI8tP/C Z0TfboegjcU1OSLjRpleInjeZLvW2xaQ/+EaYIE4CFmH4dVdFG6lxKUi0CC6zA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q3QNp2b7tzwBZ; Sat, 22 Apr 2023 09:01:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 33M91E8h074793; Sat, 22 Apr 2023 09:01:14 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 33M91E7U074792; Sat, 22 Apr 2023 09:01:14 GMT (envelope-from git) Date: Sat, 22 Apr 2023 09:01:14 GMT Message-Id: <202304220901.33M91E7U074792@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: 859735832d83 - stable/12 - bsnmp: make single bit bitfields unsigned to avoid clang 16 warning List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: 859735832d83e80a32c974bf3324023442edfe70 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=859735832d83e80a32c974bf3324023442edfe70 commit 859735832d83e80a32c974bf3324023442edfe70 Author: Dimitry Andric AuthorDate: 2023-04-17 16:11:56 +0000 Commit: Dimitry Andric CommitDate: 2023-04-22 09:00:07 +0000 bsnmp: make single bit bitfields unsigned to avoid clang 16 warning Clang 16 introduced a warning about single bit bitfields in structs, which is triggered by a declaration in bsnmp's snmpd.h: contrib/bsnmp/snmpd/trans_lsock.c:271:21: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion] peer->input.stream = 1; ^ ~ Signed one-bit bitfields can only have values -1 and 0, but the intent here is to use the field as a boolean, so make it unsigned. MFC after: 3 days (cherry picked from commit b740e02500ca248e1096cf745a17d2a8fcc44fed) --- contrib/bsnmp/snmpd/snmpd.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/bsnmp/snmpd/snmpd.h b/contrib/bsnmp/snmpd/snmpd.h index 48a7b44a04b2..394a4f4736d6 100644 --- a/contrib/bsnmp/snmpd/snmpd.h +++ b/contrib/bsnmp/snmpd/snmpd.h @@ -152,12 +152,12 @@ struct port_input { int fd; /* socket */ void *id; /* evSelect handle */ - int stream : 1; /* stream socket */ - int cred : 1; /* want credentials */ + u_int stream : 1; /* stream socket */ + u_int cred : 1; /* want credentials */ struct sockaddr *peer; /* last received packet */ socklen_t peerlen; - int priv : 1; /* peer is privileged */ + u_int priv : 1; /* peer is privileged */ u_char *buf; /* receive buffer */ size_t buflen; /* buffer length */