From nobody Fri Apr 14 12:52:47 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pybvh2j34z45BXP; Fri, 14 Apr 2023 12:52:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pybvg73Phz3rWr; Fri, 14 Apr 2023 12:52:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681476768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cMVdJYwvxLbJ7vUVkjii/G7lsZuRnG47yZ2ujjKadeA=; b=Fgoz+QSpxlk+FmUNBksE5DbFdI7K2uzQJNTnU0auI8OWybRVlnwt52znly1FT9WGR7UuBD /3GfScEs9V3txUGg/hj5cOFgBQI+rqiV03GTCBuTOMxPWUXflIBexb43MeLsyNV6xoKC4d 1LqZCOas5ZEQU11yAicdUlEOcCJ0a77+GtrVLPnGeV6m8h6OsHEIThe11/Rg85AVloqZLs /zDP1DYb3UVQOxzbWZn7QpOwqyMV/Qi3c3tNSI+pZUONdDPhjrD9KUX0wR06h2JhS2xjwV kbQMJsDTW3mXMmid23/3JTCuDuELcGGavZJf2oOqoMn0jOuN2Zd5J1lifp8Tgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681476768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cMVdJYwvxLbJ7vUVkjii/G7lsZuRnG47yZ2ujjKadeA=; b=RwMBT3ZqyYsCE7flKZyP/n/7nTS9gOdqHY6i+6+nEblzwkJfAemb3lSUmCSSpOyWmrs8xE /VlWureJ2inxDiqdp3qVLfnHwgDlCP0zoKcYviENbhphlRgZvZr3hWO+IvXt4vTorYZ+gV DLyKCKqqhlCcvvlXl3IR3ODOvfLrfBw3soHwR/Fof9QR4XBCtIctr6QMjkSmWe8FXyTN6S G4a+2uzI5SWPX2tPeLrL2zrDgDazu/bqKsx74Ji14p5PBrBgPMRYqppIDGc4v1NBm9QMmu 7BHeFbEIyoyMx+04JSNhfueumI4LXImVkEuViNcnzPXTE+MOBwZPXe8uGCZqiQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681476768; a=rsa-sha256; cv=none; b=d1+XyPFyZIOAt0JwcfEPgbuOxuWw9zivJ0cPGtNH6bz3Aim+2d194FlVekU4MA0k2mIOFq shC5vj/SvCgc4WHMjoz+S4sJ5ehnN3lAHX9o3deEA0IOMuhnvo56W1W6l5qDwaW0LFGOPY vvrSiB/Fp/ZchC1DR136TBRogXphT2jNGD7IRwXyeuEJ9B3XDzZmU3zIPEZkwJNbOlllFI baH8MFnuAVsKyPHiY5waUc2AjHArRYUVkzDBGeBmHdGgf8tZ8VOQ03WM0n3tUNN/Ja9FCf OEBfHJ1q6p9pSpqTQI9GlbO+7+9ERCO0wTRSP0VjZTMyrdmrta2mW1/uKEhaRw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Pybvg69PzzPrs; Fri, 14 Apr 2023 12:52:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 33ECqlv9074727; Fri, 14 Apr 2023 12:52:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 33ECqlou074726; Fri, 14 Apr 2023 12:52:47 GMT (envelope-from git) Date: Fri, 14 Apr 2023 12:52:47 GMT Message-Id: <202304141252.33ECqlou074726@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: 57f6ba0e3878 - stable/13 - makefs: remove vestigial '?' cases from top-level getopt(3) loop List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 57f6ba0e387836c6d7356829d71c30ef96e914cb Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=57f6ba0e387836c6d7356829d71c30ef96e914cb commit 57f6ba0e387836c6d7356829d71c30ef96e914cb Author: Ed Maste AuthorDate: 2023-03-30 01:33:39 +0000 Commit: Ed Maste CommitDate: 2023-04-14 12:10:36 +0000 makefs: remove vestigial '?' cases from top-level getopt(3) loop getopt(3) returns '?' when it encounters a flag not present in the in the optstring or if a flag is missing its option argument. We can handle this case with the "default" failure case with no loss of legibility. Obtained from: OpenBSD makefs.c 1.22 (cherry picked from commit cc4adc4c4e473d47b687d2ac2757157abd728c81) --- usr.sbin/makefs/makefs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/usr.sbin/makefs/makefs.c b/usr.sbin/makefs/makefs.c index 987f4159b403..7f23b8a6a5f1 100644 --- a/usr.sbin/makefs/makefs.c +++ b/usr.sbin/makefs/makefs.c @@ -270,7 +270,6 @@ main(int argc, char *argv[]) fsoptions.sparse = 1; break; - case '?': default: usage(fstype, &fsoptions); /* NOTREACHED */