From nobody Thu Apr 06 18:04:29 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PsqC14Kvdz44fDl; Thu, 6 Apr 2023 18:04:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PsqC13hLcz3QSv; Thu, 6 Apr 2023 18:04:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680804269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PZayuOCxMIZZU+/aKXv/JjbppSs++m1dIFMt8kWIKv0=; b=REzM1+26vVWNyzk51dhBP8s+UutMaG9Zg+asus1t8R7RKKC8TsXQYoDcLuQiheL7JcUcxh TEfbJjSrdm07HV9sMx3UfQftcuHAxE9N/dZXOTDYXZ8Vev+EZ4iGib6xByC8DHfdCxRJaI gff9q+vPkHJuT44uoEqiNAJHrQ2BsL9eQ2xbHLIzC93tOTmSzcQCbclg69KECzylUHet3S 95cfU468SzdjsSQFF4kfCOwfhRBkS/XqgPgyOcXKcfHpAemFxjkCun/rqpohMqDdy5wbOF /sd/8S9UWiJc/jjsCcGbG89JrHgh741P3brxwzAz4ZmNOcRgcjs+5uBHMydf5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680804269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PZayuOCxMIZZU+/aKXv/JjbppSs++m1dIFMt8kWIKv0=; b=S5QGTtZFhfAo2McDrOZnJpck1vYZFWnQFbxqngmO5WhocyEFXPXS8GaTq9nTfpp7K8ygPu SPV0KkdDyCFfHOrV2xK+MtQpVuuXGJ7N6hnrWK68++g3BUCKvu6Ni9TKOItQi5m4rMgtPG 9PECzhMxUqwhLbS3adDSikQ4QK5gPIrgiMBfiUYjXLPBQZiCdp8K1cJ/esQjuqCsqAizTc URu0rRJwrWhV9BjVL3oUhbzeELuRERLPud1hmSrRgHReHdQz2CA66wy2r9XP3JapHGjyrh EcQTDXbwp22VcJGk6Z2GIWvKUtGG9uUNwqxyiBVZi+Id5DI33iskqsd5EWOsJw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680804269; a=rsa-sha256; cv=none; b=iyRMQGsimxvB7bCTNm6D67wJVHVajriMEQupkPxNvLmSVSPwSEVyqdg82p+q2SKahRhCdI l1tXcqTdpKfuAP+5luyYnlfaje0c/pxZc56bFI4TA+umjrzAmaz4X0FQajuuM35skCDHrB A4qz6t75kb8ISuro/1+FGx/ZaxkCacD64H79aK2KQRlJAGC/vTIklyk9wvEfyQEB8GmeNG 985jPYKC9nhDnk4m4axt6g+gbIl/UrAERclk/swjZh8pnHmME2WygXyij22D+rxJ1Gt5fu NEIx/K8sJUK7Lwu3RJS7rZ3hnlU4EGX0n9m22UEkWl4PTfLTpoeKuuKE1d+AMQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PsqC12mvGzF7V; Thu, 6 Apr 2023 18:04:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 336I4Tni010676; Thu, 6 Apr 2023 18:04:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 336I4T6Y010675; Thu, 6 Apr 2023 18:04:29 GMT (envelope-from git) Date: Thu, 6 Apr 2023 18:04:29 GMT Message-Id: <202304061804.336I4T6Y010675@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Konstantin Belousov Subject: git: 74aa6df1f63d - stable/13 - fdesc_lookup(): no need to vhold the dvp vnode List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 74aa6df1f63d1c92a959e7c6bb9395e6f153cb5d Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=74aa6df1f63d1c92a959e7c6bb9395e6f153cb5d commit 74aa6df1f63d1c92a959e7c6bb9395e6f153cb5d Author: Konstantin Belousov AuthorDate: 2023-03-22 13:36:00 +0000 Commit: Konstantin Belousov CommitDate: 2023-04-06 18:04:09 +0000 fdesc_lookup(): no need to vhold the dvp vnode (cherry picked from commit 8d97282a394278d29883e7afa98ed6294efab35e) --- sys/fs/fdescfs/fdesc_vnops.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/fs/fdescfs/fdesc_vnops.c b/sys/fs/fdescfs/fdesc_vnops.c index 81b6690efc80..ae52ef5c3bea 100644 --- a/sys/fs/fdescfs/fdesc_vnops.c +++ b/sys/fs/fdescfs/fdesc_vnops.c @@ -374,13 +374,11 @@ fdesc_lookup(struct vop_lookup_args *ap) * In case we're holding the last reference to the file, the dvp * will be re-acquired. */ - vhold(dvp); VOP_UNLOCK(dvp); fdrop(fp, td); fdropped = true; vn_lock(dvp, LK_RETRY | LK_EXCLUSIVE); - vdrop(dvp); fvp = dvp; if (error == 0 && VN_IS_DOOMED(dvp)) error = ENOENT;