From nobody Fri Sep 16 22:31:29 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MTphK4CLQz4cHl7; Fri, 16 Sep 2022 22:31:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MTphK3nPRz3kt5; Fri, 16 Sep 2022 22:31:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663367489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oSBmaLdJYVrNLZbArUqQxYuHFn2mhdEY106eKFTpcoE=; b=oG0p/7czEKkoCQub3cZDsU3BvX6F4cGzrnrb14xS5sA4YnYOHqY3iU2HkXy2p5ELmoEYSX TlF2yNZAKj4aGmdoDDYyz8d0e4FuiGj9tLCehCgrNbfq8SEg8IjO4nDwA6aX8AvIQQPDJ3 6UWMuX5phrVqhshE3C43vUq8VUc+xVq1FWHOGYvvZ56g5klRZSD/nILmjWQv//2bwmsLCm 2Mbc4ywRRET32LvoCcle2LTVqJGdFV7aEYUNvKZNrgI2VFGeRdE1c5Irqm/6WelGuCKRk8 vRZo/cG97uq3MiZ1E3sU0b0vIkgXTnfWOS6OXSjgmEOSp/ll2Z4l2MXhdxKOUw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MTphK2sKhzW7N; Fri, 16 Sep 2022 22:31:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 28GMVTNv086287; Fri, 16 Sep 2022 22:31:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 28GMVTB9086286; Fri, 16 Sep 2022 22:31:29 GMT (envelope-from git) Date: Fri, 16 Sep 2022 22:31:29 GMT Message-Id: <202209162231.28GMVTB9086286@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Rick Macklem Subject: git: 45de932947c7 - stable/12 - nfscl: Add a console message for session recovery List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: 45de932947c7991cf0b5b58c650efbf27a3f0977 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663367489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oSBmaLdJYVrNLZbArUqQxYuHFn2mhdEY106eKFTpcoE=; b=M0uKP6F+rd3KJAKzyNtSKa3s/fJKziQ+4WiYPE+6X5UGl2DbzH87O3i21pW9XX8zZ+4zMC MCHIxk1LG2aaeuHrnTtqpFGY2Mj1jgILCHOhQbkLdNYB2MlitYL3kyk8davfrsirS5yBEh e8sIqdukQ/EqNSZ/GfykFTZblUZvAvqRr4/sc4e70EdwCT6i0qZF3G2oZIH2+YdiCurXYd MDzdkwAxQRYO1gQMehjv4Ks57ThqPYs8NeQemArIdQAVTrCNzYytQG9HjHrfs1MlsYrdUH 6A+f+CekZBzzpiJP2Ta7+igU5yQC7sSDD+pTHCHamAmGnndxTZ8tSFrHckZMzQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1663367489; a=rsa-sha256; cv=none; b=x4kFaQzl/YZSdDTcRhlaBUtgp7eVZA9sQJb6HDEks/fOt2En5edHiSEFiMEQoP1HbfnKY0 M9eAyIcvGK8vhbQcfMP++Vvs9tC72ilrvBMQtQM7eD+rIsQI02VrXbMoUAVeNrB6NKR+ko 7GW6D5Sg5SU3PRDwM0EWJ20grkGaE+tqvQlJcx5ZkJHmL0F7Q4q79abvmxIanZD+YgJt1o rPKk+ZHF1Jua8l260RUCkJSUHQVqgQVZHkh6H21bbqQ7o2+6nRQcKTPTpXvleNVGM3mqoE b/i4NFCyYD/RN50eOjxn6HLY1UBI4n67Cv7obVOuKH+cou2qhUnUwizHVEVAiA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=45de932947c7991cf0b5b58c650efbf27a3f0977 commit 45de932947c7991cf0b5b58c650efbf27a3f0977 Author: Rick Macklem AuthorDate: 2022-08-28 21:24:39 +0000 Commit: Rick Macklem CommitDate: 2022-09-16 22:28:38 +0000 nfscl: Add a console message for session recovery The NFSv4.1/4.2 client does recovery when it receives a NFSERR_BADSESSION reply from the server. If the server has not rebooted, this is often caused by multiple clients using the same /etc/hostid and, as such, not being recognized as different clients by the server. This trivial patch adds a console message to suggest that client's /etc/hostid's need to be checked for uniqueness. (cherry picked from commit 0685c73cfe88b94d60b1b2ddfdb36c684a008006) --- sys/fs/nfs/nfs_commonkrpc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/fs/nfs/nfs_commonkrpc.c b/sys/fs/nfs/nfs_commonkrpc.c index 115f0f7a01e6..bc38f9aab6b1 100644 --- a/sys/fs/nfs/nfs_commonkrpc.c +++ b/sys/fs/nfs/nfs_commonkrpc.c @@ -1017,6 +1017,10 @@ tryagain: sep = NFSMNT_MDSSESSION(nmp); if (bcmp(sep->nfsess_sessionid, nd->nd_sequence, NFSX_V4SESSIONID) == 0) { + printf("Initiate recovery. If server " + "has not rebooted, " + "check NFS clients for unique " + "/etc/hostid's\n"); /* Initiate recovery. */ sep->nfsess_defunct = 1; NFSCL_DEBUG(1, "Marked defunct\n");