From nobody Fri Sep 16 22:28:57 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MTpdQ01Smz4cHY0; Fri, 16 Sep 2022 22:28:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MTpdP6bSnz3kgF; Fri, 16 Sep 2022 22:28:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663367337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0Al+LDgACEXnhgjTyl9hqcvqpF2dK6l5quGHJrjYlRY=; b=Pon/Wbgnf4jrWPz+iimFEQRjSxJ8iiuerds1tJdXsyuLGFfUAOOl4adnbn0lMV6VCNpL4v 2nDV1znlzlhhFjQGfbpPFxerg/A9RYJ6Vi0cCP4cmCaLRc8ZsJbf6UNs/dLx0J3up2x1d1 dsq01CwG+be75WGxVsdYxihc3T+aQuGf8RxrbmpIUyz0Kb1ce3Cf284aAsdK/rzm9BR/KR nsdUV6pPQAjOx977S/V3ZcE1lKgoV0W212VZ3poP3VI8ETcjD6ZtisyjIJFyyuyQ4JWKg7 XAMXLCw9UTI/PQZebFoUQEmy26H96lX2zwrY8Mc2Suj6T+vlQXJvIJI17h4QzQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MTpdP5YJBzW4R; Fri, 16 Sep 2022 22:28:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 28GMSvlv076265; Fri, 16 Sep 2022 22:28:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 28GMSvTp076264; Fri, 16 Sep 2022 22:28:57 GMT (envelope-from git) Date: Fri, 16 Sep 2022 22:28:57 GMT Message-Id: <202209162228.28GMSvTp076264@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Rick Macklem Subject: git: 5c3ee00b3367 - stable/12 - nfsd: Update console message for no session found List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: 5c3ee00b336769d415a87fd775e1ce917f4d90ff Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663367337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0Al+LDgACEXnhgjTyl9hqcvqpF2dK6l5quGHJrjYlRY=; b=qqMvfmW+cZkCL1lTloc+EOgN1r19qbIif5bjMVKfU8vSfDV0CitlvOC+AICiDBXHN1GCLk Fbxko9SV06IJtZoWgQZ0Vc9N4tdQllN1pg9tBT5qQSHKWVjsFFhVAzRwaeGoOdUWoCZjoZ JqVW72fp7Lx/9PZFaxy5wU5HsSidgjNZcDNhadi3kqtqBlGM9cfYwhyNo+F/zKxaAw7kBM GCRvD4mhi/l0dvrvybZFOAWFxjzjYXxD7zv44h4oNcfvQBon9teYircjJBNWzM+RUxy2uI aKzkrv2r5hwsKQVFxBIU5vmuhT+mxSv4HzKGrjHOtaS8LPT1VL2KXY8PvUHstA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1663367337; a=rsa-sha256; cv=none; b=lMZmfU8VshdMkD1acXe93BIApK2Kv3jiKhv68OKPD4wd6fJqEvyIp9XRm07Ihr8xOgBMvA nhbImdZ5i9wMge64WHyRklQGVqvQML1+THrl1laMKFT9aMSgq6CCNghf1BOthnaoZocbIl 6NyyAefeJAh8ImF1mdefiaKl0Pcll+gg0Z6MAk+Lfo0jHS93soH0RFfeoXxzJSwbm9WA+c 5jG+YPD5Csx6YbaymqqqVzvSkb/NleVGgSstDR1HgPyXskNBuIZn/MuAMxEqeEzKAfP2i5 o6pPrctFgl2RPiFgsRO6KaTZRPl32BAOJqXCm8zL0+zQC19Qj4GObUv7ZEui2g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=5c3ee00b336769d415a87fd775e1ce917f4d90ff commit 5c3ee00b336769d415a87fd775e1ce917f4d90ff Author: Rick Macklem AuthorDate: 2022-08-28 01:31:20 +0000 Commit: Rick Macklem CommitDate: 2022-09-16 22:25:59 +0000 nfsd: Update console message for no session found The NFSv4.1/4.2 server generates a console message that indicates that there is no session. I was until recently perplexed w.r.t. how this could occur. It turns out that the common cause is multiple NFS clients with the same /etc/hostid. The host uuid is used by the FreeBSD NFSv4.1/4.2 client as a unique identifier for the client. If multiple clients use the same host uuid, this indicates to the NFSv4.1/4.2 server that they are the same client and confusion occurs. This trivial patch modifies the console message to suggest that the client's /etc/hostid needs to be checked for uniqueness. (cherry picked from commit b875d4f5ddcbe0ce06f22650dd471b7518546dd6) --- sys/fs/nfsserver/nfs_nfsdstate.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sys/fs/nfsserver/nfs_nfsdstate.c b/sys/fs/nfsserver/nfs_nfsdstate.c index 1ca275c670fc..50bb201a2ca6 100644 --- a/sys/fs/nfsserver/nfs_nfsdstate.c +++ b/sys/fs/nfsserver/nfs_nfsdstate.c @@ -6337,9 +6337,12 @@ nfsrv_cache_session(struct nfsrv_descript *nd, struct mbuf **m) } if (cp != NULL) printf("nfsrv_cache_session: no session " - "IPaddr=%s\n", cp); + "IPaddr=%s, check NFS clients for unique " + "/etc/hostid's\n", cp); else - printf("nfsrv_cache_session: no session\n"); + printf("nfsrv_cache_session: no session, " + "check NFS clients for unique " + "/etc/hostid's\n"); free(buf, M_TEMP); } m_freem(*m);