git: 3a3357995908 - stable/13 - usb(4): Quirk for non-compliant USB devices.
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 03 Sep 2022 10:22:21 UTC
The branch stable/13 has been updated by hselasky:
URL: https://cgit.FreeBSD.org/src/commit/?id=3a3357995908ed5f51af5be43fa5196300ab5cb3
commit 3a3357995908ed5f51af5be43fa5196300ab5cb3
Author: Hans Petter Selasky <hselasky@FreeBSD.org>
AuthorDate: 2022-08-27 06:50:51 +0000
Commit: Hans Petter Selasky <hselasky@FreeBSD.org>
CommitDate: 2022-09-03 10:22:07 +0000
usb(4): Quirk for non-compliant USB devices.
Some non-compliant USB devices do not implement the
clear endpoint halt feature. Silently ignore such
failures, when they at least responded correctly
passing up a valid STALL PID packet.
Tested by: Doug Ambrisko <ambrisko@ambrisko.com>
Sponsored by: NVIDIA Networking
(cherry picked from commit 4e2d8cd3e29bc885567f61ff358f8c9459d621ce)
---
sys/dev/usb/usb_request.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/sys/dev/usb/usb_request.c b/sys/dev/usb/usb_request.c
index a1781f3589a4..c5b370ccd31a 100644
--- a/sys/dev/usb/usb_request.c
+++ b/sys/dev/usb/usb_request.c
@@ -313,6 +313,16 @@ tr_setup:
*/
if (usb_no_cs_fail)
goto tr_transferred;
+
+ /*
+ * Some non-compliant USB devices do not implement the
+ * clear endpoint halt feature. Silently ignore such
+ * devices, when they at least respond correctly
+ * passing up a valid STALL PID packet.
+ */
+ if (error == USB_ERR_STALLED)
+ goto tr_transferred;
+
if (udev->clear_stall_errors == USB_CS_RESET_LIMIT)
goto tr_setup;