git: ed620ade7fbb - stable/13 - Revert "bus.h: rewrite comment describing intr_type"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 18 Oct 2022 14:33:06 UTC
The branch stable/13 has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=ed620ade7fbbc18cc93ebaee0368727e4c2f27c5 commit ed620ade7fbbc18cc93ebaee0368727e4c2f27c5 Author: Mitchell Horne <mhorne@FreeBSD.org> AuthorDate: 2022-10-18 14:13:24 +0000 Commit: Mitchell Horne <mhorne@FreeBSD.org> CommitDate: 2022-10-18 14:13:24 +0000 Revert "bus.h: rewrite comment describing intr_type" This reverts commit fff5fec16b2ec42b0cb357fdbb675353e3126f21. It needs slight modification for stable/13 which does not have collapsed interrupt thread priorities. --- sys/sys/bus.h | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/sys/sys/bus.h b/sys/sys/bus.h index 115f20505bae..430beaecc6d0 100644 --- a/sys/sys/bus.h +++ b/sys/sys/bus.h @@ -251,19 +251,17 @@ typedef void driver_intr_t(void*); /** * @brief Interrupt type bits. + * + * These flags are used both by newbus interrupt + * registration (nexus.c) and also in struct intrec, which defines + * interrupt properties. * - * These flags may be passed by drivers to bus_setup_intr(9) when - * registering a new interrupt handler. The field is overloaded to - * specify both the interrupt's type and any special properties. + * XXX We should probably revisit this and remove the vestiges of the + * spls implicit in names like INTR_TYPE_TTY. In the meantime, don't + * confuse things by renaming them (Grog, 18 July 2000). * - * The INTR_TYPE* bits will be passed to intr_priority(9) to determine - * the scheduling priority of the handler's ithread. Historically, each - * type was assigned a unique scheduling preference, but now only - * INTR_TYPE_CLK receives a default priority higher than other - * interrupts. See sys/priority.h. - * - * Buses may choose to modify or augment these flags as appropriate, - * e.g. nexus may apply INTR_EXCL. + * Buses which do interrupt remapping will want to change their type + * to reflect what sort of devices are underneath. */ enum intr_type { INTR_TYPE_TTY = 1,