From nobody Wed Mar 09 22:59:00 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id DC0D71A08B39; Wed, 9 Mar 2022 22:59:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KDSLD5pT1z4WQj; Wed, 9 Mar 2022 22:59:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646866740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7mlHQqLRNYsAee/Wim2aIschlS+eA5lj8awOMcXeaHg=; b=eSX54bY9+WdZfyxu1rENZc+we6epVgodRujHgtKBQeWh3GiDt7WvchRBKTbWiwhbeYpnjU 2nklliuDVLaSgw/xUU2s5uLPM0Mh9La7w9RNo9m0bhrrGSKHO1w0C+YczTG/EEiy0q7KdI JkhuzGxnhlPwA8UT9uyUGs6N9UMElEzvZTbQGa1y5uRU0SHrePspHdRCvDgUWh8fXmzqYK lvK4PNkxmlHqokbKCL6kFMamHTHRt8gPodeZQKQR/63/w15ZEhNMQpYasAO4qc03pN+AOe gPfMFAA/bZXeT/FaRQCYn85Or/xsVvQ/CmHBws3HhRQ2M0rmG/7ZbgpW6htPLQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A3B5419A20; Wed, 9 Mar 2022 22:59:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 229Mx0SI024051; Wed, 9 Mar 2022 22:59:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 229Mx0kP024050; Wed, 9 Mar 2022 22:59:00 GMT (envelope-from git) Date: Wed, 9 Mar 2022 22:59:00 GMT Message-Id: <202203092259.229Mx0kP024050@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Navdeep Parhar Subject: git: 8824cbace389 - stable/13 - cxgbe(4): dump_devlog should never fail silently. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 8824cbace389c440394bb9ea6c127d0f8f85538b Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646866740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7mlHQqLRNYsAee/Wim2aIschlS+eA5lj8awOMcXeaHg=; b=cIdvReb3IhA9EhvKnpC3Ko2qoo4vIJUuvkOlve7R0hE5h0MR4FRYBagvUeGjWX/hsmB8M5 /QCjZyUoES+2CC/9qhgG9T6Qoh4FKdbVPYLVLZqs+7TlzhTMArHALZfccdgWor30cbYk20 Oy5Uej3Jst/UHxNmE6mjJYNXcYo2H8RZcFenT28ixa+Zx/OMtpoX5CLGxhvKVIO0gOFnfZ TxCTZl07N+ofSJypnca84R6xi2j855HbS1j9iyuXBaLU6DL0aC8Rhy8SBBT1nBoEh6tXDX MLLthohk/iIVdWESqhPQcZnkfTWdrXulga9PAv4aarD7AiupP5yg23HVf6mt1g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646866740; a=rsa-sha256; cv=none; b=wkFo+OumWIDy8UY/T0CKSE4TCloBfFevzp27b/CTkOW/c44D6RcOWOJjYoShXDntQl9wan vbPfhQwyzWFl/YzDZ7pviDKUccvmz3DXh8Yy9l2PF9dzW+lrHBCja/EmAJK+g75Ce3bBAN cnpsMzUZ1I6eeTUHcUy+i+FwLRBCwR7An+uvyb1uh+kkd9RfkhJ7bry/wyFKCl8hALSHNZ nIZEW1caY/VZqP4GhTkUAt65dJpAewLixXFjipAh6t7kooByTAX1wfFlj+zFP1GR3xkF+a uMXb0lXSAoxj9AcH4TFbJONs67m+lNm0FXBaiayHhS02k3pqR2kOgYzgRwZmGg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=8824cbace389c440394bb9ea6c127d0f8f85538b commit 8824cbace389c440394bb9ea6c127d0f8f85538b Author: Navdeep Parhar AuthorDate: 2022-03-07 19:17:05 +0000 Commit: Navdeep Parhar CommitDate: 2022-03-09 22:45:11 +0000 cxgbe(4): dump_devlog should never fail silently. Do the same thing as dump_cimla and log a warning on failure. Sponsored by: Chelsio Communications (cherry picked from commit 9282f04ff0ee89cc4064e510f7fa505cfc890bf0) --- sys/dev/cxgbe/t4_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index a9549abb48bb..2db23d218366 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -9500,8 +9500,11 @@ dump_devlog(struct adapter *sc) int rc; struct sbuf sb; - if (sbuf_new(&sb, NULL, 4096, SBUF_AUTOEXTEND) != &sb) + if (sbuf_new(&sb, NULL, 4096, SBUF_AUTOEXTEND) != &sb) { + log(LOG_DEBUG, "%s: failed to generate devlog dump.\n", + device_get_nameunit(sc->dev)); return; + } rc = sbuf_devlog(sc, &sb, M_NOWAIT); if (rc == 0) { rc = sbuf_finish(&sb);