From nobody Wed Mar 09 20:52:59 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7A7671A14973; Wed, 9 Mar 2022 20:53:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KDPXq4dB9z3QbB; Wed, 9 Mar 2022 20:52:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646859180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CnSjHCn35wasGICwSc61mwec0Zwq2HPN4SAEgri11z4=; b=Zgg1FG79a+JTcNabK/xWm0G+yBpUsPVYRy16I97mO2lQryiUuHSQk4otxefq7nInM0stIY QOgpL0xHK3gEiVjCWv/OixH2Faf9zrdUsddtbcz2/D9pdd50k1bJdiMj+VbumEiE8kd5zJ NM6Ccsf3+A3+skKmFUP2SZvTRiUjgAWFZK7tiHykkCwwLV4HH91Gsjlgb/i4/gXFpxn5oi B+iOG6EmEPkvrtf7zlc6gh6TjcDKvUNTTBI/5htSmXY6gSh608hNnQFQl/0QQa1uQooS/f mqsvuqegELr32NiCvdAR8ezfIFg+Zuot94jDVUMZXgZRVQoSmRjuBadbiJkDWA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3820618029; Wed, 9 Mar 2022 20:52:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 229KqxK4062304; Wed, 9 Mar 2022 20:52:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 229KqxiK062303; Wed, 9 Mar 2022 20:52:59 GMT (envelope-from git) Date: Wed, 9 Mar 2022 20:52:59 GMT Message-Id: <202203092052.229KqxiK062303@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Warner Losh Subject: git: 78564b68723f - stable/13 - Fix "set but not used" in smartpqi. The PCI_MEM macros don't require a physical/absolute address in FreeBSD, but it looks like the calling code might be somewhat portable to other OS's that do require this. Therefore, set the variables to __unused instead of removing the code entirely. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 78564b68723f53bdd854da4e5cedf740289e956e Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646859180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CnSjHCn35wasGICwSc61mwec0Zwq2HPN4SAEgri11z4=; b=McKyhPnbw0oqvVbnMAP7y0UufdPhydqit/RMMj+hvEn7vcJlCPllNbPVMw77/fnREPbkR7 JT3J9qjIIcMQj7QFFYehCFSl/0C3/0Bt8G8/DS2ebiPoaqUD60k5yzlQB+dgYUwiWGCEiT FQkdgpdLnipzcxmgLVCFG4PXahoqD6dwDaVBCMn9z/BK+lRCzbw01P5hzetxZwaFYMeHSm WqHNfLXLGbA83H8ovQQr3mo9qXD3IbH7MiZcVTjfx8imDqgTZbsVkvJ7I5aS+zLucq2nlp 8wm1ehoeJBJEaxbtSe0WMUrnIvJxrI8+PY6f3fMRqCwRxt8+Yi8IZ4UuPFeEqg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646859180; a=rsa-sha256; cv=none; b=ChOOciUA+kCy6wQh5OdADzSL2KcdkCRXlcke2kV4DuO9DelUNZAW3c9RaaiUsxd7aE2jVw xYT4TnbqJtFLZVbO6NdQPFgemfbJ5/mmcUKvD2aXSPUhKK41dVX30e5yUBwJH33t+CErHC YEyDDe1hkuXg9+Gc/ohXB/OvZRHq2D4pj5pQJyHCH8XCsBlunIGRezXPdawHY3Y+ExrCpC K4Ge2q4PndGNMbROuM9ynudyoF4diGQQ5UH3qK0u8XKYY5RbRUlIlbSEMVC1dLGGxkIK3P FpuFDWnsCLiXu8e7LVZZql65fG17dUnrv/vo8sZtlhbjGCnq45SeGU1mnRb6yg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=78564b68723f53bdd854da4e5cedf740289e956e commit 78564b68723f53bdd854da4e5cedf740289e956e Author: Scott Long AuthorDate: 2022-02-26 17:25:43 +0000 Commit: Warner Losh CommitDate: 2022-03-09 20:52:23 +0000 Fix "set but not used" in smartpqi. The PCI_MEM macros don't require a physical/absolute address in FreeBSD, but it looks like the calling code might be somewhat portable to other OS's that do require this. Therefore, set the variables to __unused instead of removing the code entirely. (cherry picked from commit e28289ca83673d753b7e479810947f6a1015ad39) --- sys/dev/smartpqi/smartpqi_helper.c | 2 +- sys/dev/smartpqi/smartpqi_init.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/smartpqi/smartpqi_helper.c b/sys/dev/smartpqi/smartpqi_helper.c index 809677c7cc1e..b49fb2d5a718 100644 --- a/sys/dev/smartpqi/smartpqi_helper.c +++ b/sys/dev/smartpqi/smartpqi_helper.c @@ -98,7 +98,7 @@ void pqisrc_configure_legacy_intx(pqisrc_softstate_t *softs, boolean_t enable_intx) { uint32_t intx_mask; - uint32_t *reg_addr = NULL; + uint32_t *reg_addr __unused; DBG_FUNC("IN\n"); diff --git a/sys/dev/smartpqi/smartpqi_init.c b/sys/dev/smartpqi/smartpqi_init.c index 1f127cff21ec..6a9cca23f72d 100644 --- a/sys/dev/smartpqi/smartpqi_init.c +++ b/sys/dev/smartpqi/smartpqi_init.c @@ -590,7 +590,7 @@ pqisrc_process_config_table(pqisrc_softstate_t *softs) int ret = PQI_STATUS_FAILURE; uint32_t config_table_size; uint32_t section_off; - uint8_t *config_table_abs_addr; + uint8_t *config_table_abs_addr __unused; struct pqi_conf_table *conf_table; struct pqi_conf_table_section_header *section_hdr;