From nobody Sat Mar 05 19:56:48 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4DB1319FF4BB; Sat, 5 Mar 2022 19:56:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K9wTs19h5z3tBk; Sat, 5 Mar 2022 19:56:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646510209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LHm2cMChOjA1Wn2q5GAB7fygeiULJbVIJRVn5pyZbL0=; b=g0+nSVGl9tfmp89Xk0t/H3f+rmgp9M8uKg7gywSL0aqZLe/CMbKHT9agEf+p6R7DCpnefu bPFHlP9jlpT3355G7FvgVB3svVne8pMG8K5JfNHocYHhj3WlZByFVUWfenTN9Rig0iLph7 KAvbgX0dF5UHE//h7klnpbcefeFVswbmRMdmO7viiBUmGH8V7v9zX2JELfpSLDa5FvcMrq VXnelq70PGVN4NqzvRUOS0W8NUGipC6sYgGt93Wwwx6ZzdnsK1fhtvuT9Oo0iLLnSZZ1Bq zscj2PGbaadn4Gsj413Ix7nRvBj7ugUFqfqX+LuJcFXTqMDSiQWOY81cgVBP3g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 03A3425DF2; Sat, 5 Mar 2022 19:56:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 225JumMd018084; Sat, 5 Mar 2022 19:56:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 225JumIR018083; Sat, 5 Mar 2022 19:56:48 GMT (envelope-from git) Date: Sat, 5 Mar 2022 19:56:48 GMT Message-Id: <202203051956.225JumIR018083@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Guzik Subject: git: f85d71e72e1f - stable/13 - cache: retire cache_fast_revlookup sysctl List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: f85d71e72e1fe07ffecdab0d3db9a30214d33f52 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646510209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LHm2cMChOjA1Wn2q5GAB7fygeiULJbVIJRVn5pyZbL0=; b=Ic5E4fLCFseoSdbWkOSzuZvUnxooWGt1bfjx6IJWYRKg1z2ePYI+5CEALujOmfKhlzuiO7 qWDfsM7Yk7h+Q+b86AZsaKoggN6DR7jvXzHNBRs9VU5Uy3UFeBDDazHv0zCoaXvLTpQV+V UgSgyIaouPSUp0TsoOTrQgemOVWNnhAcqOmYto1jZM0oz2JW6tUgUJ8kY4rD6dN5QF7Ody UvnMvZ3otHfy+gX6b78RtawQLXXBkFAoFkgd2ole+MbHajNNHt7OZ9loQegubvRek/1rmc XsUJKgqWYLo9OLkQknzOQLbB51mXJGOkhW2dxFc5HvKtN7evOh2xS4hpl/G1UQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646510209; a=rsa-sha256; cv=none; b=rUwDxDr9wZW4nc+hXGsGL/uMTCzgdIFiZ5XllROjC37tn/ybhBpVcNL6zqCRh8wbWQ91aV +30k4thhtwrcbjbgRx5M4F/tAOy9Z6XiRL2FxrQfaFdNo4hBUyXon7AB7kHRstSVikuf2m MGAWmJum89w2npcnP81kS2fb2exmAQM++V34PBD2XYccHYNtQMiGr6uQebdS7Lm5w1DJrz Jk8eMbN1w/5udUwp/zMf3kdxEmBvV/+0nIi/e24giQUIOQXacTmDMfzWveEwX6DmtCbZgj jHrP6ospq53q6rAD6KNbpYWOjbnodjRVsLRJnyfX+0n5t+xxTs6qh8Q49/rESg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=f85d71e72e1fe07ffecdab0d3db9a30214d33f52 commit f85d71e72e1fe07ffecdab0d3db9a30214d33f52 Author: Mateusz Guzik AuthorDate: 2021-08-23 13:29:42 +0000 Commit: Mateusz Guzik CommitDate: 2022-03-05 19:49:57 +0000 cache: retire cache_fast_revlookup sysctl Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit b65ad70195d874ac28e6e65d2fd8acf5d9a79236) --- sys/kern/vfs_cache.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c index cf2e2dd72e63..7273126a008c 100644 --- a/sys/kern/vfs_cache.c +++ b/sys/kern/vfs_cache.c @@ -253,6 +253,8 @@ SDT_PROBE_DEFINE3(vfs, fplookup, lookup, done, "struct nameidata", "int", "bool" SDT_PROBE_DECLARE(vfs, namei, lookup, entry); SDT_PROBE_DECLARE(vfs, namei, lookup, return); +static char __read_frequently cache_fast_lookup_enabled = true; + /* * This structure describes the elements in the cache of recent * names looked up by namei. @@ -443,10 +445,6 @@ static u_long __exclusive_cache_line numcache;/* number of cache entries allocat struct nchstats nchstats; /* cache effectiveness statistics */ -static bool __read_frequently cache_fast_revlookup = true; -SYSCTL_BOOL(_vfs, OID_AUTO, cache_fast_revlookup, CTLFLAG_RW, - &cache_fast_revlookup, 0, ""); - static bool __read_mostly cache_rename_add = true; SYSCTL_BOOL(_vfs, OID_AUTO, cache_rename_add, CTLFLAG_RW, &cache_rename_add, 0, ""); @@ -3444,7 +3442,7 @@ vn_fullpath_any_smr(struct vnode *vp, struct vnode *rdir, char *buf, VFS_SMR_ASSERT_ENTERED(); - if (!cache_fast_revlookup) { + if (!atomic_load_char(&cache_fast_lookup_enabled)) { vfs_smr_exit(); return (-1); } @@ -3848,7 +3846,6 @@ DB_SHOW_COMMAND(vpath, db_show_vpath) #endif static int cache_fast_lookup = 1; -static char __read_frequently cache_fast_lookup_enabled = true; #define CACHE_FPL_FAILED -2020