From nobody Mon Jul 11 03:15:20 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 65A6B1D0E0A6; Mon, 11 Jul 2022 03:15:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lh8CD2SWVz3jhr; Mon, 11 Jul 2022 03:15:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1657509320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=m6okO6SDpAyNyTA5Bua55rZIcfGCYa/0NS5iIAqZUvM=; b=FKzlevMuMjnlaVu6J5ETcs+h5vZlYaAxc4AaNeoPBFP8IoZ1lnyxAAhfig3g6I0d12YGZe vDSKF6oKZaSP4XphvTrowyPopnKqRXOzdbZm76dORGR+G6V+rUDrshblqSuaEHH84VPkm7 Otkw/3pilMS8feJ3Aj2Po5o608a8H573ap3pdW6Zm2uE8ojNpiXzi2EI3vdvU6/KK976gN HBnwOIGHAm5Ajwawj7w6TcKZ8+fWJ/W2Tdye+PyyOhna3rzqZyqLVqRQ4spj8bQh5H+DAf CHX2OP0kOCSJwSB3CSr7xC9AvLBc/6Hc8FC0nJUiu7N+UmDUHKMwIXx1mIUEYA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Lh8CD1YqdzpN1; Mon, 11 Jul 2022 03:15:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26B3FKSJ046250; Mon, 11 Jul 2022 03:15:20 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26B3FKHk046249; Mon, 11 Jul 2022 03:15:20 GMT (envelope-from git) Date: Mon, 11 Jul 2022 03:15:20 GMT Message-Id: <202207110315.26B3FKHk046249@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Philip Paeps Subject: git: 81fe400fb1e2 - stable/13 - ipmi: do not omit lun in BMC addresses List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: philip X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 81fe400fb1e2d4df46bfb2240711fee56789d3ea Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1657509320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=m6okO6SDpAyNyTA5Bua55rZIcfGCYa/0NS5iIAqZUvM=; b=OaO/u1t6mP/UykMh2tI5ddJh2Www/SnOI4nvWaH05doNYVw82H/BezVnbPCXd9GZ/NSxnO q5TgGA86SSES7iuhRhIxn1Qp6kN3hpIrkahqaO+uNB/bP9DJWtQLcmcszVhB4Lgqs5H+wY YPN/qm/fRuDnWvRIT6ZKhfmRqoD8fBNS01QuJa2dFhOQau5VlQuszNbt08DVzSOfzvZCQv /jq7mtYemh8osZ7f+/AGpcLOHnonfiJ/My1dnK09Qdic9rK8cT3K1oTUjlNJ0GjkxKlZSm qzlCMtcgAlP7Ctx2aHk8w4kM07DmvY7YI6XFJn1JALYvivhgNfh4uPh/iEIEQg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1657509320; a=rsa-sha256; cv=none; b=xJDOuju94nTl+rDO1NDWn/4jULG8YerZMC0kIt76wFECz/dxrquLblDJUslk6p4w37oacG mv8/SPPnG3riAlBNWjb+l6QKpkz5SJKiVs8eBtrhbkyAD3XRMDIWFUG5FkjuQ2GqmIAnI2 J9wPrD97xwslDZffxbZWlYgEGu+rWM8Kyx2jKQ8e5lN45LTDDjJL/qAOdFDsup7hcxKqfn jrAk/gGi8tiVGch8PF/Fp6ECuezlPUmFsBUPW0Ij0q78CNTYLcBET8uOfm2uF2WneEg+Cc fPXqp37NNnIQfPlxmGOhhZgzFyAieSO1RwUBCu90/C5xNYCcopeoNFN9Hi3HDw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by philip: URL: https://cgit.FreeBSD.org/src/commit/?id=81fe400fb1e2d4df46bfb2240711fee56789d3ea commit 81fe400fb1e2d4df46bfb2240711fee56789d3ea Author: Yuri AuthorDate: 2022-07-04 06:29:52 +0000 Commit: Philip Paeps CommitDate: 2022-07-11 03:10:23 +0000 ipmi: do not omit lun in BMC addresses Some systems put sensors on non-0 lun, so we should not omit it. This was the only difference with the Linux driver, where DIMM sensors could be queried, but not on FreeBSD. See this report[1] on the FreeBSD forums: https://forums.freebsd.org/threads/freebsd-cannot-get-dimm-temperature-sensor-value.85166/ Reviewed by: philip Tested by: Andrey Lanin[1] Differential Revision: https://reviews.freebsd.org/D35612 (cherry picked from commit 177f8b3294ef5717060c287fe1206c52ba3ecc53) --- sys/dev/ipmi/ipmi.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sys/dev/ipmi/ipmi.c b/sys/dev/ipmi/ipmi.c index 3666b8dd2033..ec9ede66e556 100644 --- a/sys/dev/ipmi/ipmi.c +++ b/sys/dev/ipmi/ipmi.c @@ -309,9 +309,12 @@ ipmi_ioctl(struct cdev *cdev, u_long cmd, caddr_t data, return (error); if (addr.addr_type == IPMI_SYSTEM_INTERFACE_ADDR_TYPE) { + struct ipmi_system_interface_addr *saddr = + (struct ipmi_system_interface_addr *)&addr; + kreq = ipmi_alloc_request(dev, req->msgid, - IPMI_ADDR(req->msg.netfn, 0), req->msg.cmd, - req->msg.data_len, IPMI_MAX_RX); + IPMI_ADDR(req->msg.netfn, saddr->lun & 0x3), + req->msg.cmd, req->msg.data_len, IPMI_MAX_RX); error = copyin(req->msg.data, kreq->ir_request, req->msg.data_len); if (error) {