From nobody Tue Jan 11 14:28:57 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 784F619494A0; Tue, 11 Jan 2022 14:28:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JYCk14krrz4jM2; Tue, 11 Jan 2022 14:28:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 5D01A1AC31; Tue, 11 Jan 2022 14:28:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 20BESvqU092643; Tue, 11 Jan 2022 14:28:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 20BESvBt092642; Tue, 11 Jan 2022 14:28:57 GMT (envelope-from git) Date: Tue, 11 Jan 2022 14:28:57 GMT Message-Id: <202201111428.20BESvBt092642@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 4905ce27b827 - stable/13 - mvneta: Unconditionally print an error message if mii_attach() fails List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 4905ce27b827fb618171f98e4b0cf17c7fb5f962 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1641911338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hPonoKZOUl/fNjWpEBT3BiNHRFo6tJnVNVjwGgbM3/M=; b=TbGT5xeAUhusJ5hAqsTN4Ao9JxAI6A+Nxe6sP72F9ALm428Dhjq5dT3S8Vj7TktrcwNAbI JvbSZlRgJEtE8cKpon8rUC2xkXhCAlnkuRWxwbtgeLjt3ughidN9V+B8e2tFlr4TB8o3ze cLY8W2zeR5wpVyGINY7MMxRJ/KqTZWJCNCL4ZJusRsGPNDqO79uJUhKQV2QMy0b2EXmU/3 ohRykf+18pdgKAfoEK/52ocrbMUeqVgU1PNlJqdq4Ba3tyedN1v+Su2Bf25KyjMt/ZXrwq 62cOAA5kAkOotUKBI7PjOMv3tT/wHT+ynCqUVKHhyBqLVRXMeOOhuzIirCCeJg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1641911338; a=rsa-sha256; cv=none; b=gxPOmd3XhrcV3alKhxEpldlBPfcljYia2KaDCO4jIhIPX07o1smGAK2njFIfZkuXo/xMYE wUyzoDHuQk1xg7T1EqS9Pl1HzLcHE8uhPkReeMreWmwYQCWBR7mGnDtq15rKK9FfSSFnFo rACMu/zsTcTkOS9+xdAskMauj2NpKGC8ArBYvbyMls+nyXyI0guVSkWpYjo1jx3hTUrDX6 hE9y2LlNOh28jDLG2/r/HqeE0WYJvSTCdrNwQVb7aO+vTdz2fz3MoL7XGtTO/YDdZVcFjL yeu+cxTiFCGuRDod0H2u2FcUmAVWpwsM9ej39QeNJhXoHGECzWvDskmNj7gRKA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=4905ce27b827fb618171f98e4b0cf17c7fb5f962 commit 4905ce27b827fb618171f98e4b0cf17c7fb5f962 Author: Mark Johnston AuthorDate: 2022-01-04 14:42:34 +0000 Commit: Mark Johnston CommitDate: 2022-01-11 14:28:33 +0000 mvneta: Unconditionally print an error message if mii_attach() fails The error message is useful for diagnosing mvneta_attach() failures. (cherry picked from commit ed166a0173247e267c507ebd0ec03cb04aaf49ee) --- sys/dev/neta/if_mvneta.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sys/dev/neta/if_mvneta.c b/sys/dev/neta/if_mvneta.c index debb4a922cbc..8b9135419736 100644 --- a/sys/dev/neta/if_mvneta.c +++ b/sys/dev/neta/if_mvneta.c @@ -735,10 +735,8 @@ mvneta_attach(device_t self) mvneta_mediastatus, BMSR_DEFCAPMASK, sc->phy_addr, MII_OFFSET_ANY, 0); if (error != 0) { - if (bootverbose) { - device_printf(self, - "MII attach failed, error: %d\n", error); - } + device_printf(self, "MII attach failed, error: %d\n", + error); ether_ifdetach(sc->ifp); mvneta_detach(self); return (error);