From nobody Mon Feb 28 06:55:52 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 100BA19D317B; Mon, 28 Feb 2022 06:55:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K6WP54cztz4S0M; Mon, 28 Feb 2022 06:55:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646031354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=miWQe62uvv4g2j0Ocz2RFvo9fJe2LGMWjQIwQTHcHMw=; b=W1xgui59s8tx24rZUoN8fTRssssHQxHT92flORidOSlhYfRn5p9ZgKiNesa30QqNgQTGxS uTQN4VuOyOhDzFHTZHbOfi8Xfv2dlVsSniiwjEs78SXTYTVO6JRFwAt4WCwG+gYveBakZH seBZ37P6KFKnonVbpEgow5SPuPa/IUBqaF/HyYJRQyR1ZeQV99H7EAnTOplHA1f754LVEs VBN16ewRGhUp09wypPda9g86NnwJwUTDZg0DFEwcj34QeEMWp+PbDBt1CiGX1tRw3/dS0+ bFujfitfOVlm5xxIE8rLuvTu2IhwgckqprHsAinjh55ZroOroUv5a62CWq9c0Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B0F0816F80; Mon, 28 Feb 2022 06:55:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 21S6tqtN077993; Mon, 28 Feb 2022 06:55:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 21S6tqbT077992; Mon, 28 Feb 2022 06:55:52 GMT (envelope-from git) Date: Mon, 28 Feb 2022 06:55:52 GMT Message-Id: <202202280655.21S6tqbT077992@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Navdeep Parhar Subject: git: 2f733c60ff46 - stable/13 - cxgbe(4): Avoid unsafe hardware access in the ifmedia ioctls. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 2f733c60ff46f3ce237d6d8b5ac6ebfe6b8645dc Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646031354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=miWQe62uvv4g2j0Ocz2RFvo9fJe2LGMWjQIwQTHcHMw=; b=fa8kfaB63AVYhsDxabTfe7wAB87RRRC4JZDaTwuUu+eWE1l1wreV78P72pLin50qhO5XPH BFfO9dnyYzZg3PM8vGKvi1ThfiEhodmQn1XjigVuiQc7dP7yeuLsu6PqCYwWboOhFWCYzp wt4786dPhzMYHsrt6l3hZKQ1vKgk8oR2/pOvTbNMvFZC6gUz/KhoO3QG4Lcm04iWZzsnm1 4NPTT0ZdDlFbyihtlf6OqXdzNikvHkGK+52RxJK7mQtAW3XabmBI2MQUUaoqLrUidbSE6Q T+r/e186RdcGlUQACEDvzvod6xC+0JfrFbQwoO/hEWxWJr1ucrch7CJ3XA5Q6g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646031354; a=rsa-sha256; cv=none; b=CqkeUdijqAmQNZG9dGhYS1wnx/E8cRNF6fK24q/u3Akn2FPwI0vGNL5fs89ZOzWP0Rza+m 5jiBS3djt1mbsqbREbo6nUePL1v66qcugCNcvikmesnRzZvg0km5IXBZivj2Py0+bi/o6N zycgq//9qz4lvsyNIaeatTaSO2qL73a+i7PNrRODXQBdDd+famE0J8zoYPJRN7XtmT90jN jrTVJkejUaNr+lDoTa2qEVdb5O2yxvjnERqNKF4JOE1+tT99DxPB03kioeQfcDepPNxVev 27B680gttZau3L6/0B6tOaVEGMa/atma88cGQdwU/JANBNt3SVBUxpU7mX1L1A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=2f733c60ff46f3ce237d6d8b5ac6ebfe6b8645dc commit 2f733c60ff46f3ce237d6d8b5ac6ebfe6b8645dc Author: Navdeep Parhar AuthorDate: 2022-02-11 23:37:17 +0000 Commit: Navdeep Parhar CommitDate: 2022-02-28 06:51:32 +0000 cxgbe(4): Avoid unsafe hardware access in the ifmedia ioctls. The hardware is unavailable when the device is suspended or in the middle of a reset. Sponsored by: Chelsio Communications (cherry picked from commit 39a36707bd33b86a115651678028baeb616c8365) --- sys/dev/cxgbe/t4_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index 391bc9de8bfc..e8f82e4aea3b 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -3227,7 +3227,7 @@ cxgbe_media_change(struct ifnet *ifp) if (IFM_OPTIONS(ifm->ifm_media) & IFM_ETH_TXPAUSE) lc->requested_fc |= PAUSE_TX; } - if (pi->up_vis > 0) { + if (pi->up_vis > 0 && !hw_off_limits(sc)) { fixup_link_config(pi); rc = apply_link_config(pi); } @@ -3395,7 +3395,7 @@ cxgbe_media_status(struct ifnet *ifp, struct ifmediareq *ifmr) return; PORT_LOCK(pi); - if (pi->up_vis == 0) { + if (pi->up_vis == 0 && !hw_off_limits(sc)) { /* * If all the interfaces are administratively down the firmware * does not report transceiver changes. Refresh port info here