From nobody Mon Feb 28 06:55:49 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ED6E19D2C71; Mon, 28 Feb 2022 06:55:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K6WP13KfRz4RjQ; Mon, 28 Feb 2022 06:55:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646031350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ok/ylcATIWz3ZlPKtoCN2yVE5vDMpKkt+im6wweFXsM=; b=ict/VpowBhzw3Bybz3EUrjodkjx7ASy4XlzXGrhwN7Wg215OnbV2evB81cfliqFa8b/+6a GkGu7h7FLO7KYOWsCTzRjtcGAeryp8Z+Agspr4n7g0IJIQuYQYDpm22qgDWQt1O0LIUdos CAG9YPj3gjpBzd1qDONGX7UgOnpF72gbJLtQap5BvqFeBZ+Y+MMqTNeqO/1rShHF+WLx1n nT4mkIwK3f6mNAFPS1rsT+gMmuh2rwJL8p+I6B8t3h3GsjtVsGukzOT8uvwwx0ZyNnHjgF 6g+2KbrDfZLb5iyymji+ERKX8OiY7u5NpxpYhEekqsVOxYW1UZzZbM1cNXAgUw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3F70B16C33; Mon, 28 Feb 2022 06:55:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 21S6tnKI077915; Mon, 28 Feb 2022 06:55:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 21S6tnVZ077914; Mon, 28 Feb 2022 06:55:49 GMT (envelope-from git) Date: Mon, 28 Feb 2022 06:55:49 GMT Message-Id: <202202280655.21S6tnVZ077914@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Navdeep Parhar Subject: git: 509de5dc8a15 - stable/13 - cxgbe(4): Do not ignore the return value of ifmedia_ioctl. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 509de5dc8a156dd37b8e4ba88efc08942cf18458 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646031350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ok/ylcATIWz3ZlPKtoCN2yVE5vDMpKkt+im6wweFXsM=; b=Qrx1cyxn/hFIJEZIn48PQvEIXDdx62IBq6m9XdCSvHgQ2btUT6vVGOBul2QL+CyhelXU9x WitrDUIeJlmvc7MMCvL6H7vt2HiGBm/rNeqIbbrEGCjkc3xSVHESGrFU8Ao0g4Tbx6FBQB HR+rhQkRk+ndW4JtgWhpH847k9gBuGGYxat6HXxc92Z/afcYGqc5fiD/9eBAp61hHauixM LwefSMO8MDRhs/2cRN8an9ZA4XDzf/SV24/65n0DDf2Td07ottFbA4aNROYXO5dczgiqa5 5hl7mfe4CBPp3UtlJ+I1i73M68efdmsoKB7rsQ+IPk0k9EDRcK4wJJev/24G9A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646031350; a=rsa-sha256; cv=none; b=GAvk3FMjGZw5aQiuN1Pl1/bsciUoC5nFY0zWiw9vOhUuk7NKBC+j/5sSGCywEW1SH9beK/ hFpFHESPElakqXe6uDcsS+wWn6gWX8aUAq111sSKVJdj20jyIEUPnnAtGGd1au9MdHO7Z/ fSnEImcMagwSOYcuyTj4WpB1GFui568zJMFY4iPfx8zGui8EsQJXvUnye9EtRnzdWVYgTc H6LOZTKGlEWKEU/QqUqXbuwdtyHLSrOSqAsn8L6oYw2rNKFBDAmAs6vQmTWgd8K3vUsjpV T2QPl+SpiNuQc5AQFSKrqBHJIuK91jPRQ8Bqc7+qKKG/ymNhhf10QNoBsVh5zg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=509de5dc8a156dd37b8e4ba88efc08942cf18458 commit 509de5dc8a156dd37b8e4ba88efc08942cf18458 Author: Navdeep Parhar AuthorDate: 2022-01-10 21:01:51 +0000 Commit: Navdeep Parhar CommitDate: 2022-02-28 06:50:03 +0000 cxgbe(4): Do not ignore the return value of ifmedia_ioctl. This ensures that the driver reports an error instead of failing silently when an invalid media is requested. Reported by: Suhas Lokesha @ Chelsio Sponsored by: Chelsio Communications (cherry picked from commit cdd7fe04cb803d49a2fb6389be70f4378ae3ca3b) --- sys/dev/cxgbe/t4_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index b45f910afe88..078515833045 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -2881,7 +2881,7 @@ fail: case SIOCSIFMEDIA: case SIOCGIFMEDIA: case SIOCGIFXMEDIA: - ifmedia_ioctl(ifp, ifr, &pi->media, cmd); + rc = ifmedia_ioctl(ifp, ifr, &pi->media, cmd); break; case SIOCGI2C: {