From nobody Mon Feb 28 06:55:40 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E0F5419D25DA; Mon, 28 Feb 2022 06:55:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K6WNs32rkz4Rqj; Mon, 28 Feb 2022 06:55:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646031341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zJzdjeFLwgBYl2xyIOWn+V1exC3Vwf80zevfNYRNx7Y=; b=dTWaoz5tx4BnbIZ7uAqaCYP0QKr1ob5a0NpeUwnhOc+vhoSQ20U2YQvvNypWxea4vEKNX3 QCUgosCvp0zCulwaarXtUyZs2EhLcJuvA1HNmlWRnlKDrRTwNKjn/cNRZWiZVvB+eJxuix DZ1AIYVvXp0NGBBRbG86RC4Fjlk6hJAS8a06B8kOccNY0d6kcqAGKAOkk6ins1frN99SGw IvEysK0SNZoKcNRPE8pSjoJH5DFYa2Af90dc/BjQ89XgBusiaqMwrktTgGOXuIUW7JBwIK uHoNUw6pxOZyROAwHgwQX0q+KvgicihE1Y8OTiBG5q+HU/AV7vGeZ2DylqhUiA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0AA241657D; Mon, 28 Feb 2022 06:55:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 21S6teHa077741; Mon, 28 Feb 2022 06:55:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 21S6tePN077740; Mon, 28 Feb 2022 06:55:40 GMT (envelope-from git) Date: Mon, 28 Feb 2022 06:55:40 GMT Message-Id: <202202280655.21S6tePN077740@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Navdeep Parhar Subject: git: f4592cd2a4b0 - stable/13 - cxgbe(4): Keep link configuration compatible with really old firmwares. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: f4592cd2a4b040cdc279bc53d0a5905c350e7090 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646031341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zJzdjeFLwgBYl2xyIOWn+V1exC3Vwf80zevfNYRNx7Y=; b=fFXAT8D1r4XEQBTVR+lGaCL9HzDrTJkaM85RjM8pXUQ5FgEbVRmYgnD5CuK/4yvN28uH9g vnwrC1DqFCgskHuSLL2yynhJPPdjfLFBlXZFUPD8Aj8LU/E5f2HRNz23i1Fij+gDuK1Gax gMRaBzlSZ8xwNaVvK5BaB3//dmK+vVDhNivdkd5kPpv0de/aiekr94iYU52OsSf8wc2nHn clH4yq1Poy5NQ7/MTrvh53TYsmsanhu6zaZQCasoqqoobFjWxnDy4OWBQWK0YB8KiOPM8d R7rpTRoABvDlaLbVByMweFuDMeu/fiYnJHXj7QjqE254rIAQ0R9m3R2V/95o4g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646031341; a=rsa-sha256; cv=none; b=KnI9yjSFngegrTm4LnBAkUiD5Q1iSiqxRMp4R1tZGOA26fPctVOm4RnW9RrtyvNSAL+ezS 4G2F4gbT8Mgvw6Dq7c87IbrE0a3RGkhNITFkWDznM7B8HBv8KVtnmAYwr5+8dXrohfxtEt qV6NxLfv9oBjs0LTcKcCwale+7yqOuFnzevaRMmbhCvl4i4QTxlrIa2hxGmmT42Jq0zfSV vtUbX+3sh8CC9R9K/hNLYq8ncqfWVOoP56gh0hEk+934PI6gClrWQB1Q57uDj3WZBBfpIU J/PTcXB36/4SmgN0XFdYIifln9EU/lHVMyWqhfHxHLGTsJfzvF2D0tbq+S18bw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=f4592cd2a4b040cdc279bc53d0a5905c350e7090 commit f4592cd2a4b040cdc279bc53d0a5905c350e7090 Author: Navdeep Parhar AuthorDate: 2021-11-11 00:10:41 +0000 Commit: Navdeep Parhar CommitDate: 2022-02-28 06:45:20 +0000 cxgbe(4): Keep link configuration compatible with really old firmwares. Sponsored by: Chelsio Communications (cherry picked from commit 8e76bae0b72e53da80c48ba138b1cfd712724df4) --- sys/dev/cxgbe/common/t4_hw.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sys/dev/cxgbe/common/t4_hw.c b/sys/dev/cxgbe/common/t4_hw.c index d6f85a1fcd34..e2b55dc71eba 100644 --- a/sys/dev/cxgbe/common/t4_hw.c +++ b/sys/dev/cxgbe/common/t4_hw.c @@ -3959,6 +3959,14 @@ int t4_link_l1cfg(struct adapter *adap, unsigned int mbox, unsigned int port, if (lc->requested_fec & FEC_MODULE) fec |= fec_to_fwcap(lc->fec_hint); } + + /* + * This is for compatibility with old firmwares. The original + * way to request NO_FEC was to not set any of the FEC bits. New + * firmwares understand this too. + */ + if (fec == FW_PORT_CAP32_FEC_NO_FEC) + fec = 0; } /* Force AN on for BT cards. */