Re: git: 5fa005e91560 - stable/13 - exec: Reimplement stack address randomization

On Wed, Feb 16, 2022 at 07:30:23PM +0100, Helge Oldach wrote:
> Mark Johnston wrote on Wed, 16 Feb 2022 18:59:15 +0100 (CET):
> > The branch stable/13 has been updated by markj:
> > 
> > URL: https://cgit.FreeBSD.org/src/commit/?id=5fa005e91560785dad5183db080209447afde3c2
> > 
> > commit 5fa005e91560785dad5183db080209447afde3c2
> > Author:     Mark Johnston <markj@FreeBSD.org>
> > AuthorDate: 2022-01-17 16:42:56 +0000
> > Commit:     Mark Johnston <markj@FreeBSD.org>
> > CommitDate: 2022-02-16 16:55:03 +0000
> > 
> >     exec: Reimplement stack address randomization
> >     
> 
> --- kern_exec.o ---
> cc -target x86_64-unknown-freebsd13.0 --sysroot=/usr/obj/usr/src/amd64.amd64/tmp -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -c -O2 -pipe  -fno-strict-aliasing  -g -nostdinc  -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -I/usr/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common    -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MD  -MF.depend.kern_exec.o -MTkern_exec.o -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error=tautological-compare -Wno-error=empty-body -Wno-error=parentheses-equality -Wno-error=unused-function -Wno-error=pointer-sign -Wno-error=shift-negative-value -Wno-address-of-packed-member -Wno-error=unused-but-set-variable -Wno-format-zero-length   -mno-aes -mno-avx  -std=iso9899:1999 -Werror  /usr/src/sys/kern/kern_exec.c
> /usr/src/sys/kern/kern_exec.c:1197:9: error: returning 'void' from a function with incompatible result type 'int'
>         return (sv->sv_onexec != NULL ? sv->sv_onexec(p, imgp) : 0);

Thanks, fixed now.  I hit this when testing but failed to commit the
fixups before pushing.