From nobody Sat Feb 12 19:10:33 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D235B19B52C5; Sat, 12 Feb 2022 19:10:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Jx0S955rHz3JlZ; Sat, 12 Feb 2022 19:10:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644693033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/31Qjx4ku24ZoXwvNa2qTe2SJixnQLnO45uMdrOEQ7o=; b=NQ7Zzf2drwYtcGSr8eMAnHGidaMDHQk7ZyLXKa5A9Dgm5NqYQP1BsCV6mcmVzz4w7a5/8a DcKMEaoK3Sqerx7rXBos42OBMNMokt+Q2+6wzjwYcdvpkmTvXRQYvPuJtMBjZhmn7x7dDk 8PnT/Cf01mUamhEUM0G9qPJxgEvny62IXQjIGYxo5fLVLCkob0iGydBNUcQ6urP5THHBNj 2wtV0ev8bYH9xK7Wn9etAJVUKIRmcRaoyGKikNSGc8ONZSR75obIrOUcxqVWbaR0ynyupJ onVGwrsLdyNTqoZ5Ut7bbYvC6diIUj3HTCrf2MuZb72D28HHn9Hc0vsZRdqRmA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8EFE8541A; Sat, 12 Feb 2022 19:10:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 21CJAXbY038952; Sat, 12 Feb 2022 19:10:33 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 21CJAXKi038951; Sat, 12 Feb 2022 19:10:33 GMT (envelope-from git) Date: Sat, 12 Feb 2022 19:10:33 GMT Message-Id: <202202121910.21CJAXKi038951@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: a60685ffbc74 - stable/13 - vnic: add TODO list List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: a60685ffbc743e417972390ce6674ce38918a115 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644693033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/31Qjx4ku24ZoXwvNa2qTe2SJixnQLnO45uMdrOEQ7o=; b=Xact59lNTTHe0QIsXpopLNprfp1ZRhF2woGatT9M8DGHKWFCjEgjUWOZPUIStp/pwzhF9o 5ZjOOnIydiUrH2H5LQ4HPkspNHgn+lxedKIF3hV8TqETHpe73EPEmHGHzKIXhul6U9PvK6 ixWTsJL3pjG86Kn61eqZuT4KHQl4M7BAtZHxpIi4/utvODWnGQXNGo4vmq46izFP8jLXy6 mtVVGoS0+v48rSATN+s54XkuNkgdxRLGgXEhbRllZG/puDS+dYCAisCk9UnWiKwsv9rnNn veXLKeKJ+at65cHOXMA+apBdMLKc2WelHbAg1NzwtwHqTfsf32B+GZN7DEPcHw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1644693033; a=rsa-sha256; cv=none; b=t7b/kTfR0qDDmXe0OcARcCCrKti/nT4YVSsr5IrcP1CTwvK2JgKbT95cbqgNHnSNAIyOyW qAcHP/kMWyk2s6o/Q5pa+hJoy0WARkdvzt1l6hQmFV79uZGfuHq6kphvN/v+smcU8nAOs5 Spp28cOgl3jUIBIox9aPLJQPiKPF+wx0mmK45DdYe7Q83am7GMS2bsZ++LCtW7ELUgXQRT 1DCTHoeqdlzOjZWg2ifm2qQb0yDeBKa2qzPVZd1ADjT1OpdS3telvsdfx4iVFlyg7kmkfp 0tZL0EA3Wp6yHfl8Ujajnp/HqXDq0eHYMM25VxTv4FxF0unOtVEO8+spgfK83g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=a60685ffbc743e417972390ce6674ce38918a115 commit a60685ffbc743e417972390ce6674ce38918a115 Author: Ed Maste AuthorDate: 2021-07-27 21:51:21 +0000 Commit: Ed Maste CommitDate: 2022-02-12 19:09:52 +0000 vnic: add TODO list - non-promisc mode - multicast filter support Also drop ARM64TODO comments; this is an issue with this specific driver, not a general arm64 issue. PR: 223575 PR: 223573 (cherry picked from commit 941650aae9762293f4c63788ddb17e0114828813) (cherry picked from commit 29e9b487c1d427409a8bf1f893bc71a57c76f4b0) --- sys/dev/vnic/nic_main.c | 12 ++++++++++++ sys/dev/vnic/nicvf_main.c | 6 ++---- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/sys/dev/vnic/nic_main.c b/sys/dev/vnic/nic_main.c index 8e6aa60f6ca8..08559442dbc7 100644 --- a/sys/dev/vnic/nic_main.c +++ b/sys/dev/vnic/nic_main.c @@ -27,6 +27,18 @@ * */ +/* + * Marvell/Cavium ThunderX vnic/bgx network controller + * + * UNIMPLEMENTED FEATURES + * ---------------------- + * A number of features supported by the hardware are not yet implemented in + * this driver: + * + * - PR223573 multicast rx filter + * - PR223575 non-promiscuous mode (driver currently forces promisc) + */ + #include __FBSDID("$FreeBSD$"); diff --git a/sys/dev/vnic/nicvf_main.c b/sys/dev/vnic/nicvf_main.c index c8b088dee1fa..73591a0b161a 100644 --- a/sys/dev/vnic/nicvf_main.c +++ b/sys/dev/vnic/nicvf_main.c @@ -485,16 +485,14 @@ nicvf_if_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data) if (if_getdrvflags(ifp) & IFF_DRV_RUNNING) { if ((flags ^ nic->if_flags) & IFF_PROMISC) { /* Change promiscous mode */ -#if 0 - /* ARM64TODO */ +#if 0 /* XXX* / nicvf_set_promiscous(nic); #endif } if ((flags ^ nic->if_flags) & IFF_ALLMULTI) { /* Change multicasting settings */ -#if 0 - /* ARM64TODO */ +#if 0 /* XXX */ nicvf_set_multicast(nic); #endif }