From nobody Thu Dec 29 17:02:04 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NjZSD3P1zz2kfNv; Thu, 29 Dec 2022 17:02:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NjZSD2lb3z4Mvj; Thu, 29 Dec 2022 17:02:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672333324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Db3QF8pO0YuWX4xRYTN/itwpEwLC9J4bYFcQ/odGy1o=; b=kpqxoi2FXD/5vKVLlYS+4zZcoQ7fvoCciBrUJR7l7ibaHgwJOlKxsZqbVOp0eN2Sd1cT6N yf386Y+hptMSEaei6j7UMIcFgcjF6sS+FOt85kFXRtBwd8DXKyCaq22p9oSbGBB99vZHAl eLi46SmCKn9Gp7KofDO7tDddw+67yk8SYCFKIZV9upHxdb1LpX14pnKWrAGnFcF9muBF8z ONnSpAw8dR6/KMya2LJL04wDKSJJ9lhsc92n/HH5cax7dwtXm4MupUlMmTV5p7bWzYtbOQ Ufnpog5u/Ek2t+cc9ZvyoURVdNwvU006MpdCXmEpQ1bhJ5EofLvknKdTODi/zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672333324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Db3QF8pO0YuWX4xRYTN/itwpEwLC9J4bYFcQ/odGy1o=; b=UIMQa65jQswmmArvcKILhmAddjG+ZKvZSvkfYk7xqRxwwHBcC4vC9GP3EZYy5wWaPwGUa/ vE3CXqxTMOfm3XbAYnFxjcjx1j3d75td3gTErHLlovEqXZ5mwjySWeKNG7qTSZkyFxHSEj IHdHoRWzXwr37JrkR2iqGRNS6nWV8G3rY8RdkBaX4Cw6sHerCPISlpxrbBR/JS1ZlXdhul SM2RsPqro7kzETu4Acp7AQ/1lQNL6QQKHQGxFemKlobGhDBrmnCOgBUjR4l180sse9sQgm 3b5ioCaQ4nToIjT717dbq0xFH96veC2KmQ/bvxOr8aKEP01Y4YpdAF3smxHsAA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1672333324; a=rsa-sha256; cv=none; b=QuqMosUMbzh8yqeCdHCjwVPChpmbCKQiUHmzQeifsaU+CU6kEkdT8tlwSj2nFY/ApvarjH FcaMFfNxyWnr1x/IBfhLTbIDO10GDiwSwOtVF6trIj3896ECvliluA/ApQgv/vnoQzqiMV Q8OnD2YB/9yglD/C3R3sM1RvqLWBbtEKF/MqPh21VNqqBycbfLCdre/otXt+CF5vjJLlql u02XmsR5TLcCRQHvVtfHiSYLgaM66XdZcKYglg0IGFYQ9B3KouVx06rOcBYGZgYcTNZdPh 6mqyate6rqbaJX7W3eUtaRJeO93OZOtIQnXbz/gOqTIez7t6FoXpQ5dxj7KTbQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NjZSD1pMgzc1b; Thu, 29 Dec 2022 17:02:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2BTH24UT017921; Thu, 29 Dec 2022 17:02:04 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2BTH24dl017920; Thu, 29 Dec 2022 17:02:04 GMT (envelope-from git) Date: Thu, 29 Dec 2022 17:02:04 GMT Message-Id: <202212291702.2BTH24dl017920@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Rene Ladan Subject: git: bcd220664443 - stable/12 - gpioevents: add support for pull-down and floating input pins. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rene X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: bcd22066444374e61025c372668928ad20c8bf4a Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by rene (doc, ports committer): URL: https://cgit.FreeBSD.org/src/commit/?id=bcd22066444374e61025c372668928ad20c8bf4a commit bcd22066444374e61025c372668928ad20c8bf4a Author: Rene Ladan AuthorDate: 2022-12-21 21:24:11 +0000 Commit: Rene Ladan CommitDate: 2022-12-29 17:01:36 +0000 gpioevents: add support for pull-down and floating input pins. The pin-mode (ft, pd, pu for floating, pull-down, pull-up) is specified after the intr-config (no, eb, ef, er) for each pin. Tested on my Raspberry Pi 1B. PR: 268504 Approved by: manu MFC after: 1 week (cherry picked from commit 453db42291a3179a51b9bf41ca7dbc0a5298bffa) gpioevents: fix some white-space errors Fixes: 453db42291a3 - gpioevents: add support for pull-down and floating input pins. Approved by: manu (implicit) MFC after: 1 week (cherry picked from commit e2f3742ab8b10ba5ec4dc190c5b64e9151bb0d57) --- tools/test/gpioevents/gpioevents.c | 47 +++++++++++++++++++++++++++++++++----- 1 file changed, 41 insertions(+), 6 deletions(-) diff --git a/tools/test/gpioevents/gpioevents.c b/tools/test/gpioevents/gpioevents.c index 20d18257f4a8..9beffa740875 100644 --- a/tools/test/gpioevents/gpioevents.c +++ b/tools/test/gpioevents/gpioevents.c @@ -66,7 +66,7 @@ static void usage() { fprintf(stderr, "usage: %s [-f ctldev] [-m method] [-s] [-n] [-S] [-u]" - "[-t timeout] [-d delay-usec] pin intr-config [pin intr-config ...]\n\n", + "[-t timeout] [-d delay-usec] pin intr-config pin-mode [pin intr-config pin-mode ...]\n\n", getprogname()); fprintf(stderr, " -d delay before each call to read/poll/select/etc\n"); fprintf(stderr, " -n Non-blocking IO\n"); @@ -85,7 +85,11 @@ usage() fprintf(stderr, " no\t no interrupt\n"); fprintf(stderr, " er\t edge rising\n"); fprintf(stderr, " ef\t edge falling\n"); - fprintf(stderr, " eb\t edge both\n"); + fprintf(stderr, " eb\t edge both\n\n"); + fprintf(stderr, "Possible options for pin-mode:\n\n"); + fprintf(stderr, " ft\t floating\n"); + fprintf(stderr, " pd\t pull-down\n"); + fprintf(stderr, " pu\t pull-up\n"); } static void @@ -539,8 +543,15 @@ main(int argc, char *argv[]) return EXIT_FAILURE; } - if (argc % 2 == 1) { - fprintf(stderr, "%s: Invalid number of pin intr-conf pairs.\n", + if (argc == 1) { + fprintf(stderr, "%s: No trigger type specified.\n", + getprogname()); + usage(); + return EXIT_FAILURE; + } + + if (argc % 3 != 0) { + fprintf(stderr, "%s: Invalid number of (pin intr-conf mode) triplets.\n", getprogname()); usage(); return EXIT_FAILURE; @@ -567,7 +578,7 @@ main(int argc, char *argv[]) err(EXIT_FAILURE, "cannot set O_NONBLOCK on %s", file); } - for (int i = 0; i <= argc - 2; i += 2) { + for (int i = 0; i <= argc - 3; i += 3) { errno = 0; pin_config.g_pin = strtol(argv[i], NULL, 10); @@ -604,7 +615,31 @@ main(int argc, char *argv[]) return EXIT_FAILURE; } - pin_config.g_flags |= GPIO_PIN_INPUT | GPIO_PIN_PULLUP; + if (strnlen(argv[i + 2], 2) < 2) { + fprintf(stderr, "%s: Invalid pin mode (argument " + "too short).\n", getprogname()); + usage(); + return EXIT_FAILURE; + } + + switch((argv[i + 2][0] << 8) + argv[i + 2][1]) { + case ('f' << 8) + 't': + /* no changes to pin_config */ + break; + case ('p' << 8) + 'd': + pin_config.g_flags |= GPIO_PIN_PULLDOWN; + break; + case ('p' << 8) + 'u': + pin_config.g_flags |= GPIO_PIN_PULLUP; + break; + default: + fprintf(stderr, "%s: Invalid pin mode.\n", + getprogname()); + usage(); + return EXIT_FAILURE; + } + + pin_config.g_flags |= GPIO_PIN_INPUT; res = gpio_pin_set_flags(handle, &pin_config); if (res < 0)