From nobody Tue Aug 09 20:00:30 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M2P7f4zCJz3j89t; Tue, 9 Aug 2022 20:00:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M2P7f4Tj6z3k42; Tue, 9 Aug 2022 20:00:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660075230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CqofrXZAvt4hUUp+Qa8wfXltePUaPrb/6MVKN2pk2+Q=; b=EXlVMAEJB1nuodLeyI1V4WYVHQDtglwnsNUWcynh9lbvVI4EPxC1Gk9BYbPgMFw3AnsoTR HkeRGqkbIzoN7EryIXH/aPYmuGFOsTS/d8mK3Fu3VGj7NJZebXSmVfrI8yaz7UPh8MLxPm lyzlpVMjMk5Ms2KdE2bj/zxpvO0JICpa0g9C/dgsIGJsFp3KyPktUflAhWQvtJLxJ2ZW2z HfWmXFnJDSfuPVIR5oCSwuc9YekMn4Va19HhWlPJV1/2CmbQ3M9m2YSX27YId/T8LhFOpI acqq50F+EM38sszI+px93qqudH8Ei10abWHt1hwWHysMynDzSKuItrC8Uw16UQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4M2P7f3bS4zkMN; Tue, 9 Aug 2022 20:00:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 279K0U3i031040; Tue, 9 Aug 2022 20:00:30 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 279K0UZY031039; Tue, 9 Aug 2022 20:00:30 GMT (envelope-from git) Date: Tue, 9 Aug 2022 20:00:30 GMT Message-Id: <202208092000.279K0UZY031039@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 70a2cf7bb2e0 - releng/13.0 - lib9p: Remove potential buffer overwrite in l9p_puqids() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/13.0 X-Git-Reftype: branch X-Git-Commit: 70a2cf7bb2e0010805dde782ce7a1fe325d6f7e2 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660075230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CqofrXZAvt4hUUp+Qa8wfXltePUaPrb/6MVKN2pk2+Q=; b=oIpkY1y2WIpBWYUQzvOi4OzWwjDHcfALoYLQHP33XV/6tNSAgbuiyN0kMjbJxaZUeAzZS8 cXEgTUfWWsuF3Bi/tv+RaKlgoq/wqfyJQXHz90WB0xPvN77ekz9wLHGZ9QPtcidLGX/ja/ NbzUOP3NkxePjxFY4FC3+SH1Z3MT5KHbESt2NERo09wb7Q3mKNA1uDHHjedF2EPwcxrz0s HzEwM9aufQ4H4RfI4tx6zH7pV1NFB5s1cfgpnv6hrLLgJQSI32EL1zQtuDvlbKo0hfvxMc Nu4ktBKG2p6Z5cWsq1ZWrXXyBbkm0CdjUWKDmtq2XC/1U5MZi6o6w/jAA3Bd5Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1660075230; a=rsa-sha256; cv=none; b=W6RB7I4+lixJrlTBkKesxBbv7poS1ik0DJQWZoMQ6dFacd7Zrwkz6n2k2eAoRZPKD//v3N ZbGSo27METHaoB31bJMdChKQxR4Zq/vi122sbhWGKsBAv1+9TdlbfdOE4tB2qAEfsfOKrn wTUu0lYfpfXnDQY9QlJSdjxgASvm3C+4wh9Gk4uD6TUQlo2sGhcRnJ1bbZIdKFTfP/g418 h5ZZ0TkCEaD4tcNb6klPQ9FmG7qx0n9j/NtN3CzhoJSxEuIg4eQJZz4EBq/RmEBJPFJTsv v4tF8m4JV/J0Uv1VSIy5szwN7txHPSSNvbsKKILQkvZvjlDOPe710pR1Cr7aOg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch releng/13.0 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=70a2cf7bb2e0010805dde782ce7a1fe325d6f7e2 commit 70a2cf7bb2e0010805dde782ce7a1fe325d6f7e2 Author: Konrad Sewiłło-Jopek AuthorDate: 2022-08-08 16:25:48 +0000 Commit: Mark Johnston CommitDate: 2022-08-09 20:00:03 +0000 lib9p: Remove potential buffer overwrite in l9p_puqids() Structure l9p_f_wralk reserves at most L9P_MAX_WELEM entries and that number actually set the maximum we can safely use. Approved by: so Security: FreeBSD-SA-22:12.lib9p PR: 265385 Reviewed by: markj (cherry picked from commit 2dd83b3f0507fc7bc64b908fb88f285a3b9663c8) (cherry picked from commit c536045c51da78a85138e963d3b7e13a547713c9) --- contrib/lib9p/pack.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/contrib/lib9p/pack.c b/contrib/lib9p/pack.c index 88f0ccb4ad73..cf0ae9111b76 100644 --- a/contrib/lib9p/pack.c +++ b/contrib/lib9p/pack.c @@ -343,13 +343,17 @@ l9p_puqids(struct l9p_message *msg, uint16_t *num, struct l9p_qid *qids) ssize_t ret, r; r = l9p_pu16(msg, num); - if (r > 0) { - for (i = 0, lim = *num; i < lim; i++) { - ret = l9p_puqid(msg, &qids[i]); - if (ret < 0) - return (-1); - r += ret; - } + if (r <= 0) + return (r); + + if (*num > L9P_MAX_WELEM) + return (-1); + + for (i = 0, lim = *num; i < lim; i++) { + ret = l9p_puqid(msg, &qids[i]); + if (ret < 0) + return (-1); + r += ret; } return (r); }