From nobody Mon Aug 01 05:45:38 2022 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Lx6Xz2Dczz4XVFV; Mon, 1 Aug 2022 05:45:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lx6Xz1l3cz3CnG; Mon, 1 Aug 2022 05:45:39 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659332739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=k5uH6vybwfk9dkQIo5ZAMjBTnRAxyiCaUVPzraDmfu0=; b=E3dTGZE8XgJUPVu43v2MpI+9GdH59hPqVF18xwsIqMnlW0S2Rfq77pbpclckOF2wftkPrO dCXXnuwEz2vdYg8Uax8W/GDUVfILMDrMm12fB1AAjUTLgKq9tmHXFIG5aiMyc8cHyzd6Sy 6uj6Zg1dftN5LYZf7feABn7O01j4HQZmYuMB1uv05kTphsCp4MWVvxOyN61Id6AEua4WeZ jfKigl95qX69u1oCr3xCU5ktYHO8DTEuceNZZe2AiI1ErArYAJG+LOoLP4hIfVVqSkb+QS oT1xYWr5CzdHg/zAZ0O0xb07wmDAIZo3KEwSBmylKy/HVllbK5mt8vk4UiqkRg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Lx6Xz0TTrzMl8; Mon, 1 Aug 2022 05:45:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2715jcNh034687; Mon, 1 Aug 2022 05:45:38 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2715jclw034686; Mon, 1 Aug 2022 05:45:38 GMT (envelope-from git) Date: Mon, 1 Aug 2022 05:45:38 GMT Message-Id: <202208010545.2715jclw034686@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Doug Moore Subject: git: 882c35e41275 - stable/13 - rb_tree: silence coverity List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dougm X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 882c35e41275c1eb98a5a8f3444ac9f09f292e3c Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659332739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=k5uH6vybwfk9dkQIo5ZAMjBTnRAxyiCaUVPzraDmfu0=; b=VUVBm8yFDaUZJ6CjDeqhPR79igguzOrmnmIUuJX4/+2aFyvz6aZJ9jRJG5uAf9G5bhRrXW DibfnSRrZxPnhKFagIJSo9X8JHZZKPSvmVeTdfpXZbv37xJOz1J4frH3p+lm/3VMRcZ2hU DNJi+PfH+4HK0+zkaYW+OwIhVqtHzeC2lNUL4C89kOYq1UbjJyYUbHsO6aGg8yv609IHYQ XL8Zhml3tlghltC2WrGVQsyXG/Oty1f9YLirzrUEeEVJWOf/IjvQDXSr3CYvjoxNlHr2Ry BswWdKO4i0wZFQ9IWCMTF1mkNuHWNORtLxDkg2FjLPNeODOIdhp33qBnAMUaEQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1659332739; a=rsa-sha256; cv=none; b=fhBnnm3EljGGkMW+oFRszjtYRMncgkYKct0hR9vD8E2wNYY7Vioy74dCVhZUR7eBTEfk2v FabTp7X1f5KdF8TIErpNeAY/X5QIx3vUjyQxOI2wQoRxEkT/XLYXGLNykJisT//DRzgVXf X1MKe4O7sl0CE0rGT/IAhQWIAK+MYhFwiDf1M4IxEN7mqU0Q1uxAP82Xay7I2yDLSSYVOu HJEYAvDzEpiFeJUXtiuvIT/6b4cw+b5FipqKhdyfwhgkixs6JMnwlNX3LFumHPS7y3A82F FvqdTkbS6y0dzYhR9kXzqcs9gyugbECmcpuCrqWXjzMxNK/oRl00e/dI5p+tjw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by dougm: URL: https://cgit.FreeBSD.org/src/commit/?id=882c35e41275c1eb98a5a8f3444ac9f09f292e3c commit 882c35e41275c1eb98a5a8f3444ac9f09f292e3c Author: Doug Moore AuthorDate: 2022-06-30 17:27:33 +0000 Commit: Doug Moore CommitDate: 2022-08-01 05:37:37 +0000 rb_tree: silence coverity Add comments to RB_INSERT_COLOR to silence coverity warnings about the use of an uninitialized variable. Since other static analyzers will complain too, add a comment to explain why the complaints are unwarranted. Reviewed by: markj MFC after: 3 weeks Differential Revision: https://reviews.freebsd.org/D35671 (cherry picked from commit 91b30f7ad22642979b56a56b211843cbd9d35984) --- sys/sys/tree.h | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/sys/sys/tree.h b/sys/sys/tree.h index 4cdd9548ba62..2206469db492 100644 --- a/sys/sys/tree.h +++ b/sys/sys/tree.h @@ -464,6 +464,17 @@ struct { \ attr void \ name##_RB_INSERT_COLOR(struct name *head, struct type *elm) \ { \ + /* \ + * Initially, elm is a leaf. Either its parent was previously \ + * a leaf, with two black null children, or an interior node \ + * with a black non-null child and a red null child. The \ + * balance criterion "the rank of any leaf is 1" precludes the \ + * possibility of two red null children for the initial parent. \ + * So the first loop iteration cannot lead to accessing an \ + * uninitialized 'child', and a later iteration can only happen \ + * when a value has been assigned to 'child' in the previous \ + * one. \ + */ \ struct type *child, *parent; \ while ((parent = RB_PARENT(elm, field)) != NULL) { \ if (RB_LEFT(parent, field) == elm) { \ @@ -478,6 +489,7 @@ name##_RB_INSERT_COLOR(struct name *head, struct type *elm) \ } \ if (!RB_RED_RIGHT(elm, field)) { \ RB_FLIP_LEFT(elm, field); \ + /* coverity[uninit_use] */ \ RB_ROTATE_LEFT(head, elm, child, field);\ if (RB_RED_LEFT(child, field)) \ RB_FLIP_RIGHT(elm, field); \ @@ -498,6 +510,7 @@ name##_RB_INSERT_COLOR(struct name *head, struct type *elm) \ } \ if (!RB_RED_LEFT(elm, field)) { \ RB_FLIP_RIGHT(elm, field); \ + /* coverity[uninit_use] */ \ RB_ROTATE_RIGHT(head, elm, child, field);\ if (RB_RED_RIGHT(child, field)) \ RB_FLIP_LEFT(elm, field); \